| Message ID | 20200817150301.2914161-2-u@pkh.me |
|---|---|
| State | Accepted |
| Commit | 4dbd055d5a8a91dc1bedc75da74607c9603e8e1e |
| Headers | show |
| Series | [FFmpeg-devel,1/2] avcodec/dvbsub: remove useless indirection in dvbsub_encode. | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
Clement Boesch (12020-08-17): > --- > libavcodec/Makefile | 2 +- > libavcodec/{dvbsub.c => dvbsubenc.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename libavcodec/{dvbsub.c => dvbsubenc.c} (100%) Both changes look good to me, but I do not maintain this. Regards;
> Am 17.08.2020 um 17:03 schrieb Clément Bœsch <u@pkh.me>: > > --- > libavcodec/Makefile | 2 +- > libavcodec/{dvbsub.c => dvbsubenc.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename libavcodec/{dvbsub.c => dvbsubenc.c} (100%) Doesn’t this make using git blame harder? Carl Eugen
On Mon, Aug 17, 2020 at 05:09:12PM +0200, Carl Eugen Hoyos wrote: > > > > Am 17.08.2020 um 17:03 schrieb Clément Bœsch <u@pkh.me>: > > > > --- > > libavcodec/Makefile | 2 +- > > libavcodec/{dvbsub.c => dvbsubenc.c} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > rename libavcodec/{dvbsub.c => dvbsubenc.c} (100%) > > Doesn’t this make using git blame harder? > No, the ownership is reconstructed properly by default Regards,
On Mon, Aug 17, 2020 at 05:09:12PM +0200, Carl Eugen Hoyos wrote: > > > > Am 17.08.2020 um 17:03 schrieb Clément Bœsch <u@pkh.me>: > > > > --- > > libavcodec/Makefile | 2 +- > > libavcodec/{dvbsub.c => dvbsubenc.c} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > rename libavcodec/{dvbsub.c => dvbsubenc.c} (100%) > > Doesn’t this make using git blame harder? git blame has -C / -M options to adjust copy/move following theres also a diff.renames so this should not be a problem i think thx [...]
diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 3431ba2dca..f9c8c28d76 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -293,7 +293,7 @@ OBJS-$(CONFIG_DSICINVIDEO_DECODER) += dsicinvideo.o OBJS-$(CONFIG_DSS_SP_DECODER) += dss_sp.o OBJS-$(CONFIG_DST_DECODER) += dstdec.o dsd.o OBJS-$(CONFIG_DVBSUB_DECODER) += dvbsubdec.o -OBJS-$(CONFIG_DVBSUB_ENCODER) += dvbsub.o +OBJS-$(CONFIG_DVBSUB_ENCODER) += dvbsubenc.o OBJS-$(CONFIG_DVDSUB_DECODER) += dvdsubdec.o dvdsub.o OBJS-$(CONFIG_DVDSUB_ENCODER) += dvdsubenc.o dvdsub.o OBJS-$(CONFIG_DVAUDIO_DECODER) += dvaudiodec.o diff --git a/libavcodec/dvbsub.c b/libavcodec/dvbsubenc.c similarity index 100% rename from libavcodec/dvbsub.c rename to libavcodec/dvbsubenc.c
--- libavcodec/Makefile | 2 +- libavcodec/{dvbsub.c => dvbsubenc.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename libavcodec/{dvbsub.c => dvbsubenc.c} (100%)