diff mbox series

[FFmpeg-devel,2/3] avcodec/cbs_av1: infer frame_type when parsing a show_existing_frame frame

Message ID 20200823192358.12087-2-jamrial@gmail.com
State Accepted
Commit 6c20207dceefa0452c65c719f0326cbc0177e827
Headers show
Series [FFmpeg-devel,1/3] avcodec/cbs_av1: infer frame sizes when not coded in the bitstream | expand

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

James Almer Aug. 23, 2020, 7:23 p.m. UTC
Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/cbs_av1_syntax_template.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Xu, Guangxin Aug. 24, 2020, 7:57 a.m. UTC | #1
May not related to this patch.
When we have show_existing_frame and the frame_type is key frame, do we need do "Reference frame update"?

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James
> Almer
> Sent: Monday, August 24, 2020 3:24 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 2/3] avcodec/cbs_av1: infer frame_type when
> parsing a show_existing_frame frame
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/cbs_av1_syntax_template.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/cbs_av1_syntax_template.c
> b/libavcodec/cbs_av1_syntax_template.c
> index dedd549572..28d9ab9817 100644
> --- a/libavcodec/cbs_av1_syntax_template.c
> +++ b/libavcodec/cbs_av1_syntax_template.c
> @@ -1299,6 +1299,7 @@ static int
> FUNC(uncompressed_header)(CodedBitstreamContext *ctx, RWContext *rw,
>              else
>                  infer(refresh_frame_flags, 0);
> 
> +            infer(frame_type,            frame->frame_type);
>              infer(frame_width_minus_1,   frame->upscaled_width - 1);
>              infer(frame_height_minus_1,  frame->frame_height - 1);
>              infer(render_width_minus_1,  frame->render_width - 1);
> --
> 2.27.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
diff mbox series

Patch

diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c
index dedd549572..28d9ab9817 100644
--- a/libavcodec/cbs_av1_syntax_template.c
+++ b/libavcodec/cbs_av1_syntax_template.c
@@ -1299,6 +1299,7 @@  static int FUNC(uncompressed_header)(CodedBitstreamContext *ctx, RWContext *rw,
             else
                 infer(refresh_frame_flags, 0);
 
+            infer(frame_type,            frame->frame_type);
             infer(frame_width_minus_1,   frame->upscaled_width - 1);
             infer(frame_height_minus_1,  frame->frame_height - 1);
             infer(render_width_minus_1,  frame->render_width - 1);