diff mbox series

[FFmpeg-devel,2/8] h264_metadata_bsf: Use common cbs bsf implementation

Message ID 20200823223310.233061-2-sw@jkqxz.net
State New
Headers show
Series [FFmpeg-devel,1/8] cbs: Implement common parts of cbs-based bitstream filters separately
Related show

Checks

Context Check Description
andriy/default pending
andriy/configure warning Failed to apply patch

Commit Message

Mark Thompson Aug. 23, 2020, 10:33 p.m. UTC
---
 libavcodec/h264_metadata_bsf.c | 225 +++++++--------------------------
 1 file changed, 45 insertions(+), 180 deletions(-)
diff mbox series

Patch

diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c
index 7d6d871240..4243a8da98 100644
--- a/libavcodec/h264_metadata_bsf.c
+++ b/libavcodec/h264_metadata_bsf.c
@@ -22,20 +22,13 @@ 
 #include "libavutil/opt.h"
 
 #include "bsf.h"
-#include "bsf_internal.h"
 #include "cbs.h"
+#include "cbs_bsf.h"
 #include "cbs_h264.h"
 #include "h264.h"
 #include "h264_levels.h"
 #include "h264_sei.h"
 
-enum {
-    PASS,
-    INSERT,
-    REMOVE,
-    EXTRACT,
-};
-
 enum {
     FLIP_HORIZONTAL = 1,
     FLIP_VERTICAL   = 2,
@@ -47,11 +40,7 @@  enum {
 };
 
 typedef struct H264MetadataContext {
-    const AVClass *class;
-
-    CodedBitstreamContext *input;
-    CodedBitstreamContext *output;
-    CodedBitstreamFragment access_unit;
+    CBSBSFContext common;
 
     int done_first_au;
 
@@ -332,49 +321,6 @@  static int h264_metadata_update_sps(AVBSFContext *bsf,
     return 0;
 }
 
-static int h264_metadata_update_side_data(AVBSFContext *bsf, AVPacket *pkt)
-{
-    H264MetadataContext *ctx = bsf->priv_data;
-    CodedBitstreamFragment *au = &ctx->access_unit;
-    uint8_t *side_data;
-    int side_data_size;
-    int err, i;
-
-    side_data = av_packet_get_side_data(pkt, AV_PKT_DATA_NEW_EXTRADATA,
-                                        &side_data_size);
-    if (!side_data_size)
-        return 0;
-
-    err = ff_cbs_read(ctx->input, au, side_data, side_data_size);
-    if (err < 0) {
-        av_log(bsf, AV_LOG_ERROR, "Failed to read extradata from packet side data.\n");
-        return err;
-    }
-
-    for (i = 0; i < au->nb_units; i++) {
-        if (au->units[i].type == H264_NAL_SPS) {
-            err = h264_metadata_update_sps(bsf, au->units[i].content);
-            if (err < 0)
-                return err;
-        }
-    }
-
-    err = ff_cbs_write_fragment_data(ctx->output, au);
-    if (err < 0) {
-        av_log(bsf, AV_LOG_ERROR, "Failed to write extradata into packet side data.\n");
-        return err;
-    }
-
-    side_data = av_packet_new_side_data(pkt, AV_PKT_DATA_NEW_EXTRADATA, au->data_size);
-    if (!side_data)
-        return AVERROR(ENOMEM);
-    memcpy(side_data, au->data, au->data_size);
-
-    ff_cbs_fragment_reset(au);
-
-    return 0;
-}
-
 static int h264_metadata_handle_display_orientation(AVBSFContext *bsf,
                                                     AVPacket *pkt,
                                                     CodedBitstreamFragment *au,
@@ -398,8 +344,8 @@  static int h264_metadata_handle_display_orientation(AVBSFContext *bsf,
                 continue;
             disp = &sei->payload[j].payload.display_orientation;
 
-            if (ctx->display_orientation == REMOVE ||
-                ctx->display_orientation == INSERT) {
+            if (ctx->display_orientation == BSF_ELEMENT_REMOVE ||
+                ctx->display_orientation == BSF_ELEMENT_INSERT) {
                 ff_cbs_h264_delete_sei_message(au, &au->units[i], j);
                 continue;
             }
@@ -428,7 +374,7 @@  static int h264_metadata_handle_display_orientation(AVBSFContext *bsf,
         }
     }
 
-    if (ctx->display_orientation == INSERT) {
+    if (ctx->display_orientation == BSF_ELEMENT_INSERT) {
         H264RawSEIPayload payload = {
             .payload_type = H264_SEI_TYPE_DISPLAY_ORIENTATION,
         };
@@ -517,41 +463,21 @@  static int h264_metadata_handle_display_orientation(AVBSFContext *bsf,
     return 0;
 }
 
-static int h264_metadata_filter(AVBSFContext *bsf, AVPacket *pkt)
+static int h264_metadata_update_fragment(AVBSFContext *bsf, AVPacket *pkt,
+                                         CodedBitstreamFragment *au)
 {
     H264MetadataContext *ctx = bsf->priv_data;
-    CodedBitstreamFragment *au = &ctx->access_unit;
     int err, i, j, has_sps, seek_point;
 
-    err = ff_bsf_get_packet_ref(bsf, pkt);
-    if (err < 0)
-        return err;
-
-    err = h264_metadata_update_side_data(bsf, pkt);
-    if (err < 0)
-        goto fail;
-
-    err = ff_cbs_read_packet(ctx->input, au, pkt);
-    if (err < 0) {
-        av_log(bsf, AV_LOG_ERROR, "Failed to read packet.\n");
-        goto fail;
-    }
-
-    if (au->nb_units == 0) {
-        av_log(bsf, AV_LOG_ERROR, "No NAL units in packet.\n");
-        err = AVERROR_INVALIDDATA;
-        goto fail;
-    }
-
     // If an AUD is present, it must be the first NAL unit.
     if (au->units[0].type == H264_NAL_AUD) {
-        if (ctx->aud == REMOVE)
+        if (ctx->aud == BSF_ELEMENT_REMOVE)
             ff_cbs_delete_unit(au, 0);
     } else {
-        if (ctx->aud == INSERT) {
+        if (ctx->aud == BSF_ELEMENT_INSERT && pkt) {
             err = h264_metadata_insert_aud(bsf, au);
             if (err < 0)
-                goto fail;
+                return err;
         }
     }
 
@@ -560,25 +486,29 @@  static int h264_metadata_filter(AVBSFContext *bsf, AVPacket *pkt)
         if (au->units[i].type == H264_NAL_SPS) {
             err = h264_metadata_update_sps(bsf, au->units[i].content);
             if (err < 0)
-                goto fail;
+                return err;
             has_sps = 1;
         }
     }
 
-    // The current packet should be treated as a seek point for metadata
-    // insertion if any of:
-    // - It is the first packet in the stream.
-    // - It contains an SPS, indicating that a sequence might start here.
-    // - It is marked as containing a key frame.
-    seek_point = !ctx->done_first_au || has_sps ||
-        (pkt->flags & AV_PKT_FLAG_KEY);
+    if (pkt) {
+        // The current packet should be treated as a seek point for metadata
+        // insertion if any of:
+        // - It is the first packet in the stream.
+        // - It contains an SPS, indicating that a sequence might start here.
+        // - It is marked as containing a key frame.
+        seek_point = !ctx->done_first_au || has_sps ||
+            (pkt->flags & AV_PKT_FLAG_KEY);
+    } else {
+        seek_point = 0;
+    }
 
     if (ctx->sei_user_data && seek_point) {
         err = ff_cbs_h264_add_sei_message(au, &ctx->sei_user_data_payload);
         if (err < 0) {
             av_log(bsf, AV_LOG_ERROR, "Failed to add user data SEI "
                    "message to access unit.\n");
-            goto fail;
+            return err;
         }
     }
 
@@ -603,41 +533,33 @@  static int h264_metadata_filter(AVBSFContext *bsf, AVPacket *pkt)
         }
     }
 
-    if (ctx->display_orientation != PASS) {
+    if (ctx->display_orientation != BSF_ELEMENT_PASS) {
         err = h264_metadata_handle_display_orientation(bsf, pkt, au,
                                                        seek_point);
         if (err < 0)
-            goto fail;
+            return err;
     }
 
-    err = ff_cbs_write_packet(ctx->output, pkt, au);
-    if (err < 0) {
-        av_log(bsf, AV_LOG_ERROR, "Failed to write packet.\n");
-        goto fail;
-    }
-
-    ctx->done_first_au = 1;
-
-    err = 0;
-fail:
-    ff_cbs_fragment_reset(au);
-
-    if (err < 0)
-        av_packet_unref(pkt);
-
-    return err;
+    if (pkt)
+        ctx->done_first_au = 1;
+    return 0;
 }
 
+static const CBSBSFType h264_metadata_type = {
+    .codec_id        = AV_CODEC_ID_H264,
+    .fragment_name   = "access unit",
+    .unit_name       = "NAL unit",
+    .update_fragment = &h264_metadata_update_fragment,
+};
+
 static int h264_metadata_init(AVBSFContext *bsf)
 {
     H264MetadataContext *ctx = bsf->priv_data;
-    CodedBitstreamFragment *au = &ctx->access_unit;
-    int err, i;
 
     if (ctx->sei_user_data) {
         H264RawSEIUserDataUnregistered *udu =
             &ctx->sei_user_data_payload.payload.user_data_unregistered;
-        int j;
+        int i, j;
 
         ctx->sei_user_data_payload.payload_type =
             H264_SEI_TYPE_USER_DATA_UNREGISTERED;
@@ -667,67 +589,18 @@  static int h264_metadata_init(AVBSFContext *bsf)
         } else {
             av_log(bsf, AV_LOG_ERROR, "Invalid user data: "
                    "must be \"UUID+string\".\n");
-            err = AVERROR(EINVAL);
-            goto fail;
-        }
-    }
-
-    err = ff_cbs_init(&ctx->input,  AV_CODEC_ID_H264, bsf);
-    if (err < 0)
-        return err;
-    err = ff_cbs_init(&ctx->output, AV_CODEC_ID_H264, bsf);
-    if (err < 0)
-        return err;
-
-    if (bsf->par_in->extradata) {
-        err = ff_cbs_read_extradata(ctx->input, au, bsf->par_in);
-        if (err < 0) {
-            av_log(bsf, AV_LOG_ERROR, "Failed to read extradata.\n");
-            goto fail;
-        }
-
-        for (i = 0; i < au->nb_units; i++) {
-            if (au->units[i].type == H264_NAL_SPS) {
-                err = h264_metadata_update_sps(bsf, au->units[i].content);
-                if (err < 0)
-                    goto fail;
-            }
-        }
-
-        err = ff_cbs_write_extradata(ctx->output, bsf->par_out, au);
-        if (err < 0) {
-            av_log(bsf, AV_LOG_ERROR, "Failed to write extradata.\n");
-            goto fail;
+            return AVERROR(EINVAL);
         }
     }
 
-    err = 0;
-fail:
-    ff_cbs_fragment_reset(au);
-    return err;
-}
-
-static void h264_metadata_close(AVBSFContext *bsf)
-{
-    H264MetadataContext *ctx = bsf->priv_data;
-
-    ff_cbs_fragment_free(&ctx->access_unit);
-    ff_cbs_close(&ctx->input);
-    ff_cbs_close(&ctx->output);
+    return ff_cbs_bsf_init(bsf, &h264_metadata_type);
 }
 
 #define OFFSET(x) offsetof(H264MetadataContext, x)
 #define FLAGS (AV_OPT_FLAG_VIDEO_PARAM|AV_OPT_FLAG_BSF_PARAM)
 static const AVOption h264_metadata_options[] = {
-    { "aud", "Access Unit Delimiter NAL units",
-        OFFSET(aud), AV_OPT_TYPE_INT,
-        { .i64 = PASS }, PASS, REMOVE, FLAGS, "aud" },
-    { "pass",   NULL, 0, AV_OPT_TYPE_CONST,
-        { .i64 = PASS   }, .flags = FLAGS, .unit = "aud" },
-    { "insert", NULL, 0, AV_OPT_TYPE_CONST,
-        { .i64 = INSERT }, .flags = FLAGS, .unit = "aud" },
-    { "remove", NULL, 0, AV_OPT_TYPE_CONST,
-        { .i64 = REMOVE }, .flags = FLAGS, .unit = "aud" },
+    BSF_ELEMENT_OPTIONS_PIR("aud", "Access Unit Delimiter NAL units",
+                            aud, "aud"),
 
     { "sample_aspect_ratio", "Set sample aspect ratio (table E-1)",
         OFFSET(sample_aspect_ratio), AV_OPT_TYPE_RATIONAL,
@@ -783,17 +656,9 @@  static const AVOption h264_metadata_options[] = {
     { "delete_filler", "Delete all filler (both NAL and SEI)",
         OFFSET(delete_filler), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, FLAGS},
 
-    { "display_orientation", "Display orientation SEI",
-        OFFSET(display_orientation), AV_OPT_TYPE_INT,
-        { .i64 = PASS }, PASS, EXTRACT, FLAGS, "disp_or" },
-    { "pass",    NULL, 0, AV_OPT_TYPE_CONST,
-        { .i64 = PASS    }, .flags = FLAGS, .unit = "disp_or" },
-    { "insert",  NULL, 0, AV_OPT_TYPE_CONST,
-        { .i64 = INSERT  }, .flags = FLAGS, .unit = "disp_or" },
-    { "remove",  NULL, 0, AV_OPT_TYPE_CONST,
-        { .i64 = REMOVE  }, .flags = FLAGS, .unit = "disp_or" },
-    { "extract", NULL, 0, AV_OPT_TYPE_CONST,
-        { .i64 = EXTRACT }, .flags = FLAGS, .unit = "disp_or" },
+    BSF_ELEMENT_OPTIONS_PIRE("display_orientation",
+                             "Display orientation SEI",
+                             display_orientation, "disp_or"),
 
     { "rotate", "Set rotation in display orientation SEI (anticlockwise angle in degrees)",
         OFFSET(rotate), AV_OPT_TYPE_DOUBLE,
@@ -857,7 +722,7 @@  const AVBitStreamFilter ff_h264_metadata_bsf = {
     .priv_data_size = sizeof(H264MetadataContext),
     .priv_class     = &h264_metadata_class,
     .init           = &h264_metadata_init,
-    .close          = &h264_metadata_close,
-    .filter         = &h264_metadata_filter,
+    .close          = &ff_cbs_bsf_close,
+    .filter         = &ff_cbs_bsf_filter,
     .codec_ids      = h264_metadata_codec_ids,
 };