From patchwork Tue Aug 25 14:09:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 21914 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 42BF844B6CA for ; Tue, 25 Aug 2020 17:10:25 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2E08068AF22; Tue, 25 Aug 2020 17:10:25 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A329168A9AA for ; Tue, 25 Aug 2020 17:10:15 +0300 (EEST) Received: by mail-ej1-f68.google.com with SMTP id a26so16753074ejc.2 for ; Tue, 25 Aug 2020 07:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jl3h69G2tRhuItC7MS9dIxwNjAGzFo2lKYx/ChbOWqU=; b=IndeCf9xWPf2+KPF0jaXGVv3thw776/00Txp4ml2sTjKOWzQXwUkD+4PBHWlOkq3Q2 kGM2HcOFdKc6j2BM3OWh957fOOjxjQne6jP7YakLrKFkYYZ1sUURF2HMMUf/3kOdluK3 QENR2x5XLOMSYu5DL5WnprM/pWJUrHV98l4sYVT6CM5cAy53/WTqh6uHC3JuaSgIV4Uc JMpqDp8ttrX9grthn5OKzF8TXHGtctpgFOInxY7lxgN1XLLgjXCyNkJ8hIMDWntbaALe V77L5K00IHX2Jg4CDIvpfsLJUhRTN/lrd6G2nepqBfSL2XnmMdC888NCAiSiR90yOSEH 0zTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jl3h69G2tRhuItC7MS9dIxwNjAGzFo2lKYx/ChbOWqU=; b=l5XtCatgukDa+NVrlehCjeraWSpiDGbphTH535Nh+CMYDMn79wpSeiz1GmlUvqpDcj WOaLyxcVBFyFdKJ868jfAaC0DZhAZACFGTJkKAbdZMMeirm1k873fOYkMlZTplUfDAQp ZaeN6WJ436/pt1TWRO4RrIA8fgPj68qnpcIKMz79n2VeEkhseBOyVBkGk2Uq3VBVIKfb I4HTRi2iDaevewrxdC69F1uTM0hCdTpTw2Qzg8MNswfpzgkvHBXHiWcG8JOkbFQW5UfY wN18Z6M8ArdvRJK+MLREsAiyF80l6Ow+ncRNt1by2cioZxRPP6loiyAOUYnS/NpL3DJ8 7ROw== X-Gm-Message-State: AOAM533z1vVDLMBsBoNclUDvJZQnsfaHBsJeaYpXw2GPO5INx54ZbcHm lXc2W+AFwzwUtA6NjQLCeBWQokgI1Go= X-Google-Smtp-Source: ABdhPJyiQrGR9wnfxufuHaf8wcztcDN+lDTYzDQb5E2QoQZjg/Su9gAmKtAqTUSZQV07V09qk+6/Kg== X-Received: by 2002:a17:906:2bdb:: with SMTP id n27mr11082534ejg.12.1598364614836; Tue, 25 Aug 2020 07:10:14 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc1fb0f.dynamic.kabel-deutschland.de. [188.193.251.15]) by smtp.gmail.com with ESMTPSA id k25sm10169806edx.96.2020.08.25.07.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 07:10:14 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 25 Aug 2020 16:09:17 +0200 Message-Id: <20200825140927.16433-9-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200825140927.16433-1-andreas.rheinhardt@gmail.com> References: <20200825140927.16433-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 09/19] avfilter/vf_bm3d: Don't allocate inpad names X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" These names are always the same, so not using duplicates saves allocations, checks for the allocations as well as frees. Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_bm3d.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/libavfilter/vf_bm3d.c b/libavfilter/vf_bm3d.c index e5d2b8bc63..18d13b25ff 100644 --- a/libavfilter/vf_bm3d.c +++ b/libavfilter/vf_bm3d.c @@ -942,27 +942,19 @@ static av_cold int init(AVFilterContext *ctx) } pad.type = AVMEDIA_TYPE_VIDEO; - pad.name = av_strdup("source"); + pad.name = "source"; pad.config_props = config_input; - if (!pad.name) - return AVERROR(ENOMEM); - if ((ret = ff_insert_inpad(ctx, 0, &pad)) < 0) { - av_freep(&pad.name); + if ((ret = ff_insert_inpad(ctx, 0, &pad)) < 0) return ret; - } if (s->ref) { pad.type = AVMEDIA_TYPE_VIDEO; - pad.name = av_strdup("reference"); + pad.name = "reference"; pad.config_props = NULL; - if (!pad.name) - return AVERROR(ENOMEM); - if ((ret = ff_insert_inpad(ctx, 1, &pad)) < 0) { - av_freep(&pad.name); + if ((ret = ff_insert_inpad(ctx, 1, &pad)) < 0) return ret; - } } return 0; @@ -1027,9 +1019,6 @@ static av_cold void uninit(AVFilterContext *ctx) BM3DContext *s = ctx->priv; int i; - for (i = 0; i < ctx->nb_inputs; i++) - av_freep(&ctx->input_pads[i].name); - if (s->ref) ff_framesync_uninit(&s->fs);