From patchwork Thu Aug 27 04:17:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Fu, Ting" X-Patchwork-Id: 21939 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id C329F448E87 for ; Thu, 27 Aug 2020 07:22:49 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A95D4688392; Thu, 27 Aug 2020 07:22:49 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 755906880D5 for ; Thu, 27 Aug 2020 07:22:43 +0300 (EEST) IronPort-SDR: 5pGX7Nu42sRlmy64Wh8rPizL6tFt0SRdtlD5vOty8twqCqJU4a8HGk0/f7aR09sqtJevlqO4Vb 1+072+2YzZsg== X-IronPort-AV: E=McAfee;i="6000,8403,9725"; a="174471148" X-IronPort-AV: E=Sophos;i="5.76,358,1592895600"; d="scan'208";a="174471148" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 21:22:41 -0700 IronPort-SDR: TWscbiXvU7NSF/FI4zffFaUSboxkG5qbmyfl9cLLRhcFLYm0L9t6e8zo8Bq2+8cgQ/rcEfHmO8 QFaE5q7n750g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,358,1592895600"; d="scan'208";a="500492468" Received: from semmer-ubuntu.sh.intel.com ([10.239.159.54]) by fmsmga005.fm.intel.com with ESMTP; 26 Aug 2020 21:22:40 -0700 From: Ting Fu To: ffmpeg-devel@ffmpeg.org Date: Thu, 27 Aug 2020 12:17:21 +0800 Message-Id: <20200827041722.29262-1-ting.fu@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH 1/2] dnn/openvino: add log error message X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Ting Fu --- libavfilter/dnn/dnn_backend_openvino.c | 51 ++++++++++++++++++++++---- 1 file changed, 43 insertions(+), 8 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 034dee1839..5d6d3ed542 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/libavfilter/dnn/dnn_backend_openvino.c @@ -28,7 +28,12 @@ #include "libavutil/avassert.h" #include +typedef struct OVContext { + const AVClass *class; +} OVContext; + typedef struct OVModel{ + OVContext ctx; ie_core_t *core; ie_network_t *network; ie_executable_network_t *exe_network; @@ -36,6 +41,14 @@ typedef struct OVModel{ ie_blob_t *input_blob; } OVModel; +static const AVClass dnn_openvino_class = { + .class_name = "dnn_openvino", + .item_name = av_default_item_name, + .option = NULL, + .version = LIBAVUTIL_VERSION_INT, + .category = AV_CLASS_CATEGORY_FILTER, +}; + static DNNDataType precision_to_datatype(precision_e precision) { switch (precision) @@ -51,6 +64,7 @@ static DNNDataType precision_to_datatype(precision_e precision) static DNNReturnType get_input_ov(void *model, DNNData *input, const char *input_name) { OVModel *ov_model = (OVModel *)model; + OVContext *ctx = &ov_model->ctx; char *model_input_name = NULL; IEStatusCode status; size_t model_input_count = 0; @@ -58,25 +72,33 @@ static DNNReturnType get_input_ov(void *model, DNNData *input, const char *input precision_e precision; status = ie_network_get_inputs_number(ov_model->network, &model_input_count); - if (status != OK) + if (status != OK) { + av_log(ctx, AV_LOG_ERROR, "Failed to get input count\n"); return DNN_ERROR; + } for (size_t i = 0; i < model_input_count; i++) { status = ie_network_get_input_name(ov_model->network, i, &model_input_name); - if (status != OK) + if (status != OK) { + av_log(ctx, AV_LOG_ERROR, "Failed to get No.%d input's name\n", (int)i); return DNN_ERROR; + } if (strcmp(model_input_name, input_name) == 0) { ie_network_name_free(&model_input_name); status |= ie_network_get_input_dims(ov_model->network, input_name, &dims); status |= ie_network_get_input_precision(ov_model->network, input_name, &precision); - if (status != OK) + if (status != OK) { + av_log(ctx, AV_LOG_ERROR, "Failed to get No.%d input's dims or precision\n", (int)i); return DNN_ERROR; + } // The order of dims in the openvino is fixed and it is always NCHW for 4-D data. // while we pass NHWC data from FFmpeg to openvino status = ie_network_set_input_layout(ov_model->network, input_name, NHWC); - if (status != OK) + if (status != OK) { + av_log(ctx, AV_LOG_ERROR, "Input \"%s\" does not match layout NHWC\n", input_name); return DNN_ERROR; + } input->channels = dims.dims[1]; input->height = dims.dims[2]; @@ -88,12 +110,14 @@ static DNNReturnType get_input_ov(void *model, DNNData *input, const char *input ie_network_name_free(&model_input_name); } + av_log(ctx, AV_LOG_ERROR, "Could not find \"%s\" in model\n", model_input_name); return DNN_ERROR; } static DNNReturnType set_input_ov(void *model, DNNData *input, const char *input_name) { OVModel *ov_model = (OVModel *)model; + OVContext *ctx = &ov_model->ctx; IEStatusCode status; dimensions_t dims; precision_e precision; @@ -129,6 +153,7 @@ err: ie_blob_free(&ov_model->input_blob); if (ov_model->infer_request) ie_infer_request_free(&ov_model->infer_request); + av_log(ctx, AV_LOG_ERROR, "Failed to create inference instance or get input data/dims/precision/memory\n"); return DNN_ERROR; } @@ -147,6 +172,7 @@ DNNModel *ff_dnn_load_model_ov(const char *model_filename, const char *options) ov_model = av_mallocz(sizeof(OVModel)); if (!ov_model) goto err; + ov_model->ctx.class = &dnn_openvino_class; status = ie_core_create("", &ov_model->core); if (status != OK) @@ -188,25 +214,34 @@ DNNReturnType ff_dnn_execute_model_ov(const DNNModel *model, DNNData *outputs, c precision_e precision; ie_blob_buffer_t blob_buffer; OVModel *ov_model = (OVModel *)model->model; + OVContext *ctx = &ov_model->ctx; IEStatusCode status = ie_infer_request_infer(ov_model->infer_request); - if (status != OK) + if (status != OK) { + av_log(ctx, AV_LOG_ERROR, "Failed to start synchronous model inference\n"); return DNN_ERROR; + } for (uint32_t i = 0; i < nb_output; ++i) { const char *output_name = output_names[i]; ie_blob_t *output_blob = NULL; status = ie_infer_request_get_blob(ov_model->infer_request, output_name, &output_blob); - if (status != OK) + if (status != OK) { + av_log(ctx, AV_LOG_ERROR, "Failed to get model output data\n"); return DNN_ERROR; + } status = ie_blob_get_buffer(output_blob, &blob_buffer); - if (status != OK) + if (status != OK) { + av_log(ctx, AV_LOG_ERROR, "Failed to access output memory\n"); return DNN_ERROR; + } status |= ie_blob_get_dims(output_blob, &dims); status |= ie_blob_get_precision(output_blob, &precision); - if (status != OK) + if (status != OK) { + av_log(ctx, AV_LOG_ERROR, "Failed to get dims or precision of output\n"); return DNN_ERROR; + } outputs[i].channels = dims.dims[1]; outputs[i].height = dims.dims[2];