| Message ID | 20200829175626.11682-10-andreas.rheinhardt@gmail.com |
|---|---|
| State | Accepted |
| Commit | 6fad76b51d24aba31abd35533ee747e6c4df8ec1 |
| Headers | show |
| Series | [FFmpeg-devel,01/13] avcodec/cinepakenc: Cleanup generically after init failure | expand |
| Context | Check | Description |
|---|---|---|
| andriy/default | pending | |
| andriy/make | success | Make finished |
| andriy/make_fate | success | Make fate finished |
On 8/29/20, Andreas Rheinhardt <andreas.rheinhardt@gmail.com> wrote: > The comment referred to the INIT_VLC_USE_STATIC flag which has been > removed in 2009 in 595324e143b57a52e2329eb47b84395c70f93087; the > function it referred to was removed even earlier in commit > 83422c1940d963d395a64bee0cbb9c637192ce8c in 2008. > > Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> > --- > libavcodec/bitstream.c | 3 --- > 1 file changed, 3 deletions(-) > LGTM > diff --git a/libavcodec/bitstream.c b/libavcodec/bitstream.c > index d379dbc0e8..95e5092b44 100644 > --- a/libavcodec/bitstream.c > +++ b/libavcodec/bitstream.c > @@ -266,9 +266,6 @@ static int build_table(VLC *vlc, int table_nb_bits, int > nb_codes, > > 'wrap' and 'size' make it possible to use any memory configuration and > types > (byte/word/long) to store the 'bits', 'codes', and 'symbols' tables. > - > - 'use_static' should be set to 1 for tables, which should be freed > - with av_free_static(), 0 if ff_free_vlc() will be used. > */ > int ff_init_vlc_sparse(VLC *vlc_arg, int nb_bits, int nb_codes, > const void *bits, int bits_wrap, int bits_size, > -- > 2.20.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff --git a/libavcodec/bitstream.c b/libavcodec/bitstream.c index d379dbc0e8..95e5092b44 100644 --- a/libavcodec/bitstream.c +++ b/libavcodec/bitstream.c @@ -266,9 +266,6 @@ static int build_table(VLC *vlc, int table_nb_bits, int nb_codes, 'wrap' and 'size' make it possible to use any memory configuration and types (byte/word/long) to store the 'bits', 'codes', and 'symbols' tables. - - 'use_static' should be set to 1 for tables, which should be freed - with av_free_static(), 0 if ff_free_vlc() will be used. */ int ff_init_vlc_sparse(VLC *vlc_arg, int nb_bits, int nb_codes, const void *bits, int bits_wrap, int bits_size,
The comment referred to the INIT_VLC_USE_STATIC flag which has been removed in 2009 in 595324e143b57a52e2329eb47b84395c70f93087; the function it referred to was removed even earlier in commit 83422c1940d963d395a64bee0cbb9c637192ce8c in 2008. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> --- libavcodec/bitstream.c | 3 --- 1 file changed, 3 deletions(-)