From patchwork Sun Aug 30 14:50:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 22009 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id D474A44B78E for ; Sun, 30 Aug 2020 17:51:32 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B1C0668AEEC; Sun, 30 Aug 2020 17:51:32 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C9B4368AE9A for ; Sun, 30 Aug 2020 17:51:25 +0300 (EEST) Received: by mail-wm1-f66.google.com with SMTP id e17so3026316wme.0 for ; Sun, 30 Aug 2020 07:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SnWhQj45NOrEA95IFE3uxEGXEndw1vy2Dtxjh3oqG3g=; b=Jl/qZnwlkBNJxWcJ7r8aJOEpVbTIlgZxFqbHoNtOMnfFLa1yMd51R4cFNExTDe3Fr6 oI7yNwgIIHIpTH75dxdYkgHeRamu2HXsNXKHV00Lo6ItB9FAdn2v7S7YrHQkQ5l8WWeF BTkWt+BdLJZQWVjbf+2JNp7LHB1iprKpOsRle5xADb4Ta4SDtAjLT93iyN7CT2sInFX+ wtnJ6j7zldFeSHaiE1JXiw+llfP0WABj7JPq1enHiBzxHhxJwqrxcO23x/Y6UxesGWRz lMTLiPxQiEGd+C2uOZJ/eAqxbJEwr4f46vMuqGWtZIUJJ2x0BleXHj16KDJlY6VkjuHb 85bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SnWhQj45NOrEA95IFE3uxEGXEndw1vy2Dtxjh3oqG3g=; b=ciqCpHn7vHO1f9WEvgaV+8+WgJa0n139YtLSLRsAraDd8mlaeAMl+/MbErsrVkJ9FM xvnQL3dyGA/0KTKllSDAzIrr4dVG4ZxEZeGCUBIrPEwGFLhixcPOAyZaoadenafP2XTN BlOGw/u968K6vrBhug8JOK5I6M6zgD3xbozvZ+FwfM8Te99aNLZFyZ6phzQgYrWLHYac DCO8eTMPlY7xyzi53s5rO57hj0IC7ClWo0szG5rcv8TPLU2uqNZNrCejr27s0WE5WiCQ dXhQHDzewQ345CSmbLlRik+JU41ASDu5JihLejfka/I1eoPPrvf81HJU99mBxP1KuOcM fx+Q== X-Gm-Message-State: AOAM531IE9vzW7qtfhdlWa9PCVgJ9UQxQgclJfjx5zWD6MZ6HJcSluQC Dk3tF2DZm47NgfrHPcaa3LiRzj9RfqA= X-Google-Smtp-Source: ABdhPJxhVxIv5t7rK6F+i8eUeEgxlKc9GNpPOHvaW3VLMn/FTfBun8vcDpKT3ZFWmUqr1+fl1+1M7Q== X-Received: by 2002:a1c:3187:: with SMTP id x129mr6603316wmx.107.1598799084948; Sun, 30 Aug 2020 07:51:24 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc1fb0f.dynamic.kabel-deutschland.de. [188.193.251.15]) by smtp.gmail.com with ESMTPSA id t203sm6316794wmg.43.2020.08.30.07.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 07:51:24 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 30 Aug 2020 16:50:44 +0200 Message-Id: <20200830145045.4437-4-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200830145045.4437-1-andreas.rheinhardt@gmail.com> References: <20200830145045.4437-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/5] avdevice/lavfi: Remove redundant av_packet_unref() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Since bae8844e35147f92e612a9e0b44e939a293e5bc9, the AVPacket that is intended to be used to return the demuxed packet is automatically unreferenced when the demuxer returns an error. This makes an av_packet_unref() in the lavfi demuxer redundant. Signed-off-by: Andreas Rheinhardt --- libavdevice/lavfi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c index bafc3275c9..2b4e9290dc 100644 --- a/libavdevice/lavfi.c +++ b/libavdevice/lavfi.c @@ -458,7 +458,6 @@ static int lavfi_read_packet(AVFormatContext *avctx, AVPacket *pkt) if ((ret = create_subcc_packet(avctx, frame, min_pts_sink_idx)) < 0) { av_frame_unref(frame); - av_packet_unref(pkt); return ret; }