From patchwork Mon Aug 31 04:16:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Miceli X-Patchwork-Id: 22017 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 5EAFB44B5CB for ; Mon, 31 Aug 2020 07:17:00 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3A875687F29; Mon, 31 Aug 2020 07:17:00 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D9AF768037A for ; Mon, 31 Aug 2020 07:16:53 +0300 (EEST) Received: by mail-pl1-f175.google.com with SMTP id l9so788592plt.8 for ; Sun, 30 Aug 2020 21:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=miceli-net-au.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D2x3EZcRzo03rQFeMHt2vQzHQBynafcuFKL5vJmhwoI=; b=HHh+dw+Oyk+8CGPMtuSVbEekQbsvULZd0qTNJxKJWm1dOnfBwdLANzhJYkHnOpuaeF 50BX6Bvj8BRaxcnmWzLhjybOBOOjLGQLXEXt2NVasFSnGDPQnjk16u2xsKVxVOJsZCeL JfChWtVINyTnkoVfstMJ4Kxq1HB/Aj5iRp4O2gX3nd1sSVkksLBPAbRvgl2490FhQ9fW laSy8XWixFvoAwKfqZ0j37L1oQ52TSud7HnEh2o3TT1LsOpBfqftOhxNtqfHHWndXnjs z1cFZpqYl7NlaWA5g11pkpX4iP/wRMf5mHgymo2gFrETuSJexdlLvRERnOvHWyoRvUtV cjag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D2x3EZcRzo03rQFeMHt2vQzHQBynafcuFKL5vJmhwoI=; b=G9x3V2/j0KoPpSAnM9lOUdVzfd7qg0T4WzlSFAbUC4zHOfV3Q1cIkMcTEYQQMOs81C bMQS2Q4WrQ82mVDFd7CHy00K/Nri767ilL892Ft1H7HX8SsVNQrSlUR9ebwfsS5mzPMw LQZHhvGJAkqvh/Kum7iAHA2tmdiYzJ4QSw4MqXDEK+ugIsepOd/CYdZIlphFfscxyCxq a5iC3CZE3aCxkIylQl8PKX2el09sHwlFaQAPSTO/LHaIA94QqfJWwF3qne31o+SkOM2v Hk6JDeOr769NXFQp5BNxEb+ST9KPS7+c33z+Ja/QAF0wHk7hhpiZTiyA83E+55zDsW3u C4Xg== X-Gm-Message-State: AOAM530bZhgDwXb8uMMh/MKNC5/CKOCixWaeJ0W0VeWhir4ptIQZVtOi bbXPD7po/xMCdWX+8coTARwTWdzDgDJMYWJY X-Google-Smtp-Source: ABdhPJz7yS4bo82L0KDfZWtMmixSvd7Tw+dVVmthvxpVDCbx9BURnS/MBdcV0P0P3B1yq2fFGnsjig== X-Received: by 2002:a17:90a:384c:: with SMTP id l12mr8640774pjf.27.1598847411334; Sun, 30 Aug 2020 21:16:51 -0700 (PDT) Received: from edna.localdomain (119-18-3-107.771203.syd.nbn.aussiebb.net. [119.18.3.107]) by smtp.gmail.com with ESMTPSA id ds19sm5469120pjb.43.2020.08.30.21.16.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 21:16:50 -0700 (PDT) From: Chris Miceli To: ffmpeg-devel@ffmpeg.org Date: Mon, 31 Aug 2020 14:16:39 +1000 Message-Id: <20200831041639.428116-1-chris@miceli.net.au> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libavformat/dashenc: Reduce confusion in par error message X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Chris Miceli Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" In ticket #8754 there is discourse surrounding the error message which is printed upon a mismatched aspect ratio in derived encodings. This should make it clearer to the user as to the issues which they are experiencing. --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index dc3306a56a..2d757b3a87 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1686,7 +1686,7 @@ static int dash_init(AVFormatContext *s) 1024 * 1024); if (as->par.num && av_cmp_q(par, as->par)) { - av_log(s, AV_LOG_ERROR, "Conflicting stream par values in Adaptation Set %d\n", os->as_idx); + av_log(s, AV_LOG_ERROR, "Conflicting stream aspect ratios values in Adaptation Set %d. Please ensure all adaptation sets have the same aspect ratio\n", os->as_idx); return AVERROR(EINVAL); } as->par = par;