From patchwork Thu Sep 10 01:39:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 22246 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 2BBFD44A510 for ; Thu, 10 Sep 2020 04:40:19 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0294A68B9C0; Thu, 10 Sep 2020 04:40:19 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 803E968B8A9 for ; Thu, 10 Sep 2020 04:40:09 +0300 (EEST) Received: by mail-wr1-f66.google.com with SMTP id w5so4869294wrp.8 for ; Wed, 09 Sep 2020 18:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dqhf/5EqKW4arB+rhxAIxnRanbwK9ES9+1utuyKLwy4=; b=MaWEFS4ecRUdWZ0b6vAIn7hq6+745nDTC18tSxqQdbiXybW7sIa7fwZ4hGfxN3xFww VerrjEmQNSr6pF2n2FmfFMuNO5ma51LwkD3mv75VARkTjd7TSsSZUyK97bAWWJ+IeqSk i/fXf57/i0e61hozhAhBX6qChlVBZbtpY7f9ehJoU0CC9mtLAvaCmPskTIF4gpa1tkOc wNGW5yL7ara6Urj5tWspn9QiSf3J1tu2+oVN6C4712+kFOcsxE1DYtKA0AtD0EcbLgUI uXALwkcfjGgCaWRKfih3AaGkLENlaPkkuXj/u2A6yCyiSJ3uTpaSMkecqxuuXlYuKihb +2Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dqhf/5EqKW4arB+rhxAIxnRanbwK9ES9+1utuyKLwy4=; b=mgcgeFbPDUanGH60BpdFEYbwHADPEETVNncrOx2i2BvmL8QDXJAxdIBssz21hIw4qo iEGf4Y/0/2qtLIOkDjYAsHo/YV+8lzie2FV/Vox6KeKgPM8eDr9I6dLuTZcj3NNEvNE2 8RKu1zdTsIOXGsqjA9rAvvfTxv+PTdmi0s7EBirWhuhfG2BdgLM/C7eCnRqEtR0M/5hH lJkz+CUcrKyPXjmrgbLmeywU1VO3mxtzTF9hwB4iDAp1PspkSFWilQX2SuVHFaMCUgDl uNgBgVWStCibwMnQidQsDyt1SZ8x+6nkL3bPiU6uSYcxqY/VRqkg5bczj3CgiQCrBajo mt5g== X-Gm-Message-State: AOAM533TQtITpC5QUxwyw7GcPGT70mAYcp1PsJGwUW2J8/j1bZGqIBu4 R8RvkBcAylDJ2X68OvXoEdpcn1RfL0U= X-Google-Smtp-Source: ABdhPJyhr0wWHAmu6ngrMaYnbiZmczu7u/7aZXIfZ+y71o1cmhz6H041Q3XKmFc5fmZGPzv7HiZD4w== X-Received: by 2002:a05:6000:124d:: with SMTP id j13mr6977426wrx.182.1599702008845; Wed, 09 Sep 2020 18:40:08 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc1fb0f.dynamic.kabel-deutschland.de. [188.193.251.15]) by smtp.gmail.com with ESMTPSA id n4sm1176380wmd.26.2020.09.09.18.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 18:40:08 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 10 Sep 2020 03:39:41 +0200 Message-Id: <20200910013941.14444-3-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200910013941.14444-1-andreas.rheinhardt@gmail.com> References: <20200910013941.14444-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/3] avfilter/src_movie: Fix leak of packet upon error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" If allocating the AVFrame to contain a decoded frame fails, the AVPacket containing the data intended to be decoded leaks. This commit fixes this. Signed-off-by: Andreas Rheinhardt --- libavfilter/src_movie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index 75ac3bfaf6..d83cb6d1e4 100644 --- a/libavfilter/src_movie.c +++ b/libavfilter/src_movie.c @@ -344,6 +344,7 @@ static av_cold void movie_uninit(AVFilterContext *ctx) } av_freep(&movie->st); av_freep(&movie->out_index); + av_packet_unref(&movie->pkt); if (movie->format_ctx) avformat_close_input(&movie->format_ctx); }