From patchwork Thu Sep 10 21:48:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 22268 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 711DA44B1C3 for ; Fri, 11 Sep 2020 00:52:00 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5773B68B9F5; Fri, 11 Sep 2020 00:52:00 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C3DF68B8FA for ; Fri, 11 Sep 2020 00:51:53 +0300 (EEST) Received: by mail-wm1-f66.google.com with SMTP id l9so2275321wme.3 for ; Thu, 10 Sep 2020 14:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SeAm17zV9150N7GEdGKF8p/k3BExr+bshXfdLs5NP5M=; b=Ou+9sltF35n5cDvuE/M+jkfgYNO93fafdB56ilO8bv59v7boN3f9cqjvxsN0P6bBh7 wRcmt91Y2y3vN4PXYuLikpCw16dMfXVL7l9gNVB3PN75edAIAWgDfRGjsz4q8gjJqrNl la3N3xhyfIuxAh+kmrdEIBvXd2Leb56cwRrNbUAlBIEKd7JhK/UYGgaKF5+3GW4wkZAr 7EGv/c0iJ7+zxyWY1gSO3FNtwyyppy5PYk9C0KW1nEI1Ig0WP66DkvrxwiCezOzUq6XD 7XKxCTJ34PRUvvuH/ajloH2QrXZgoiCU6m5XlIbIL7ITxrUTkvgm80U4sSgk0K7/oCLs FruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SeAm17zV9150N7GEdGKF8p/k3BExr+bshXfdLs5NP5M=; b=s22WO1AzBHhqPpMMHTvdBL9vNVuq+tZsFkxEdfAmn92lZRC6PoKFhzSSM7CSUD3O/B gJeBYxBp3t/jS4fBpUo6dgC5mam3aEx2WO3R+xHWtAfuowfecMKOadwEeTIXvQeYIHaN F/oSqgVVmnCqoR6FSRgz2j7qZQH8MtH9X923WCFTs+yfiuNM0bfm+y/1J63Vg4OoGjBM yD5UaII6+5dh3ExwKteaM0HNRWfKeWJVPdofQm3NNaBnrxDCCkLzN+7P+G/tgZCCmn6O mz9N9a0wvHR6lvMXN2SUXr3/ccxB55HxV4gI8sNSUgLsjzOZJQ9CpVmD+Yk4g9lu8cI6 KEMA== X-Gm-Message-State: AOAM530UtOH2vmAlOG1EoO633YEJVtw67LP1e1Yim+wUoNUKnMEOXg5+ zoLhjecAZC2TPxmyIsnJaarUDVPMya4= X-Google-Smtp-Source: ABdhPJzk+t59J3hVvQP1zrmcH2EZw1F82jnE9PChOl+YctvMAf3OHDiRBDG9FkFYs61roeF8Gx9IzQ== X-Received: by 2002:a7b:c359:: with SMTP id l25mr1945515wmj.187.1599774712387; Thu, 10 Sep 2020 14:51:52 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc1fb0f.dynamic.kabel-deutschland.de. [188.193.251.15]) by smtp.gmail.com with ESMTPSA id z203sm59232wmc.31.2020.09.10.14.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 14:51:51 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 10 Sep 2020 23:48:56 +0200 Message-Id: <20200910214901.25401-4-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200910214901.25401-1-andreas.rheinhardt@gmail.com> References: <20200910214901.25401-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/9] avfilter/vf_uspp: Fix potential leak of dict on error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_uspp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_uspp.c b/libavfilter/vf_uspp.c index f6fb193433..72a0f562af 100644 --- a/libavfilter/vf_uspp.c +++ b/libavfilter/vf_uspp.c @@ -362,9 +362,9 @@ static int config_input(AVFilterLink *inlink) avctx_enc->global_quality = 123; av_dict_set(&opts, "no_bitstream", "1", 0); ret = avcodec_open2(avctx_enc, enc, &opts); + av_dict_free(&opts); if (ret < 0) return ret; - av_dict_free(&opts); av_assert0(avctx_enc->codec); }