diff mbox series

[FFmpeg-devel] configure: Add atsc_a53 dependencies for H.264 and HEVC parser

Message ID 20200919181805.1327319-1-andreas.rheinhardt@gmail.com
State Superseded
Headers show
Series [FFmpeg-devel] configure: Add atsc_a53 dependencies for H.264 and HEVC parser
Related show

Checks

Context Check Description
andriy/default pending
andriy/make success Make finished
andriy/make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Sept. 19, 2020, 6:18 p.m. UTC
They need it because they make use of SEI parsing code.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Carl Eugen Hoyos Sept. 20, 2020, 10:57 p.m. UTC | #1
Am Sa., 19. Sept. 2020 um 20:18 Uhr schrieb Andreas Rheinhardt
<andreas.rheinhardt@gmail.com>:
>
> They need it because they make use of SEI parsing code.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 5d68695192..70740a7bc7 100755
> --- a/configure
> +++ b/configure
> @@ -3143,8 +3143,8 @@ wmv3_crystalhd_decoder_select="crystalhd"
>  # parsers
>  aac_parser_select="adts_header"
>  av1_parser_select="cbs_av1"
> -h264_parser_select="golomb h264dsp h264parse"
> -hevc_parser_select="hevcparse"
> +h264_parser_select="atsc_a53 golomb h264dsp h264parse"
> +hevc_parser_select="atsc_a53 hevcparse"

Please push such patches if you tested them, I would
nearly have duplicated your work.

Thank you, Carl Eugen
James Almer Sept. 20, 2020, 11:35 p.m. UTC | #2
On 9/19/2020 3:18 PM, Andreas Rheinhardt wrote:
> They need it because they make use of SEI parsing code.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 5d68695192..70740a7bc7 100755
> --- a/configure
> +++ b/configure
> @@ -3143,8 +3143,8 @@ wmv3_crystalhd_decoder_select="crystalhd"
>  # parsers
>  aac_parser_select="adts_header"
>  av1_parser_select="cbs_av1"
> -h264_parser_select="golomb h264dsp h264parse"
> -hevc_parser_select="hevcparse"
> +h264_parser_select="atsc_a53 golomb h264dsp h264parse"
> +hevc_parser_select="atsc_a53 hevcparse"

Add it to hevcparse instead as i asked on IRC, so every module pulling
it also pulls atsc_a53.

>  mpegaudio_parser_select="mpegaudioheader"
>  mpegvideo_parser_select="mpegvideo"
>  mpeg4video_parser_select="h263dsp mpegvideo qpeldsp"
>
diff mbox series

Patch

diff --git a/configure b/configure
index 5d68695192..70740a7bc7 100755
--- a/configure
+++ b/configure
@@ -3143,8 +3143,8 @@  wmv3_crystalhd_decoder_select="crystalhd"
 # parsers
 aac_parser_select="adts_header"
 av1_parser_select="cbs_av1"
-h264_parser_select="golomb h264dsp h264parse"
-hevc_parser_select="hevcparse"
+h264_parser_select="atsc_a53 golomb h264dsp h264parse"
+hevc_parser_select="atsc_a53 hevcparse"
 mpegaudio_parser_select="mpegaudioheader"
 mpegvideo_parser_select="mpegvideo"
 mpeg4video_parser_select="h263dsp mpegvideo qpeldsp"