diff mbox series

[FFmpeg-devel,v2] avformat/libsrt: print streamid at client

Message ID 20201001084314.1079100-1-raghavendra.rao@collabora.com
State Superseded
Headers show
Series [FFmpeg-devel,v2] avformat/libsrt: print streamid at client | expand

Commit Message

Raghavendra Rao Sidlagatta Oct. 1, 2020, 8:43 a.m. UTC
Print the SRT streamid at the client.
Logged to the context and changed info to verbose.

Signed-off-by: raghavendra <raghavendra.rao@collabora.com>
---
 libavformat/libsrt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Moritz Barsnick Oct. 1, 2020, 12:29 p.m. UTC | #1
On Thu, Oct 01, 2020 at 14:13:14 +0530, raghavendra wrote:
> Print the SRT streamid at the client.
> Logged to the context and changed info to verbose.

No, this is a patch on top of your original patch. That is not
acceptable. You need to change the original commit and resubmit that.

>      if(!libsrt_getsockopt(h, fd, SRTO_STREAMID, "SRTO_STREAMID", streamid, &optlen))
       ^ please fix style: "if ("

Cheers,
Moritz
diff mbox series

Patch

diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
index ee64cb82f7..b6b50302b7 100644
--- a/libavformat/libsrt.c
+++ b/libavformat/libsrt.c
@@ -364,7 +364,7 @@  static void libsrt_dump_streamid(URLContext *h, int fd)
     char streamid[512];
     int optlen = sizeof(streamid);
     if(!libsrt_getsockopt(h, fd, SRTO_STREAMID, "SRTO_STREAMID", streamid, &optlen))
-        av_log(NULL, AV_LOG_INFO, "srt_streamid : %s\n", streamid);
+        av_log(h, AV_LOG_VERBOSE, "srt_streamid : %s\n", streamid);
 }
 
 static int libsrt_setup(URLContext *h, const char *uri, int flags)