diff mbox series

[FFmpeg-devel] Preventing Buffer Overflow for RTSP Links Increasing the buffer size of control uri, used when storing the input argument RTSP link. Following the Web URI standards, lengths of RTSP links can extend beyond 1k characters.

Message ID 20201013081712.1969-1-git@yigituyan.com
State New
Headers show
Series [FFmpeg-devel] Preventing Buffer Overflow for RTSP Links Increasing the buffer size of control uri, used when storing the input argument RTSP link. Following the Web URI standards, lengths of RTSP links can extend beyond 1k characters.
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make warning Make failed

Commit Message

Yigit Uyan Oct. 13, 2020, 8:17 a.m. UTC
---
 libavformat/rtsp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yigit Uyan Oct. 21, 2020, 6:17 p.m. UTC | #1
Hi, I've just checked the state of this patch on Patchwork. There are 
three builds listed, two successful and one warning. I've checked the 
logs for the warning, none seems to be about the submitted patch. I've 
also thoroughly tested the code prior to submitting.

This is the first patch I'm submitting to ffmpeg. When would this patch 
be included in the official builds? Is there anything I need to do?

Also is there a nightly, or a dev version of ffmpeg including this patch 
that I can share with others to try it out?

Thanks,
diff mbox series

Patch

diff --git a/libavformat/rtsp.h b/libavformat/rtsp.h
index 54a9a30c16..2b37f5b49f 100644
--- a/libavformat/rtsp.h
+++ b/libavformat/rtsp.h
@@ -315,7 +315,7 @@  typedef struct RTSPState {
     /** some MS RTSP streams contain a URL in the SDP that we need to use
      * for all subsequent RTSP requests, rather than the input URI; in
      * other cases, this is a copy of AVFormatContext->filename. */
-    char control_uri[1024];
+    char control_uri[2048];
 
     /** The following are used for parsing raw mpegts in udp */
     //@{