From patchwork Thu Oct 15 14:00:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 22966 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 74FB844953F for ; Thu, 15 Oct 2020 17:01:08 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3BDA668B972; Thu, 15 Oct 2020 17:01:08 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A812B68921A for ; Thu, 15 Oct 2020 17:01:01 +0300 (EEST) Received: by mail-wm1-f53.google.com with SMTP id 13so3310379wmf.0 for ; Thu, 15 Oct 2020 07:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YKzS1tX+BFwGIeBbniHyFjiRcLqeopu0ky7pA25OCVM=; b=j70SUcASYcQyAuoej2f+aTmfXEaE48edVeQtztqOqNeF2qNEAGJmDOOfPcaKDDkJwr 4cHUn1w2Utc9UZgwkFoC0PrBSifb6yXlmnvi1tT/8N+gDdQHU55WkXcf4l6H+p+bAy13 HPEnMLLzkbtwojterx6xNx6WSWrOveTlIp72RRUtiv2voZfVDNCXXQNjwxJiMJTcbVEp BeQghdxIHuDUhtcq1pw7L2XeJoBnQCki38U/5ZBjEBujskEAuAQaLwiK9MYUDAO8BhVZ wxQicApF0Wdn24tybZRojiybqAWR8JRjotEKko3mO0n5KaLTJBiSqYJZmqLnhjKyfGqn Utdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YKzS1tX+BFwGIeBbniHyFjiRcLqeopu0ky7pA25OCVM=; b=N+bZfqclkWXl808XO8S9wWTO3N7pkHJwPwsgzlFLSCUXxFpHbRFONJJlu8/ntcG6dO TJNBXr7uffE4tLxY0tsR5EfNubDgyvp38SwhYX5FIw6jgs52SpJl2QJaOEeP62NfAECQ UVa2yPxM0ZufdoIRusGJkj7tWsN97103V4CFAtPd0UZg6GY+1LwRyaJJYlc77HaLIq8V dErbqqiz0JpU3zg7ZIYwh6fSMAMwTMxn/Y3a2IhkPcNgx/Db0fHRP0Aesz2vAaW3jjlt 5GG1eOUe88gpLaLsjoOXlgRJK6RCuTPalARvI+X74RiZQylCNIEj0VVIf4vDPae7nz10 Ri3w== X-Gm-Message-State: AOAM532U2X/XQqrm0Q2QI3QDHCFp2HVqH+DdupiEladZ+pcXKTbW+eBm palAPmXm6jVWyM/CN9HsKB64Ou1yghA= X-Google-Smtp-Source: ABdhPJxCAaTyDhB7hcDQLnBfpXTzLiEadDoWN3wDhrBRkMU+V+lRLhOEp/QSRNy5bJonpZiqSD0ZFg== X-Received: by 2002:a1c:65c1:: with SMTP id z184mr4040729wmb.61.1602770460514; Thu, 15 Oct 2020 07:01:00 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc1aa4b.dynamic.kabel-deutschland.de. [188.193.170.75]) by smtp.gmail.com with ESMTPSA id h16sm5208467wre.87.2020.10.15.07.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 07:00:59 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 15 Oct 2020 16:00:50 +0200 Message-Id: <20201015140052.100725-1-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/movtextenc: Fix potential use of unitialized value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Background colour was never initialized if no style was available. Use a sane default of zero (i.e. completely transparent). Signed-off-by: Andreas Rheinhardt --- libavcodec/movtextenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index b2368b641b..00ebca2e56 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -202,7 +202,7 @@ static int encode_sample_description(AVCodecContext *avctx) ASS * ass; ASSStyle * style; int i, j; - uint32_t tsmb_size, tsmb_type, back_color, style_color; + uint32_t tsmb_size, tsmb_type, back_color = 0, style_color; uint16_t style_start, style_end, fontID, count; int font_names_total_len = 0; MovTextContext *s = avctx->priv_data;