From patchwork Fri Oct 23 18:39:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 23178 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id D5675449AB7 for ; Fri, 23 Oct 2020 21:46:01 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B0E8268A107; Fri, 23 Oct 2020 21:46:01 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe02-3.mx.upcmail.net (vie01a-dmta-pe02-3.mx.upcmail.net [62.179.121.159]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CBDE8688036 for ; Fri, 23 Oct 2020 21:45:55 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe02.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1kW1zV-0006fs-0b for ffmpeg-devel@ffmpeg.org; Fri, 23 Oct 2020 20:40:41 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id W1yWkeLWUIr7GW1yWksCN9; Fri, 23 Oct 2020 20:39:40 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=QN4WuTDL c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=nZOtpAppAAAA:20 a=CUkpiSPqfUNRAq_3XFgA:9 a=1fhp2MxaeJtTNGEnv6mo:22 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=bWyr8ysk75zN3GCy5bjg:22 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Fri, 23 Oct 2020 20:39:33 +0200 Message-Id: <20201023183940.31485-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfP699hPVs3O/np8gNBGQ0H2P50+vwmQyHRTBPQJspE1AxI3H2yo7BPM9n5Ww/hoT9TfQlgHA40l0ldMrkrYarl8X5irq8+DA4rSO4YXlXAxiMAmMtPSp qbyKI7Sd1c2vXLxxRum8BaN4KMTVnzSohH/JLksdzCTnIrsoblAC0P9Z Subject: [FFmpeg-devel] [PATCH 1/8] avcodec/magicyuv: Check slice size before reading flags and pred X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes: heap-buffer-overflow Fixes: 26487/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MAGICYUV_fuzzer-5742553675333632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/magicyuv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/magicyuv.c b/libavcodec/magicyuv.c index ea1f727e5c..e2b7bdd326 100644 --- a/libavcodec/magicyuv.c +++ b/libavcodec/magicyuv.c @@ -267,6 +267,9 @@ static int magy_decode_slice(AVCodecContext *avctx, void *tdata, const uint8_t *slice = s->buf + s->slices[i][j].start; int flags, pred; + if (s->slices[i][j].size < 2) + return AVERROR_INVALIDDATA; + flags = bytestream_get_byte(&slice); pred = bytestream_get_byte(&slice);