From patchwork Fri Oct 30 11:01:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 23282 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id B6F2844AC19 for ; Fri, 30 Oct 2020 13:07:38 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B38E68A5A8; Fri, 30 Oct 2020 13:07:38 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 39FA168A5B5 for ; Fri, 30 Oct 2020 13:07:32 +0200 (EET) Received: by mail-wr1-f67.google.com with SMTP id x7so6007527wrl.3 for ; Fri, 30 Oct 2020 04:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=3Ef/8FZmTpzCiWENCAcEYiliqoNlrBDoVmfZOAqHqSg=; b=xqwFtRLGsmZw0g1AXn8p35jV/+yF+LbuzrsfcnkNsODYYGUvhqwV8vnYdaVyqQcjOI nKGyPFJNNgQW49CkizXKZW6oib4xU4alctG5kMNdD8uevA5B0HvoBAEdp24zNZccGa67 B1n4IABFLdk3kUG8rfQszD1bHzevR8vejjIH5wDRd3J4UaEGtZ2TnD7PBfCKzT/jF3IX PyCGAyiLFeyf+r9wWzFzmGv5Avlzc2IS9ZiiPmz3Qw5rc85wtu2ijvCDXDov9g0ahNSW II2wQliUSTdL6NKKtZ1pF1kEk0SIcOXv+5uZxK6Wrztoh1OKTzjP7HjZogaJFocyP65Q QxxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3Ef/8FZmTpzCiWENCAcEYiliqoNlrBDoVmfZOAqHqSg=; b=YLO3IZKQW69hoix6i0X3S6iXcxNsAaw+9prYUjDDPPnnFnuo6MG74QuoKSDluY9a5S bslQS1FF8qarZDXk1AIHbSGIJ19P86mLrDGdxnsFkyljv+A5nc9X8Wwl9pIdDfzdBXsq WmEBJBBV/3j2f2e9YqkStOyHC+MgKAt+Qbw7c9Hy30V9twIB2KyPXiXWbXpT7xuJs0q6 uwJA+3CtdLUchj3uqXL4oRI5rN6v09QI6dYh1ZTzLu8ql9T8KC0PYAfNwJ7R5SBV2Kcm HzgLN2mdA+MrH778Xpa8C2uWcL0MFeqHKeY5HypwCTxR8YWyvdMxXzYi7/jn7KHPL31h Rn0A== X-Gm-Message-State: AOAM533Si1QQv8yAdgXcWuhzIosswVF0d1UREcplDRnLdGBhqpGVJoVt kf1IApZBeoFx3t58Ed1rQ/t1duKCUD3t9tA3 X-Google-Smtp-Source: ABdhPJyJpmML6T3cE/ayOBBZ7WsYLgvjiAZHfIZrsCWcIHF+kqlRp2h/HdHxaidB096getgaSIG8wA== X-Received: by 2002:adf:f142:: with SMTP id y2mr2331741wro.160.1604055689600; Fri, 30 Oct 2020 04:01:29 -0700 (PDT) Received: from localhost (host-96-177.parnet.fi. [77.234.96.177]) by smtp.gmail.com with ESMTPSA id y201sm4540487wmd.27.2020.10.30.04.01.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 30 Oct 2020 04:01:29 -0700 (PDT) From: =?utf-8?q?Martin_Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Fri, 30 Oct 2020 13:01:22 +0200 Message-Id: <20201030110122.26502-3-martin@martin.st> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20201030110122.26502-1-martin@martin.st> References: <20201030110122.26502-1-martin@martin.st> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/3] aviobuf: Increase the default SHORT_SEEK_THRESHOLD to 32 KB X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The previous threshold, 4 KB, maybe was reasonable when it was set (in 2010), but in today's settings and with typical network speeds and data sizes, it's pretty small. 32 KB probably is a more reasonable default now, regardless of input. --- libavformat/aviobuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index a77517d712..e1acb3890c 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -40,7 +40,7 @@ * data instead of calling the protocol seek function, for seekable * protocols. */ -#define SHORT_SEEK_THRESHOLD 4096 +#define SHORT_SEEK_THRESHOLD 32768 static void *ff_avio_child_next(void *obj, void *prev) {