From patchwork Thu Nov 12 17:33:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 23599 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 403BF44979A for ; Thu, 12 Nov 2020 19:34:03 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 285F768C192; Thu, 12 Nov 2020 19:34:03 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 12DC968C191 for ; Thu, 12 Nov 2020 19:33:56 +0200 (EET) Received: by mail-wr1-f66.google.com with SMTP id p1so6854641wrf.12 for ; Thu, 12 Nov 2020 09:33:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3ForpxFMmY8zFo01A4VW9cxR/96fXr50pNQSKzlE3Ik=; b=auViNNSVuvV14kvJpsd1eHfbUxpItgSK6pmpWEMjB31OLn5tBpDWXc4xunD1wS+szu 2J2i7CQgzsvHwz34m+xOQVzrR/XZBwpypu+jsfBatx14R7swdMqX+/NEFigxd1Dl+q+w qwsQXxQ9YISjxolNUwCJD6o9T1fXUK8tdFEqElmeKekDH8vxh1VOnecZRMD7Fdk7AZJN jc02WOvyRC4RCdrd9lbDfz/U2rARiGkfWsILbM+d/Hq64zf0FCeLyPak9z6fn8pcdJEc lJXn+TgxI9UTj/jpfqzCQ6TDxH5aO4B7rLap9xzc6i6XOYbQkRI/A8iSxBNPQsanmCHI K+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3ForpxFMmY8zFo01A4VW9cxR/96fXr50pNQSKzlE3Ik=; b=I8eYIWymKa4jWPIS+ciwDMp9/UWfgaecV3ACpS0Smnq9Zzs1p+7Cw59/7uPY6YkMfg 4wkveBXoK7RtsRLaI6BfmYlUNa971XSqP/iZBDY14+SJPgT2oNuMgpjQFd1rhhXjWqV9 kVZJYI88EtzQNKZa4ZP440yjQFc4oX6KnOZ4tDl6eXOPsNJTo5dXDFjvCFhW/hkRE4pj S+5W4+nbTsz53lMZjA/Uz7OsTcEZc67zoiOr4QPdey+JP8M68OWiY9BNiNS4gO7JwJHf ePOIuDIBtx9GectCjy6hiCMdPr5hMv6Jry6//cKaGPZoTyucA+1tKskYT6rwmdkJP8w1 mnJg== X-Gm-Message-State: AOAM532d1bg5LH6Y1Uc0hzHA7/GqHEBPEczvy5HJpaxLitBT/zKkuwLV h5TnIWv9GOTdrICGPojKjMzoFr7BzpjezQ== X-Google-Smtp-Source: ABdhPJxom0l0bWKBbevmVyfr2nwA+GUSVUHG0si36wzEIK/x70i2O0/4YqnI0ZKUjeuafjjX0ncqoQ== X-Received: by 2002:adf:f7c7:: with SMTP id a7mr685862wrq.347.1605202435251; Thu, 12 Nov 2020 09:33:55 -0800 (PST) Received: from sblaptop.fritz.box (ipbcc1aa4b.dynamic.kabel-deutschland.de. [188.193.170.75]) by smtp.gmail.com with ESMTPSA id n15sm7814080wrq.48.2020.11.12.09.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 09:33:54 -0800 (PST) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 12 Nov 2020 18:33:27 +0100 Message-Id: <20201112173328.742491-3-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112173328.742491-1-andreas.rheinhardt@gmail.com> References: <20201112173328.742491-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/4] avformat/asfdec_o: Don't reset twice X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" A variable has been assigned a value twice consecutively; essentially the same happens when one performs av_init_packet on an AVPacket after a call to av_packet_unref. Found via PVS-Studio (see ticket #8156). Signed-off-by: Andreas Rheinhardt --- This and the next one are old commits that are recycled. libavformat/asfdec_o.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/asfdec_o.c b/libavformat/asfdec_o.c index 2dcbc16332..9fd38f1bfe 100644 --- a/libavformat/asfdec_o.c +++ b/libavformat/asfdec_o.c @@ -1135,9 +1135,7 @@ static void reset_packet(ASFPacket *asf_pkt) asf_pkt->duration = 0; asf_pkt->flags = 0; asf_pkt->dts = 0; - asf_pkt->duration = 0; av_packet_unref(&asf_pkt->avpkt); - av_init_packet(&asf_pkt->avpkt); } static int asf_read_replicated_data(AVFormatContext *s, ASFPacket *asf_pkt)