From patchwork Fri Nov 20 16:38:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Izen X-Patchwork-Id: 23919 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id BDAD644A607 for ; Fri, 20 Nov 2020 19:02:33 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 93C1568B922; Fri, 20 Nov 2020 19:02:33 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 660B968B698 for ; Fri, 20 Nov 2020 19:02:27 +0200 (EET) Received: by mail-qt1-f193.google.com with SMTP id m65so7544398qte.11 for ; Fri, 20 Nov 2020 09:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9mqsftvZWxzOErB7ctB7y4yldAJ/7uWRLC44UBA1i9o=; b=kBcXu0+hsYh9IuiyEQbQeT6b1BfWZj8A0RlBU5EtcZI7ZFdzK8pZQqqF9OuX35RNvB xdzEfe2tZJZLs4IYfkATeYcDnDduSCInvmZYgRItpvdosi0VChUoI0hLF6YcarYMkO7m dFwrYcY0yGX2c1FQlRNpaPUr0djE8nkzfWg/9J1AUJy95j51ufsCnBRfnhHDhFl44IBH BKugRLAp+XEYmQIfWfZwvHrofd2rnT4/1XcbzZjOHccTgW73eewXzppFAQcdk+Df0YXj 32fJIsuwxZCXErqTQcKfNebTssMOcYOcVqrZxI7W8wTjP6ET37HPkV2TgmXwrcDUrdVR 4Ebw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9mqsftvZWxzOErB7ctB7y4yldAJ/7uWRLC44UBA1i9o=; b=pKxIDZkoMNkxXzGKdOV4EaHDIdwmaUREQFwWPGJHn6jIZfAvmPGTmW2uaxOQvYILR6 NP2D6uPVL+kIoP2HJivmnebxtrKM99FFOY9MIzzf0l9E4w/fA0lbzNeqr+db/Xu8nkA5 s+44H0EZYAy2kaG1URmeV04u2HBHNCzGJqQGFHq8uEKIKobK56lOTfDW4wZ+qBiEsacq nqR71EpSZRoRYotAHRaF4s9w54u96O/Bnd5eUhbNrzEwQyXsTfV5M8jpgYkaGykLXCiC zUHt1KZbta5hm9iZGac5WDUMNaxbIpVed10iu2v6WAEZLaosYt+4WEbP7FchqzWADKLR vP+w== X-Gm-Message-State: AOAM530SYYBnsXLNaKC8dfQGEStgHtDMJCWJLuaIW8dNlii0kvSJZsQ8 CeaDIzPRoks/4RN862ZyRqg72CZDk5w= X-Google-Smtp-Source: ABdhPJyf8Vdb4k2xtG7LQsn6hp/VoMbcPmYNNwCRkCFIWUsGo6Bi46FxGb7JtAJCblSzMU+u67p4Cg== X-Received: by 2002:ae9:eb06:: with SMTP id b6mr17570924qkg.321.1605890321254; Fri, 20 Nov 2020 08:38:41 -0800 (PST) Received: from gauss.localdomain ([71.73.92.220]) by smtp.gmail.com with ESMTPSA id w192sm2362699qkb.17.2020.11.20.08.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 08:38:40 -0800 (PST) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Fri, 20 Nov 2020 11:38:31 -0500 Message-Id: <20201120163831.91560-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/movenc: allow Apple Lossless inside mp4 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" MP4 already supports Apple Lossless, and it can be put inside by using muxer=ipod, but it's not tagged as supported in mp4. The mp4ra lists alac as a valid fourcc inside mp4, so it should be supported by spec. See: https://mp4ra.org/#/codecs --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index fea8a86192..18fa3f9b5e 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -7128,6 +7128,7 @@ static const AVCodecTag codec_mp4_tags[] = { { AV_CODEC_ID_VP9, MKTAG('v', 'p', '0', '9') }, { AV_CODEC_ID_AV1, MKTAG('a', 'v', '0', '1') }, { AV_CODEC_ID_AAC, MKTAG('m', 'p', '4', 'a') }, + { AV_CODEC_ID_ALAC, MKTAG('a', 'l', 'a', 'c') }, { AV_CODEC_ID_MP4ALS, MKTAG('m', 'p', '4', 'a') }, { AV_CODEC_ID_MP3, MKTAG('m', 'p', '4', 'a') }, { AV_CODEC_ID_MP2, MKTAG('m', 'p', '4', 'a') },