diff mbox series

[FFmpeg-devel] libavformat/avidec.c: remove duplicated conversion

Message ID 20201123185458.3716975-1-tfoucu@gmail.com
State Withdrawn
Headers show
Series [FFmpeg-devel] libavformat/avidec.c: remove duplicated conversion
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Thierry Foucu Nov. 23, 2020, 6:54 p.m. UTC
ff_riff_info_conv deals with riff metadata already, so, not need to add
those metadata in avi_metadata_conv
---
 libavformat/avidec.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Michael Niedermayer Nov. 24, 2020, 11 p.m. UTC | #1
On Mon, Nov 23, 2020 at 10:54:58AM -0800, Thierry Foucu wrote:
> ff_riff_info_conv deals with riff metadata already, so, not need to add
> those metadata in avi_metadata_conv
> ---
>  libavformat/avidec.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/libavformat/avidec.c b/libavformat/avidec.c
> index 7e527e15ee..75a76b995d 100644
> --- a/libavformat/avidec.c
> +++ b/libavformat/avidec.c
> @@ -110,14 +110,6 @@ static const char avi_headers[][8] = {
>  
>  static const AVMetadataConv avi_metadata_conv[] = {
>      { "strn", "title" },

> -    { "isbj", "subject" },

where is isbj duplicated ?

also see:
"avformat/avidec: Remove redundant entries from avi_metadata_conv"

thx

[...]
diff mbox series

Patch

diff --git a/libavformat/avidec.c b/libavformat/avidec.c
index 7e527e15ee..75a76b995d 100644
--- a/libavformat/avidec.c
+++ b/libavformat/avidec.c
@@ -110,14 +110,6 @@  static const char avi_headers[][8] = {
 
 static const AVMetadataConv avi_metadata_conv[] = {
     { "strn", "title" },
-    { "isbj", "subject" },
-    { "inam", "title" },
-    { "iart", "artist" },
-    { "icop", "copyright" },
-    { "icmt", "comment" },
-    { "ignr", "genre" },
-    { "iprd", "product" },
-    { "isft", "software" },
 
     { 0 },
 };