diff mbox series

[FFmpeg-devel,1/2] avformat/rtspdec: show method request in log

Message ID 20201127001653.67116-1-andriy.gelman@gmail.com
State Accepted
Commit b0019b909be7a735b09f89207272294008ff2c0c
Headers show
Series [FFmpeg-devel,1/2] avformat/rtspdec: show method request in log | expand

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished

Commit Message

Andriy Gelman Nov. 27, 2020, 12:16 a.m. UTC 
From: Andriy Gelman <andriy.gelman@gmail.com>

Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
---
 libavformat/rtspdec.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Martin Storsjö Nov. 27, 2020, 7:26 a.m. UTC | #1 
On Thu, 26 Nov 2020, Andriy Gelman wrote:

> From: Andriy Gelman <andriy.gelman@gmail.com>
>
> Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
> ---
> libavformat/rtspdec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c
> index 28b35d1993..be11576913 100644
> --- a/libavformat/rtspdec.c
> +++ b/libavformat/rtspdec.c
> @@ -474,6 +474,7 @@ int ff_rtsp_parse_streaming_commands(AVFormatContext *s)
>     ret = read_line(s, rbuf, sizeof(rbuf), &rbuflen);
>     if (ret < 0)
>         return ret;
> +    av_log(s, AV_LOG_TRACE, "Parsing[%d]: %s\n", rbuflen, rbuf);
>     ret = parse_command_line(s, rbuf, rbuflen, uri, sizeof(uri), method,
>                              sizeof(method), &methodcode);
>     if (ret) {
> @@ -675,6 +676,7 @@ static int rtsp_listen(AVFormatContext *s)
>         ret = read_line(s, rbuf, sizeof(rbuf), &rbuflen);
>         if (ret < 0)
>             goto fail;
> +        av_log(s, AV_LOG_TRACE, "Parsing[%d]: %s\n", rbuflen, rbuf);
>         ret = parse_command_line(s, rbuf, rbuflen, uri, sizeof(uri), method,
>                                  sizeof(method), &methodcode);
>         if (ret) {
> -- 
> 2.28.0

LGTM, if the log level matches what's used for similar log messages 
elsewhere in the rtsp code.

// Martin
diff mbox series

Patch

diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c
index 28b35d1993..be11576913 100644
--- a/libavformat/rtspdec.c
+++ b/libavformat/rtspdec.c
@@ -474,6 +474,7 @@  int ff_rtsp_parse_streaming_commands(AVFormatContext *s)
     ret = read_line(s, rbuf, sizeof(rbuf), &rbuflen);
     if (ret < 0)
         return ret;
+    av_log(s, AV_LOG_TRACE, "Parsing[%d]: %s\n", rbuflen, rbuf);
     ret = parse_command_line(s, rbuf, rbuflen, uri, sizeof(uri), method,
                              sizeof(method), &methodcode);
     if (ret) {
@@ -675,6 +676,7 @@  static int rtsp_listen(AVFormatContext *s)
         ret = read_line(s, rbuf, sizeof(rbuf), &rbuflen);
         if (ret < 0)
             goto fail;
+        av_log(s, AV_LOG_TRACE, "Parsing[%d]: %s\n", rbuflen, rbuf);
         ret = parse_command_line(s, rbuf, rbuflen, uri, sizeof(uri), method,
                                  sizeof(method), &methodcode);
         if (ret) {