From patchwork Fri Dec 4 22:57:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 24350 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 0F814449E05 for ; Sat, 5 Dec 2020 00:58:13 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6FF168A606; Sat, 5 Dec 2020 00:58:12 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 219CA68A5AC for ; Sat, 5 Dec 2020 00:58:06 +0200 (EET) Received: by mail-ej1-f67.google.com with SMTP id qw4so10956520ejb.12 for ; Fri, 04 Dec 2020 14:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=Y9dqU1PH2WFrzFIwqfLelpk15MlVyJhrB+wNELwvTHw=; b=GtOOKssD0snjxwCLAXAgmCYevT3JwWby72vqiAcbZ+PabOwjseevkgI0qzXAkBdK3u GUfZN+aefCUX3uI4n2ZR2bPlqCGNuIGJJ8IcymOiEcjBSYTr6+pp0oyoqEdXCMGCt27Z IEsga90hvefdpwGudEt2C68CbDAO66cG0T9cDzJgElNAWYP5b8OElmCU6erkOEA24TZ9 cp7WgEql6fx9et87LkGnp4QW6xslb/HJaDSUnqoeSMSlxxZc2rkwhqayMxC96fc72Axy 7v4YO4ysKrArnQBKdQc0NRbvhNaQRV3CXEmN3YnZh1iMPHQ6CCFJnHtRFmVUwj9y6nHk Bwtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=Y9dqU1PH2WFrzFIwqfLelpk15MlVyJhrB+wNELwvTHw=; b=lHOoOc4Fpu5J89al5I2EBcq7bWjN+sdYH/yDXuD+7SN6iQ/qb9LhLr1VkHGm8yO5eo rWXlLGEm0WPlS3Fee8PH8ezOGLDMSxKvDEwQgu07qpNr7OAeG5n5b5bcxHwUotz0JU6x +debco8m7y/tgNyIToN5Fvp4EGgdVKaxjuqmNUqAqMla8rfLWjt3zGDd8ORsdrLQBfF0 dNFOJKVX8YPZMxeFZ91t30ZI6NhyXXxtHh0QuzCOwDpsj/ad/TiZfy1393WAqzh4O1++ ShD6TNGTGMo2y+AD9xHqwoPbkHzsMPsPTdRf9WK7FhhB0aA8SyG0BdAtoLrvk0az4eEL edzA== X-Gm-Message-State: AOAM532XSkaWaUdij3+P3QQGcYgYWnxgK9FuxhqnDk1HqL7985AL/1xh d00I50x0aV+YvbKTiaJE2FWnJbCLZKUQIg== X-Google-Smtp-Source: ABdhPJy4UOSckGActbzD5UpBxTgMqKXuzd5IudVS70++YsBqxSMkfPCxeEBWpy65ezdLyUgtt1HQLw== X-Received: by 2002:a17:906:1a19:: with SMTP id i25mr9172346ejf.206.1607122685425; Fri, 04 Dec 2020 14:58:05 -0800 (PST) Received: from sblaptop.fritz.box (ipbcc1aa4b.dynamic.kabel-deutschland.de. [188.193.170.75]) by smtp.gmail.com with ESMTPSA id s6sm3941116ejb.122.2020.12.04.14.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 14:58:04 -0800 (PST) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 4 Dec 2020 23:57:40 +0100 Message-Id: <20201204225740.1506052-3-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201204225740.1506052-1-andreas.rheinhardt@gmail.com> References: <20201204225740.1506052-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/3] tests/fate-run.sh: Don't overlook errors from md5 tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The md5 test up until now ignored errors from ffmpeg (the cli) and just md5'ed whatever ffmpeg has output; while testing scenarios in which ffmpeg fails has its merits, errors should not be overlooked by default; doing so also reduces the effectiveness of sanitizers as errors from them are ignored. This has happened with a memleak in the AV1 decoder. Signed-off-by: Andreas Rheinhardt --- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 58d5fdbb60..b69176f7c3 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -158,7 +158,7 @@ md5pipe(){ md5(){ encfile="${outdir}/${test}.out" cleanfiles="$cleanfiles $encfile" - ffmpeg -y "$@" $(target_path $encfile) + ffmpeg -y "$@" $(target_path $encfile) || return do_md5sum $encfile | awk '{print $1}' }