[FFmpeg-devel,1/6] fate: Add dpx-probe test

Signed-off-by: Harry Mallon <harry.mallon@codex.online>
---
 tests/fate/image.mak     |  4 ++
 tests/ref/fate/dpx-probe | 85 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+)
 create mode 100644 tests/ref/fate/dpx-probe

I attach the cyan.dpx that I generated for this test, it needs to be in the dpx folder in fate.

Best,
Harry
> On 7 Dec 2020, at 10:32, Harry Mallon <harry.mallon@codex.online> wrote:
> 
> Signed-off-by: Harry Mallon <harry.mallon@codex.online>
> ---
> [...]
> -- 
> 2.29.2
>

Will upload a dpx sample and apply patches after 48h.

On Mon, Dec 7, 2020 at 12:39 PM Harry Mallon <harry.mallon@codex.online>
wrote:

> I attach the cyan.dpx that I generated for this test, it needs to be in
> the dpx folder in fate.
>
> Best,
> Harry
>
>
>
>
> > On 7 Dec 2020, at 10:32, Harry Mallon <harry.mallon@codex.online> wrote:
> >
> > Signed-off-by: Harry Mallon <harry.mallon@codex.online>
> > ---
> > [...]
> > --
> > 2.29.2
> >
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Hi,

On Mon, 07. Dec 10:32, Harry Mallon wrote:
> Signed-off-by: Harry Mallon <harry.mallon@codex.online>
> ---
>  tests/fate/image.mak     |  4 ++
>  tests/ref/fate/dpx-probe | 85 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 89 insertions(+)
>  create mode 100644 tests/ref/fate/dpx-probe
> 
> diff --git a/tests/fate/image.mak b/tests/fate/image.mak
> index 22072a62f1..d18054d3d8 100644
> --- a/tests/fate/image.mak
> +++ b/tests/fate/image.mak
> @@ -97,6 +97,10 @@ fate-dpx: CMD = framecrc -i $(TARGET_SAMPLES)/dpx/lighthouse_rgb48.dpx
>  FATE_SAMPLES_AVCONV-$(call PARSERDEMDEC, DPX, IMAGE2PIPE, DPX) += fate-dpxparser
>  fate-dpxparser: CMD = framecrc -f image2pipe -i $(TARGET_SAMPLES)/dpx/lena_4x_concat.dpx -sws_flags +accurate_rnd+bitexact
>  
> +FATE_IMAGE-$(call DEMDEC, IMAGE2, DPX) += fate-dpx-probe
> +fate-dpx-probe: SRC = $(TARGET_SAMPLES)/dpx/cyan.dpx
> +fate-dpx-probe: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_streams -show_frames -print_format default -bitexact -v 0 -i "$(SRC)"
> +
>  FATE_EXR += fate-exr-slice-raw
>  fate-exr-slice-raw: CMD = framecrc -i $(TARGET_SAMPLES)/exr/rgba_slice_raw.exr -pix_fmt gbrapf32le
>  
> diff --git a/tests/ref/fate/dpx-probe b/tests/ref/fate/dpx-probe
> new file mode 100644
> index 0000000000..a69c45ad29
> --- /dev/null
> +++ b/tests/ref/fate/dpx-probe
> @@ -0,0 +1,85 @@
> +[FRAME]
> +media_type=video
> +stream_index=0
> +key_frame=1
> +pkt_pts=0
> +pkt_pts_time=0.000000
> +pkt_dts=0
> +pkt_dts_time=0.000000
> +best_effort_timestamp=0
> +best_effort_timestamp_time=0.000000
> +pkt_duration=1
> +pkt_duration_time=0.040000
> +pkt_pos=0
> +pkt_size=419072
> +width=428
> +height=240
> +pix_fmt=gbrp10le
> +sample_aspect_ratio=1:1
> +pict_type=?
> +coded_picture_number=0
> +display_picture_number=0
> +interlaced_frame=0
> +top_field_first=0
> +repeat_pict=0
> +color_range=unknown
> +color_space=unknown
> +color_primaries=unknown
> +color_transfer=unknown
> +chroma_location=unspecified
> +TAG:Creator=Apple Compressor
> +TAG:Input Device=
> +[/FRAME]
> +[STREAM]
> +index=0
> +codec_name=dpx
> +profile=unknown
> +codec_type=video
> +codec_time_base=1/24
> +codec_tag_string=[0][0][0][0]
> +codec_tag=0x0000
> +width=428
> +height=240
> +coded_width=428
> +coded_height=240
> +closed_captions=0
> +has_b_frames=0
> +sample_aspect_ratio=1:1
> +display_aspect_ratio=107:60
> +pix_fmt=gbrp10le
> +level=-99
> +color_range=unknown
> +color_space=unknown
> +color_transfer=unknown
> +color_primaries=unknown
> +chroma_location=unspecified
> +field_order=unknown
> +timecode=N/A
> +refs=1
> +id=N/A
> +r_frame_rate=24/1
> +avg_frame_rate=0/0
> +time_base=1/25
> +start_pts=N/A
> +start_time=N/A
> +duration_ts=N/A
> +duration=N/A
> +bit_rate=N/A
> +max_bit_rate=N/A
> +bits_per_raw_sample=10
> +nb_frames=N/A
> +nb_read_frames=1
> +nb_read_packets=N/A
> +DISPOSITION:default=0
> +DISPOSITION:dub=0
> +DISPOSITION:original=0
> +DISPOSITION:comment=0
> +DISPOSITION:lyrics=0
> +DISPOSITION:karaoke=0
> +DISPOSITION:forced=0
> +DISPOSITION:hearing_impaired=0
> +DISPOSITION:visual_impaired=0
> +DISPOSITION:clean_effects=0
> +DISPOSITION:attached_pic=0
> +DISPOSITION:timed_thumbnails=0
> +[/STREAM]

This fails on big-endian PPC64 qemu:
https://patchwork.ffmpeg.org/check/22076/

TEST    dpx-probe
--- ./tests/ref/fate/dpx-probe	2020-12-08 16:37:42.631082285 +0000
+++ tests/data/fate/dpx-probe	2020-12-08 16:54:05.673088160 +0000
@@ -14,7 +14,7 @@
 pkt_size=419072
 width=428
 height=240
-pix_fmt=gbrp10le
+pix_fmt=gbrp10be
 sample_aspect_ratio=1:1
 pict_type=?
 coded_picture_number=0
@@ -46,7 +46,7 @@
 has_b_frames=0
 sample_aspect_ratio=1:1
 display_aspect_ratio=107:60
-pix_fmt=gbrp10le
+pix_fmt=gbrp10be
 level=-99
 color_range=unknown
 color_space=unknown
Test dpx-probe failed. Look at tests/data/fate/dpx-probe.err for details.
tests/Makefile:255: recipe for target 'fate-dpx-probe' failed
make: *** [fate-dpx-probe] Error 1

--
Andriy

big endian is dead.

On Tue, Dec 8, 2020 at 6:18 PM Andriy Gelman <andriy.gelman@gmail.com>
wrote:

> Hi,
>
> On Mon, 07. Dec 10:32, Harry Mallon wrote:
> > Signed-off-by: Harry Mallon <harry.mallon@codex.online>
> > ---
> >  tests/fate/image.mak     |  4 ++
> >  tests/ref/fate/dpx-probe | 85 ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 89 insertions(+)
> >  create mode 100644 tests/ref/fate/dpx-probe
> >
> > diff --git a/tests/fate/image.mak b/tests/fate/image.mak
> > index 22072a62f1..d18054d3d8 100644
> > --- a/tests/fate/image.mak
> > +++ b/tests/fate/image.mak
> > @@ -97,6 +97,10 @@ fate-dpx: CMD = framecrc -i
> $(TARGET_SAMPLES)/dpx/lighthouse_rgb48.dpx
> >  FATE_SAMPLES_AVCONV-$(call PARSERDEMDEC, DPX, IMAGE2PIPE, DPX) +=
> fate-dpxparser
> >  fate-dpxparser: CMD = framecrc -f image2pipe -i
> $(TARGET_SAMPLES)/dpx/lena_4x_concat.dpx -sws_flags +accurate_rnd+bitexact
> >
> > +FATE_IMAGE-$(call DEMDEC, IMAGE2, DPX) += fate-dpx-probe
> > +fate-dpx-probe: SRC = $(TARGET_SAMPLES)/dpx/cyan.dpx
> > +fate-dpx-probe: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_streams
> -show_frames -print_format default -bitexact -v 0 -i "$(SRC)"
> > +
> >  FATE_EXR += fate-exr-slice-raw
> >  fate-exr-slice-raw: CMD = framecrc -i
> $(TARGET_SAMPLES)/exr/rgba_slice_raw.exr -pix_fmt gbrapf32le
> >
> > diff --git a/tests/ref/fate/dpx-probe b/tests/ref/fate/dpx-probe
> > new file mode 100644
> > index 0000000000..a69c45ad29
> > --- /dev/null
> > +++ b/tests/ref/fate/dpx-probe
> > @@ -0,0 +1,85 @@
> > +[FRAME]
> > +media_type=video
> > +stream_index=0
> > +key_frame=1
> > +pkt_pts=0
> > +pkt_pts_time=0.000000
> > +pkt_dts=0
> > +pkt_dts_time=0.000000
> > +best_effort_timestamp=0
> > +best_effort_timestamp_time=0.000000
> > +pkt_duration=1
> > +pkt_duration_time=0.040000
> > +pkt_pos=0
> > +pkt_size=419072
> > +width=428
> > +height=240
> > +pix_fmt=gbrp10le
> > +sample_aspect_ratio=1:1
> > +pict_type=?
> > +coded_picture_number=0
> > +display_picture_number=0
> > +interlaced_frame=0
> > +top_field_first=0
> > +repeat_pict=0
> > +color_range=unknown
> > +color_space=unknown
> > +color_primaries=unknown
> > +color_transfer=unknown
> > +chroma_location=unspecified
> > +TAG:Creator=Apple Compressor
> > +TAG:Input Device=
> > +[/FRAME]
> > +[STREAM]
> > +index=0
> > +codec_name=dpx
> > +profile=unknown
> > +codec_type=video
> > +codec_time_base=1/24
> > +codec_tag_string=[0][0][0][0]
> > +codec_tag=0x0000
> > +width=428
> > +height=240
> > +coded_width=428
> > +coded_height=240
> > +closed_captions=0
> > +has_b_frames=0
> > +sample_aspect_ratio=1:1
> > +display_aspect_ratio=107:60
> > +pix_fmt=gbrp10le
> > +level=-99
> > +color_range=unknown
> > +color_space=unknown
> > +color_transfer=unknown
> > +color_primaries=unknown
> > +chroma_location=unspecified
> > +field_order=unknown
> > +timecode=N/A
> > +refs=1
> > +id=N/A
> > +r_frame_rate=24/1
> > +avg_frame_rate=0/0
> > +time_base=1/25
> > +start_pts=N/A
> > +start_time=N/A
> > +duration_ts=N/A
> > +duration=N/A
> > +bit_rate=N/A
> > +max_bit_rate=N/A
> > +bits_per_raw_sample=10
> > +nb_frames=N/A
> > +nb_read_frames=1
> > +nb_read_packets=N/A
> > +DISPOSITION:default=0
> > +DISPOSITION:dub=0
> > +DISPOSITION:original=0
> > +DISPOSITION:comment=0
> > +DISPOSITION:lyrics=0
> > +DISPOSITION:karaoke=0
> > +DISPOSITION:forced=0
> > +DISPOSITION:hearing_impaired=0
> > +DISPOSITION:visual_impaired=0
> > +DISPOSITION:clean_effects=0
> > +DISPOSITION:attached_pic=0
> > +DISPOSITION:timed_thumbnails=0
> > +[/STREAM]
>
> This fails on big-endian PPC64 qemu:
> https://patchwork.ffmpeg.org/check/22076/
>
> TEST    dpx-probe
> --- ./tests/ref/fate/dpx-probe  2020-12-08 16:37:42.631082285 +0000
> +++ tests/data/fate/dpx-probe   2020-12-08 16:54:05.673088160 +0000
> @@ -14,7 +14,7 @@
>  pkt_size=419072
>  width=428
>  height=240
> -pix_fmt=gbrp10le
> +pix_fmt=gbrp10be
>  sample_aspect_ratio=1:1
>  pict_type=?
>  coded_picture_number=0
> @@ -46,7 +46,7 @@
>  has_b_frames=0
>  sample_aspect_ratio=1:1
>  display_aspect_ratio=107:60
> -pix_fmt=gbrp10le
> +pix_fmt=gbrp10be
>  level=-99
>  color_range=unknown
>  color_space=unknown
> Test dpx-probe failed. Look at tests/data/fate/dpx-probe.err for details.
> tests/Makefile:255: recipe for target 'fate-dpx-probe' failed
> make: *** [fate-dpx-probe] Error 1
>
> --
> Andriy
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Am Mo., 7. Dez. 2020 um 12:39 Uhr schrieb Harry Mallon
<harry.mallon@codex.online>:
>
> I attach the cyan.dpx that I generated for this test, it needs to be in the dpx folder in fate.

The file is >400k, I believe a very small file should also allow to
test ffprobe with dpx.

Carl Eugen

File is fine, gonna apply this with ffprobe improved test.

Hi Paul etc,

I attach a smaller file (it will need the width height etc changing in the test which I will send as a V2 in a couple of mins).

Harry
> On 10 Dec 2020, at 11:51, Paul B Mahol <onemda@gmail.com> wrote:
> 
> File is fine, gonna apply this with ffprobe improved test.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

I already uploaded the other file to servers.

And I doubt it hurts at all in 2020.
Also I doubt one can overwrite files that easily.

On Thu, Dec 10, 2020 at 1:17 PM Harry Mallon <harry.mallon@codex.online>
wrote:

> Hi Paul etc,
>
> I attach a smaller file (it will need the width height etc changing in the
> test which I will send as a V2 in a couple of mins).
>
> Harry
>
>
>
>
> > On 10 Dec 2020, at 11:51, Paul B Mahol <onemda@gmail.com> wrote:
> >
> > File is fine, gonna apply this with ffprobe improved test.
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

> On 10 Dec 2020, at 12:21, Paul B Mahol <onemda@gmail.com> wrote:
> 
> I already uploaded the other file to servers.

Ah, sorry about that.

> 
> And I doubt it hurts at all in 2020.
> Also I doubt one can overwrite files that easily.

I have sent the V2. It is all exactly the same except it is set up for the smaller test file and I have fixed the big endian thing. Should I send a V3 which adjusts it back to the larger file again?

Harry

Nope. You do not need to send new patches.

On Thu, Dec 10, 2020 at 1:30 PM Harry Mallon <harry.mallon@codex.online>
wrote:

>
>
> > On 10 Dec 2020, at 12:21, Paul B Mahol <onemda@gmail.com> wrote:
> >
> > I already uploaded the other file to servers.
>
> Ah, sorry about that.
>
> >
> > And I doubt it hurts at all in 2020.
> > Also I doubt one can overwrite files that easily.
>
> I have sent the V2. It is all exactly the same except it is set up for the
> smaller test file and I have fixed the big endian thing. Should I send a V3
> which adjusts it back to the larger file again?
>
> Harry
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Am Do., 10. Dez. 2020 um 13:22 Uhr schrieb Paul B Mahol <onemda@gmail.com>:
>
> I already uploaded the other file to servers.

We can still remove it.

Downloading the fate suite takes very long and it will get bigger no
matter the year.

Carl Eugen

I strongly disagree, make use of money project got.
Limiting size of samples is not gonna to be productive at all.

On Fri, Dec 11, 2020 at 12:37 AM Carl Eugen Hoyos <ceffmpeg@gmail.com>
wrote:

> Am Do., 10. Dez. 2020 um 13:22 Uhr schrieb Paul B Mahol <onemda@gmail.com
> >:
> >
> > I already uploaded the other file to servers.
>
> We can still remove it.
>
> Downloading the fate suite takes very long and it will get bigger no
> matter the year.
>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

> On 10 Dec 2020, at 23:41, Paul B Mahol <onemda@gmail.com> wrote:
> 
> I strongly disagree, make use of money project got.
> Limiting size of samples is not gonna to be productive at all.
> 
> On Fri, Dec 11, 2020 at 12:37 AM Carl Eugen Hoyos <ceffmpeg@gmail.com>
> wrote:
> 
>> Am Do., 10. Dez. 2020 um 13:22 Uhr schrieb Paul B Mahol <onemda@gmail.com
>>> :
>>> 
>>> I already uploaded the other file to servers.
>> 
>> We can still remove it.
>> 
>> Downloading the fate suite takes very long and it will get bigger no
>> matter the year.

Is there anything I can do to unblock this? I am very happy for the second smaller size/resolution sample to be used instead.

Harry

On Mon, Dec 14, 2020 at 11:58 AM Harry Mallon <harry.mallon@codex.online>
wrote:

>
>
> > On 10 Dec 2020, at 23:41, Paul B Mahol <onemda@gmail.com> wrote:
> >
> > I strongly disagree, make use of money project got.
> > Limiting size of samples is not gonna to be productive at all.
> >
> > On Fri, Dec 11, 2020 at 12:37 AM Carl Eugen Hoyos <ceffmpeg@gmail.com>
> > wrote:
> >
> >> Am Do., 10. Dez. 2020 um 13:22 Uhr schrieb Paul B Mahol <
> onemda@gmail.com
> >>> :
> >>>
> >>> I already uploaded the other file to servers.
> >>
> >> We can still remove it.
> >>
> >> Downloading the fate suite takes very long and it will get bigger no
> >> matter the year.
>
> Is there anything I can do to unblock this? I am very happy for the second
> smaller size/resolution sample to be used instead.
>
>
gonna apply this soon.


> Harry
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".