diff mbox series

[FFmpeg-devel,24/39] avcodec/ituh263dec: Don't initialize unused parts of RLTable

Message ID 20201210111657.2276739-25-andreas.rheinhardt@gmail.com
State Accepted
Commit 1ea13f949a55ab3cb08144bccd06af1e40fef3d3
Headers show
Series Make mpegvideo encoders init-threadsafe
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Dec. 10, 2020, 11:16 a.m. UTC
The RLTable ff_rl_intra_aic is only used by ituh263dec and ituh263enc;
the former only uses the RLTable's VLC, the latter only index_run,
max_level and max_run. Yet ituh263dec also initializes the latter.
This commit stops doing so.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavcodec/ituh263dec.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Anton Khirnov Jan. 18, 2021, 12:03 p.m. UTC | #1
Quoting Andreas Rheinhardt (2020-12-10 12:16:42)
> The RLTable ff_rl_intra_aic is only used by ituh263dec and ituh263enc;
> the former only uses the RLTable's VLC, the latter only index_run,
> max_level and max_run. Yet ituh263dec also initializes the latter.
> This commit stops doing so.

Same as for h261 - should the be unshared then?
diff mbox series

Patch

diff --git a/libavcodec/ituh263dec.c b/libavcodec/ituh263dec.c
index eec86c81b1..0d1138512c 100644
--- a/libavcodec/ituh263dec.c
+++ b/libavcodec/ituh263dec.c
@@ -122,7 +122,6 @@  av_cold void ff_h263_decode_init_vlc(void)
                  &ff_mvtab[0][1], 2, 1,
                  &ff_mvtab[0][0], 2, 1, 538);
         ff_rl_init(&ff_h263_rl_inter, ff_h263_static_rl_table_store[0]);
-        ff_rl_init(&ff_rl_intra_aic, ff_h263_static_rl_table_store[1]);
         INIT_VLC_RL(ff_h263_rl_inter, 554);
         INIT_FIRST_VLC_RL(ff_rl_intra_aic, 554);
         INIT_VLC_STATIC(&h263_mbtype_b_vlc, H263_MBTYPE_B_VLC_BITS, 15,