From patchwork Fri Jan 1 21:35:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Thompson X-Patchwork-Id: 24755 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 673D244B645 for ; Fri, 1 Jan 2021 23:45:23 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4E6ED68AA13; Fri, 1 Jan 2021 23:45:23 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B93C06880B2 for ; Fri, 1 Jan 2021 23:45:16 +0200 (EET) Received: by mail-lf1-f41.google.com with SMTP id s26so50655786lfc.8 for ; Fri, 01 Jan 2021 13:45:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=aR9uOOoh3oK/aQLNaF4a7C2DYm1gIiIvrFWx3+McuuQ=; b=OSUtaL1fBPYAK+Zf1dK+KUIdAjiPrCK8U8aCb+HLYPeaiGcLWyqtGeh589MZla/+gc 415yp0P//wK/D1bv9o39FCQjzexy/QQhsItwaE3zI8Nt3Eo41vRRa4MHUhaZdbrbs5W2 7xv9TIdYoNLQ+a7UrrPcvdveOeMf8yzTRDzdhy2tUUtU8UqL4qhzBaZHwXvrN7jesdTY 8iiNl5MCympjjI+BENFHW/1YKKBgPiN0T4yrf1vINLHQ6dfg43nkpLxEHMWeEnx6tcIA F6Vzwycaqjz+M4wx/h6roHqxkFAfRXn+CoBTWNl6EWxVMPmtOXCrBHVrBV4cqQYxmo1h bQXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aR9uOOoh3oK/aQLNaF4a7C2DYm1gIiIvrFWx3+McuuQ=; b=KLtwmeD2j2FN8jWdpsNc0eMqa6xlKP5NaIRnecUjsgmOleGNDiZP9DjECaLI/iQHCC 72OU6HUDvD5uMfRAXMHGfS6kjawS3s1gCclgmewi8a6OIy/Us7iqXAjP77O1hyhStUNN RTbisAv8ggLErGql31vOyZ9dY3Or2TCdiuKsmkZ2hwInGudWZOzhEY0R13Y/jjqoZ1LU ObI2G8a5m8cuVT3acNCqjNC7MLf8T9hJpRX61Yp6GcBg9v5lo7/Jf81yb/aoKmDh7vWr Cqnhh/8tKyU4i5lkWAOv9hU6VFFg0MFpFVN5pf/Dzj4vjtq19xfDxAVc424eBffV1nUL ef3A== X-Gm-Message-State: AOAM532aES94wJunWXZTdI1GEMCOd3rxJVGMVshsjt9V/FML49JXw48V FV8nAv2lOX4GwVXhsxpeC0/hVH4R847K6Q== X-Google-Smtp-Source: ABdhPJx3q5zxHJg2HKC/HYAdPqk3BLNpI+56vJ7puyjV8m/UhrL6hF6UTunzafCoEXFk+p+wka0efg== X-Received: by 2002:a5d:6a83:: with SMTP id s3mr71659909wru.334.1609537075762; Fri, 01 Jan 2021 13:37:55 -0800 (PST) Received: from localhost.localdomain (cpc91226-cmbg18-2-0-cust7.5-4.cable.virginm.net. [82.0.29.8]) by smtp.gmail.com with ESMTPSA id v20sm18784595wml.34.2021.01.01.13.37.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Jan 2021 13:37:54 -0800 (PST) From: Mark Thompson To: ffmpeg-devel@ffmpeg.org Date: Fri, 1 Jan 2021 21:35:16 +0000 Message-Id: <20210101213537.169546-7-sw@jkqxz.net> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210101213537.169546-1-sw@jkqxz.net> References: <20210101213537.169546-1-sw@jkqxz.net> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 06/27] h264_metadata_bsf: Improve interpretation of input display matrices X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The previous code here only worked in more limited cases. --- libavcodec/h264_metadata_bsf.c | 44 +++++++++++++++++++++++----------- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 36f8aab245..71b49696cd 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/libavcodec/h264_metadata_bsf.c @@ -431,23 +431,39 @@ static int h264_metadata_handle_display_orientation(AVBSFContext *bsf, data = av_packet_get_side_data(pkt, AV_PKT_DATA_DISPLAYMATRIX, &size); if (data && size >= 9 * sizeof(int32_t)) { int32_t matrix[9]; - int hflip, vflip; - double angle; + double dmatrix[9]; + int hflip, vflip, i; + double scale_x, scale_y, angle; memcpy(matrix, data, sizeof(matrix)); - hflip = vflip = 0; - if (matrix[0] < 0 && matrix[4] > 0) - hflip = 1; - else if (matrix[0] > 0 && matrix[4] < 0) - vflip = 1; - av_display_matrix_flip(matrix, hflip, vflip); + for (i = 0; i < 9; i++) + dmatrix[i] = matrix[i] / 65536.0; + + // Extract scale factors. + scale_x = hypot(dmatrix[0], dmatrix[3]); + scale_y = hypot(dmatrix[1], dmatrix[4]); + + // Select flips to make the main diagonal positive. + hflip = dmatrix[0] < 0.0; + vflip = dmatrix[4] < 0.0; + if (hflip) + scale_x = -scale_x; + if (vflip) + scale_y = -scale_y; + + // Rescale. + for (i = 0; i < 9; i += 3) { + dmatrix[i] /= scale_x; + dmatrix[i + 1] /= scale_y; + } - angle = av_display_rotation_get(matrix); + // Extract rotation. + angle = atan2(dmatrix[3], dmatrix[0]); - if (!(angle >= -180.0 && angle <= 180.0 /* also excludes NaN */) || - matrix[2] != 0 || matrix[5] != 0 || - matrix[6] != 0 || matrix[7] != 0) { + if (!(angle >= -M_PI && angle <= M_PI) || + matrix[2] != 0.0 || matrix[5] != 0.0 || + matrix[6] != 0.0 || matrix[7] != 0.0) { av_log(bsf, AV_LOG_WARNING, "Input display matrix is not " "representable in H.264 parameters.\n"); } else { @@ -455,8 +471,8 @@ static int h264_metadata_handle_display_orientation(AVBSFContext *bsf, disp->ver_flip = vflip; disp->anticlockwise_rotation = (uint16_t)rint((angle >= 0.0 ? angle - : angle + 360.0) * - 65536.0 / 360.0); + : angle + 2 * M_PI) * + 32768.0 / M_PI); write = 1; } }