From patchwork Mon Jan 4 18:11:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AlexisWilke X-Patchwork-Id: 24788 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 983E944B37C for ; Mon, 4 Jan 2021 20:12:24 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8115668A953; Mon, 4 Jan 2021 20:12:24 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from m2osw.com (m2osw.com [138.197.205.139]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2E09668A928 for ; Mon, 4 Jan 2021 20:12:18 +0200 (EET) Received: from monster.m2osw.com (96-67-192-225-static.hfc.comcastbusiness.net [96.67.192.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by m2osw.com (Postfix) with ESMTPS id 64A8A3E8FF; Mon, 4 Jan 2021 18:12:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.1 m2osw.com 64A8A3E8FF Authentication-Results: mail.m2osw.com; dmarc=fail header.from=m2osw.com Received: by monster.m2osw.com (Postfix, from userid 1000) id 167BD43C00A1; Mon, 4 Jan 2021 10:12:16 -0800 (PST) From: AlexisWilke To: ffmpeg-devel@ffmpeg.org Date: Mon, 4 Jan 2021 10:11:01 -0800 Message-Id: <20210104181101.62248-2-alexis@m2osw.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210104181101.62248-1-alexis@m2osw.com> References: <20210104181101.62248-1-alexis@m2osw.com> Subject: [FFmpeg-devel] [PATCH 1/1] bug: test pointer to be used. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: AlexisWilke MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Two tests check the opposite pointer before using it. If only one of these is set to a valid pointer, one of these functions will crash, the other will ignore the pointer. --- libavformat/allformats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 0e0caaad39..6990af55f4 100644 --- a/libavformat/allformats.c +++ b/libavformat/allformats.c @@ -541,7 +541,7 @@ const AVOutputFormat *av_muxer_iterate(void **opaque) if (i < size) { f = muxer_list[i]; - } else if (indev_list) { + } else if (outdev_list) { f = outdev_list[i - size]; } @@ -558,7 +558,7 @@ const AVInputFormat *av_demuxer_iterate(void **opaque) if (i < size) { f = demuxer_list[i]; - } else if (outdev_list) { + } else if (indev_list) { f = indev_list[i - size]; }