| Message ID | 20210114020447.1927-1-jamrial@gmail.com |
|---|---|
| State | Accepted |
| Commit | f6477ac9f4daf3de2604d1cc5b27e66952d610b1 |
| Headers | show |
| Series | [FFmpeg-devel] avutil/tx: use ENOSYS instead of ENOTSUP | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | success | Make fate finished |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | success | Make fate finished |
Jan 14, 2021, 03:04 by jamrial@gmail.com: > It's the standard error code used across the codebase to signal unimplemented > or unsupported features. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > libavutil/tx_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c > index a91b8f900c..155e879f8e 100644 > --- a/libavutil/tx_template.c > +++ b/libavutil/tx_template.c > @@ -684,7 +684,7 @@ int TX_NAME(ff_tx_init_mdct_fft)(AVTXContext *s, av_tx_fn *tx, > * direct 3, 5 and 15 transforms as they're too niche. */ > if (len > 1 || m == 1) { > if (is_mdct && (l & 1)) /* Odd (i)MDCTs are not supported yet */ > - return AVERROR(ENOTSUP); > + return AVERROR(ENOSYS); > LGTM, thanks. I'll make a note to use this instead.
diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c index a91b8f900c..155e879f8e 100644 --- a/libavutil/tx_template.c +++ b/libavutil/tx_template.c @@ -684,7 +684,7 @@ int TX_NAME(ff_tx_init_mdct_fft)(AVTXContext *s, av_tx_fn *tx, * direct 3, 5 and 15 transforms as they're too niche. */ if (len > 1 || m == 1) { if (is_mdct && (l & 1)) /* Odd (i)MDCTs are not supported yet */ - return AVERROR(ENOTSUP); + return AVERROR(ENOSYS); s->n = l; s->m = 1; *tx = naive_fft;
It's the standard error code used across the codebase to signal unimplemented or unsupported features. Signed-off-by: James Almer <jamrial@gmail.com> --- libavutil/tx_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)