diff mbox series

[FFmpeg-devel] avcodec/h264_metadata_bsf: Don't use unitialized value

Message ID 20210122114315.253900-1-andreas.rheinhardt@gmail.com
State Accepted
Commit ee1d1c4b377052635920a71f8fb2efd77ea3b38c
Headers show
Series [FFmpeg-devel] avcodec/h264_metadata_bsf: Don't use unitialized value
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate fail Make fate failed
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Jan. 22, 2021, 11:43 a.m. UTC
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavcodec/h264_metadata_bsf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Thompson Jan. 22, 2021, 1:36 p.m. UTC | #1
On 22/01/2021 11:43, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>   libavcodec/h264_metadata_bsf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c
> index 30c0aa80d9..6673a32601 100644
> --- a/libavcodec/h264_metadata_bsf.c
> +++ b/libavcodec/h264_metadata_bsf.c
> @@ -528,7 +528,7 @@ static int h264_metadata_update_fragment(AVBSFContext *bsf, AVPacket *pkt,
>       if (pkt)
>           ctx->done_first_au = 1;
>   
> -    return err;
> +    return 0;
>   }
>   
>   static const CBSBSFType h264_metadata_type = {
> 

LGTM, thanks.  (Somewhat disappointed that gcc didn't catch that for me, though.)

- Mark
diff mbox series

Patch

diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c
index 30c0aa80d9..6673a32601 100644
--- a/libavcodec/h264_metadata_bsf.c
+++ b/libavcodec/h264_metadata_bsf.c
@@ -528,7 +528,7 @@  static int h264_metadata_update_fragment(AVBSFContext *bsf, AVPacket *pkt,
     if (pkt)
         ctx->done_first_au = 1;
 
-    return err;
+    return 0;
 }
 
 static const CBSBSFType h264_metadata_type = {