diff mbox series

[FFmpeg-devel] avcodec/sei: add Parameter Set Inclusion Indication enum value

Message ID 20210122193424.4464-1-jamrial@gmail.com
State Accepted
Commit 683cd25c5a397447eb53754af948e7bf2cb3361e
Headers show
Series [FFmpeg-devel] avcodec/sei: add Parameter Set Inclusion Indication enum value
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

James Almer Jan. 22, 2021, 7:34 p.m. UTC
Defined in H.274, it shares the same value as Active Parameter Sets (which was
removed for codecs that reference H.274).

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/sei.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Thompson Jan. 26, 2021, 11:59 p.m. UTC | #1
Parameter Set_s_ in the title.  (That made me look carefully, so I guess it's good.)

On 22/01/2021 19:34, James Almer wrote:
> Defined in H.274, it shares the same value as Active Parameter Sets (which was
> removed for codecs that reference H.274).

It's really a rename.  The concept of activeness has gone so the old name and all of the active fields from H.265 don't make sense; the only value left is self_contained_cvs_flag and that's exactly what we get in H.274.

> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavcodec/sei.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/sei.h b/libavcodec/sei.h
> index f07c72ae7b..5513590b51 100644
> --- a/libavcodec/sei.h
> +++ b/libavcodec/sei.h
> @@ -85,6 +85,7 @@ enum {
>       SEI_TYPE_GREEN_METADATA                              = 56,
>       SEI_TYPE_STRUCTURE_OF_PICTURES_INFO                  = 128,
>       SEI_TYPE_ACTIVE_PARAMETER_SETS                       = 129,
> +    SEI_TYPE_PARAMETER_SETS_INCLUSION_INDICATION         = SEI_TYPE_ACTIVE_PARAMETER_SETS,
>       SEI_TYPE_DECODING_UNIT_INFO                          = 130,
>       SEI_TYPE_TEMPORAL_SUB_LAYER_ZERO_IDX                 = 131,
>       SEI_TYPE_DECODED_PICTURE_HASH                        = 132,
> 

LGTM in any case.

Thanks,

- Mark
diff mbox series

Patch

diff --git a/libavcodec/sei.h b/libavcodec/sei.h
index f07c72ae7b..5513590b51 100644
--- a/libavcodec/sei.h
+++ b/libavcodec/sei.h
@@ -85,6 +85,7 @@  enum {
     SEI_TYPE_GREEN_METADATA                              = 56,
     SEI_TYPE_STRUCTURE_OF_PICTURES_INFO                  = 128,
     SEI_TYPE_ACTIVE_PARAMETER_SETS                       = 129,
+    SEI_TYPE_PARAMETER_SETS_INCLUSION_INDICATION         = SEI_TYPE_ACTIVE_PARAMETER_SETS,
     SEI_TYPE_DECODING_UNIT_INFO                          = 130,
     SEI_TYPE_TEMPORAL_SUB_LAYER_ZERO_IDX                 = 131,
     SEI_TYPE_DECODED_PICTURE_HASH                        = 132,