diff mbox series

[FFmpeg-devel,2/2] avfilter/vf_unsharp: Remove unnecessary ;

Message ID 20210124213253.1344753-2-andreas.rheinhardt@gmail.com
State Accepted
Commit 3c700c82cbee49d1f40b6a7063f4b084ae3ee747
Headers show
Series [FFmpeg-devel,1/2] avfilter/vf_nnedi: Fix segfault when prescreening is disabled
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

Andreas Rheinhardt Jan. 24, 2021, 9:32 p.m. UTC
A macro that expands to a function definition might look like a
declaration, but it isn't and therefore an extra ';' at the end is
unnecessary and actually invalid (both GCC and Clang warn about this
when using -pedantic).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---
 libavfilter/vf_unsharp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andreas Rheinhardt Jan. 26, 2021, 1:37 p.m. UTC | #1
Andreas Rheinhardt:
> A macro that expands to a function definition might look like a
> declaration, but it isn't and therefore an extra ';' at the end is
> unnecessary and actually invalid (both GCC and Clang warn about this
> when using -pedantic).
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
> ---
>  libavfilter/vf_unsharp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/vf_unsharp.c b/libavfilter/vf_unsharp.c
> index e9b6c9008d..198dbbaa51 100644
> --- a/libavfilter/vf_unsharp.c
> +++ b/libavfilter/vf_unsharp.c
> @@ -139,8 +139,8 @@ static int name##_##nbits(AVFilterContext *ctx, void *arg, int jobnr, int nb_job
>      }                                                                                                 \
>      return 0;                                                                                         \
>  }
> -DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 16);
> -DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 8);
> +DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 16)
> +DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 8)
>  
>  static int apply_unsharp_c(AVFilterContext *ctx, AVFrame *in, AVFrame *out)
>  {
> 
Will apply soon.

- Andreas
diff mbox series

Patch

diff --git a/libavfilter/vf_unsharp.c b/libavfilter/vf_unsharp.c
index e9b6c9008d..198dbbaa51 100644
--- a/libavfilter/vf_unsharp.c
+++ b/libavfilter/vf_unsharp.c
@@ -139,8 +139,8 @@  static int name##_##nbits(AVFilterContext *ctx, void *arg, int jobnr, int nb_job
     }                                                                                                 \
     return 0;                                                                                         \
 }
-DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 16);
-DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 8);
+DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 16)
+DEF_UNSHARP_SLICE_FUNC(unsharp_slice, 8)
 
 static int apply_unsharp_c(AVFilterContext *ctx, AVFrame *in, AVFrame *out)
 {