From patchwork Mon Feb 15 16:55:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 25644 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id D9F2244B8A3 for ; Mon, 15 Feb 2021 18:56:22 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C193D68980E; Mon, 15 Feb 2021 18:56:22 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 199E06881B7 for ; Mon, 15 Feb 2021 18:56:20 +0200 (EET) Received: by mail-wr1-f49.google.com with SMTP id n4so6764179wrx.1 for ; Mon, 15 Feb 2021 08:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=3Z1Vh5cEyMqF/bCbJ20qnMUM5g73FvA4KyUGc+NmH1w=; b=uCbyxlOznzNTkyVAOWl+26t/9ulEoOC1P3ABqnV2DRHujEq+XWjZW/faW4NIzyNH8s QNGVL0saczakcr+K7OJ/XR4o5K8E/KkHDZVAgjZl7/IGNjZLJkI79p00OD2KF4JCc/EL uorA9dDFJKYg1mv0PsH9dED9gL3GfjP6FRYytibbtljadSM8TDOT1Jh6Q69PnbzmkGyO t1sTb7s5bLilkbR4gPi1zEpXljUGV4yATiLsCBLjSGYWVIWT7aPTsQ7HUaoVOGe/oeOy R5RPT4ALp2PIQxYqRnHVabN/V5gpQVLYapzW/HHaBaqQZWogc6dmD8c1IsJ/vMHkKsuJ carQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=3Z1Vh5cEyMqF/bCbJ20qnMUM5g73FvA4KyUGc+NmH1w=; b=GEirk77tlAixQgmhDZ4NGkZvvh5QTm/a/GkoOt8Y+ozi9Bl2SC2hEa5FJDg2a/E38e WqqsK5YBvCVKqmre4AG0EEo7lu944GD7mWsg337jyynZCMT1SOlIOoBNlMOzVte9AkNq /dAAbbFwLdHNrQin7o4WFHrdnvNI6qOkn9Y2hUHQrUumXtbiUbgN3yrq4HDJMuaUBRWY D/uABhqivt3N6Rhx9K/RDE6wPM0llnt81w/Y0Eu13LcSaEmSeKhpEOZb+k5LRmIntl8B 3zkVTxJr5TMDTt58V/O5dFrCgqNM1X0jzk3suE8TzNHIjk+NymDKchLpTNDTD04M3JjD zHtw== X-Gm-Message-State: AOAM532fV0y/goYvvtg8e4eYPar3x66hvwexg6dbyxkZJ6xukLvIYbE/ nVmTXYDeGV0DOMYvKa6U0gItoxWJR6c= X-Google-Smtp-Source: ABdhPJxdtoW9rj2AEf6TtFRkmMmhtm+x+T6eigTk9IHKPWfCEO/41+Hvy8vFVyf8iY6vgAn2EilwOQ== X-Received: by 2002:adf:fc09:: with SMTP id i9mr20016367wrr.235.1613408179433; Mon, 15 Feb 2021 08:56:19 -0800 (PST) Received: from sblaptop.fritz.box (ipbcc1aa4b.dynamic.kabel-deutschland.de. [188.193.170.75]) by smtp.gmail.com with ESMTPSA id b2sm24531855wrv.73.2021.02.15.08.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 08:56:19 -0800 (PST) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Mon, 15 Feb 2021 17:55:48 +0100 Message-Id: <20210215165549.667105-5-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210215165549.667105-1-andreas.rheinhardt@gmail.com> References: <20210215165549.667105-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 5/6] tests/fate-run.sh: Don't overlook errors from md5 tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The md5 test up until now ignored errors from ffmpeg (the cli) and just md5'ed whatever ffmpeg has output; while testing scenarios in which ffmpeg fails has its merits, errors should not be overlooked by default; doing so also reduces the effectiveness of sanitizers as errors from them are ignored. This has happened with a memleak in the AV1 decoder. Signed-off-by: Andreas Rheinhardt --- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 58d5fdbb60..b69176f7c3 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -158,7 +158,7 @@ md5pipe(){ md5(){ encfile="${outdir}/${test}.out" cleanfiles="$cleanfiles $encfile" - ffmpeg -y "$@" $(target_path $encfile) + ffmpeg -y "$@" $(target_path $encfile) || return do_md5sum $encfile | awk '{print $1}' }