From patchwork Wed Feb 17 19:12:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Iashin X-Patchwork-Id: 25711 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id DC25744BB95 for ; Wed, 17 Feb 2021 21:12:22 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B55B668A17B; Wed, 17 Feb 2021 21:12:22 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6CBDC6805D1 for ; Wed, 17 Feb 2021 21:12:16 +0200 (EET) Received: by mail-lj1-f175.google.com with SMTP id r23so17756036ljh.1 for ; Wed, 17 Feb 2021 11:12:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=peT00XcJnAZSBnAmTUOqKyR4sEFoOUFJeISIcW0a8+g=; b=KyiOO7DRpdWiN7/S1TLFVEQMbgNA6FS9JK94An6DIMUmU+osXSOD2IK6pZEOahZ3zl IioRe9vKUQG/yiDEhsEyOIKXPegV6IqUgXBba4G7q7R5+TXV1d8HY6F5LJeyhbYAnTmL y6QEbGLJiFtriUrirQgTanu3LK+Hn0C556ubV28cgl/Obie9nyjuT5y3mGwmxJbAa7sY 4cpzBzFj5VPRPD01A74OeNLSozODG2h2BdPI4eIugodVOnaVYgFW33z2HIhddEV8c65c DrCkUuTfMOJpHDoE1Qw2DmgjCjOQIFpr+9EO7zgpT0HkX5H64Q0+eqUYJexSlBmFmiCn xAnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=peT00XcJnAZSBnAmTUOqKyR4sEFoOUFJeISIcW0a8+g=; b=NNnGVOCuuUmKQOOce3WY8zkf/q2HZkfzY4mmCTX5RSymsRhSjdyR9gIlPFNITqxIUg wgOiylfz+rMVTLfw9aguJrap+JzxX5LoF3VluPeCaTi1Gt+dyM5Y2t4iLi6SpkHqA1AD Q6BvZ7/2bBok6jYALaOcAE2N7US+a61HiaVmOTyLYjp23Okve3Lk7ODkqPZiGyr+bWj+ SitUHbzWWp5KlWX6ROhsDayNCitIkJiuX1OamUIUxZYxZ0OT+HQrVMLnVJKSFjdlSkGf L3BqF7Do9agj4EVPVNVZfQlTMA3smxb1uH+f0zAOFkg378D22jwJxqj6Vw61yUWXx2VK m82g== X-Gm-Message-State: AOAM532yGlEffRuhduqgSp862YXanbQJxMOgqSEvpAQLnXIKW+Nfdq1F sidMeLowPmMeO89CVWlY1uZ0v22PMsJU X-Google-Smtp-Source: ABdhPJxmekDjjUDL5aguPch5XF/1RF8C/7HqxZAGPe0s/8GTALAh9gOPtD6pft5aFgQQLyjgAECyUA== X-Received: by 2002:a2e:9f4a:: with SMTP id v10mr423808ljk.312.1613589135601; Wed, 17 Feb 2021 11:12:15 -0800 (PST) Received: from localhost.localdomain (broadband-46-242-13-95.ip.moscow.rt.ru. [46.242.13.95]) by smtp.gmail.com with ESMTPSA id u10sm335588lfu.127.2021.02.17.11.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 11:12:15 -0800 (PST) From: Sergei Iashin To: ffmpeg-devel@ffmpeg.org Date: Wed, 17 Feb 2021 22:12:13 +0300 Message-Id: <20210217191213.197994-1-yashin.sergey@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libavformat/dashenc.c: In some circumstances a total_duration equals to zero so that it makes possible for SIGFPE to appear and crash an application. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Sergei Iashin Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" --- libavformat/dashenc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 2d757b3a87..fbdee126e9 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -844,7 +844,11 @@ static int write_adaptation_set(AVFormatContext *s, AVIOContext *out, int as_ind if (os->bit_rate > 0) snprintf(bandwidth_str, sizeof(bandwidth_str), " bandwidth=\"%d\"", os->bit_rate); else if (final) { - int average_bit_rate = os->pos * 8 * AV_TIME_BASE / c->total_duration; + int average_bit_rate = 0; + if(c->total_duration > 0) + { + average_bit_rate = os->pos * 8 * AV_TIME_BASE / c->total_duration; + } snprintf(bandwidth_str, sizeof(bandwidth_str), " bandwidth=\"%d\"", average_bit_rate); } else if (os->first_segment_bit_rate > 0) snprintf(bandwidth_str, sizeof(bandwidth_str), " bandwidth=\"%d\"", os->first_segment_bit_rate);