From patchwork Wed Mar 10 01:05:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 26296 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 0274F44B25E for ; Wed, 10 Mar 2021 03:14:30 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D17FC68A874; Wed, 10 Mar 2021 03:14:29 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 18886689F02 for ; Wed, 10 Mar 2021 03:14:24 +0200 (EET) Received: by mail-lf1-f54.google.com with SMTP id u4so30601205lfs.0 for ; Tue, 09 Mar 2021 17:14:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=7uRfk8fSPB582+iTS9G8ZpTWnPeWy+3Q1DZBMMWfPMI=; b=cYuVtR5zkMbREs7S1QrZkDg6psKIi9JpFOaYe9Ees/0Esknz5mBtauugTUm/BA/9mA n6Bb/QKujmWsHaNyp96aFjhYTR79EWCMMrDVfv5Sllt9sGyhgtQnGmEvgR/wiCdY5Gyo 95QIqOC9YqumSsgNlPk3uAgzHFptJ29CIdvxk2MiWlEWLem1z9pkUM29rSQhOdhwtm9k HfFWLqO9WhQoUlP/FAQytgwlgVWDFJB67p6+BAN1QxtBtAal0JhqMXRZcFNh8gNcUB7W 808X3133rFoUI4cPy8xt/vheJNnKRuhWcT58VioKcYNwa26QEqIkv9bLNlYyGRPaXVoA E4mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=7uRfk8fSPB582+iTS9G8ZpTWnPeWy+3Q1DZBMMWfPMI=; b=Oo10BwUGDW5WRQjxEOysD8bHdU/BAUcBWe0bC7W1tWCcibfm68pggCm6DVi45SZ0p8 A259NB3m0FFTmxrzMYvOa6nrDuoz4m9tEODzLBguizWQs7WWjKDueWTS1uXWCueOJ/LQ ANj9F31pX/oVUl8Ic5mAZOeHOfgMYVjvKIPVOXGJvd2KgNXFk/eap7kCLf7AMjE3mD6+ WJRJcD/dlCj2mdhVSNOIXaIZBK58faQy6cif+BCggOCK0l0dadHm+YliBL4iIeOF8c5U 10oeJTKNtQBIwkqw5qIAiP8ZF3ZlfnqTX8NuXsKurvsfHjPZnwTxw5dl9lKRORv5MLLa QR8g== X-Gm-Message-State: AOAM533Y9tpLzMB4ydC2N96QLmuxtEW2GSI0jHJAM/sT3rEzPVec8DOi 0qFqWrBGtFL7hDkT+79+4pw1osSK1fA= X-Google-Smtp-Source: ABdhPJwelvos4Cj/plwznhwTSZdrPIJcpOnfUCK0PCzkqzfTnw13PhD/8vxRfkHAo+KXp5++lxaihw== X-Received: by 2002:a17:906:a86:: with SMTP id y6mr852963ejf.354.1615338393678; Tue, 09 Mar 2021 17:06:33 -0800 (PST) Received: from sblaptop.fritz.box (ipbcc1aa4b.dynamic.kabel-deutschland.de. [188.193.170.75]) by smtp.gmail.com with ESMTPSA id r13sm9960737edy.3.2021.03.09.17.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 17:06:33 -0800 (PST) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 10 Mar 2021 02:05:55 +0100 Message-Id: <20210310010601.1142819-2-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210310010601.1142819-1-andreas.rheinhardt@gmail.com> References: <20210310010601.1142819-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/8] avcodec/h264_cavlc: Remove redundant check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The only caller to ff_h264_decode_init_vlc() already uses ff_thread_once() for the call; ergo the check via a simple int with static storage duration in ff_h264_decode_init_vlc() is redundant. And if it were not redundant, it would be a potential for data races. So remove it. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_cavlc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libavcodec/h264_cavlc.c b/libavcodec/h264_cavlc.c index 6481992e58..d0548d84f6 100644 --- a/libavcodec/h264_cavlc.c +++ b/libavcodec/h264_cavlc.c @@ -325,12 +325,8 @@ static av_cold void init_cavlc_level_tab(void){ } av_cold void ff_h264_decode_init_vlc(void){ - static int done = 0; - - if (!done) { int i; int offset; - done = 1; chroma_dc_coeff_token_vlc.table = chroma_dc_coeff_token_vlc_table; chroma_dc_coeff_token_vlc.table_allocated = chroma_dc_coeff_token_vlc_table_size; @@ -410,7 +406,6 @@ av_cold void ff_h264_decode_init_vlc(void){ INIT_VLC_USE_NEW_STATIC); init_cavlc_level_tab(); - } } static inline int get_level_prefix(GetBitContext *gb){