From patchwork Fri Mar 19 00:52:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 26461 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 4042C44B555 for ; Fri, 19 Mar 2021 02:53:19 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2DF7868A42C; Fri, 19 Mar 2021 02:53:19 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D2DB2680946 for ; Fri, 19 Mar 2021 02:53:09 +0200 (EET) Received: by mail-ej1-f46.google.com with SMTP id w3so6895635ejc.4 for ; Thu, 18 Mar 2021 17:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=93bQ5zaGNNiSekmvFs8qHVlUsf+qxUzrvDdEnCfCLc0=; b=f1egiD8++kiyUyEIXNTVgAuQYQUX2PbeHzPSasTmGHWYsiTHEfCf8RZvR2K2YL4Ep+ +4LGc5ujjwQ5WYFkxI9G2rjA8k/qhKrSOfETi2/Msfor0QCiBTrM+yEDCE7iH8HLxSPp N3yjOKSKkBG+ydbB3NQKnp2yghceK4tcq3JMs1xZkO6ifOZfHDGNQAFg8IL3cU4v+JFf 4liFtm+Ud+E4Q5eNrWkttvhfeGFfjwhteNrO4goIC5nFVrzT0SwMN7O62Pt91pYfR5lF gtZwNUbGGqmWlJg9qYijc4hP+NtKQ5AYhoBhN3aW7SUi+u/t43voQ9u0xPs6H5PG4QMX S/dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=93bQ5zaGNNiSekmvFs8qHVlUsf+qxUzrvDdEnCfCLc0=; b=rCMrqc2qfnM++OnxkOQsnW7IvOZ0foXD+TXI3X4G+1p5vBnbewLTyYy5Who7yQruIJ J10FHOw55LLByr2YiOc5S63l5RvM5glyFbS2COcEpJxa5GYH02khik1SfNeYj/TybFRI Q+e2c1GBcVH+MKUby+zeiTDMy+nXYuJfXId0qplSvS/fy20b2BDjkQfNPZGCbn0rBlfQ A4q/8zirxqAmPBK8XSRxNvJTNtbvJq5FIOWAbb6u/I5sEmmolKmrWIqUn+uMcTRbxf0t D7qlBE/BfmFIvz3gpH8foYKvM2MGiXInh/I3ulShParQHB4O6tcBxRFZkP0J7wQygXh2 dY9w== X-Gm-Message-State: AOAM531O8/7xsh8uOnyR/LKdioKEH9c0JK2jlrvq6CPIZHL931turD7A Q6fMUh1cprsqqF412YsNBDitGbwZdQ9OIQ== X-Google-Smtp-Source: ABdhPJyrwo7msLX6Qr7nIhz6YtQHRQEPHhviXHRMxx5hYCUAuMEfNIqj/0NCJc7zyi5YTRytP0ZREw== X-Received: by 2002:a17:906:d554:: with SMTP id cr20mr1475730ejc.61.1616115189031; Thu, 18 Mar 2021 17:53:09 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc08960.dynamic.kabel-deutschland.de. [188.192.137.96]) by smtp.gmail.com with ESMTPSA id r10sm2779304eju.66.2021.03.18.17.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 17:53:08 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Fri, 19 Mar 2021 01:52:44 +0100 Message-Id: <20210319005244.1737816-4-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210319005244.1737816-1-andreas.rheinhardt@gmail.com> References: <20210319005244.1737816-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/4] avcodec/libxvid: Remove set-but-unused variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Set-but-unused since 2101b99777860c853ca2321031eb3f4047dc5894. Signed-off-by: Andreas Rheinhardt --- Before 2101b99777 the packet was only unreferenced on success so that said commit seems to have fixed a potential memleak. libavcodec/libxvid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index 25b0025d5f..50601807a7 100644 --- a/libavcodec/libxvid.c +++ b/libavcodec/libxvid.c @@ -685,7 +685,7 @@ FF_ENABLE_DEPRECATION_WARNINGS if (x->quicktime_format) { AVFrame *picture; AVPacket *packet; - int size, got_packet, ret; + int size, got_packet; packet = av_packet_alloc(); if (!packet) @@ -716,7 +716,7 @@ FF_ENABLE_DEPRECATION_WARNINGS picture->data[2] = picture->data[1] + size / 4; memset(picture->data[0], 0, size); memset(picture->data[1], 128, size / 2); - ret = xvid_encode_frame(avctx, packet, picture, &got_packet); + xvid_encode_frame(avctx, packet, picture, &got_packet); av_packet_free(&packet); av_free(picture->data[0]); av_frame_free(&picture);