From patchwork Fri Mar 19 11:48:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Playfair Cal X-Patchwork-Id: 26486 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id B701A44863E for ; Fri, 19 Mar 2021 13:55:40 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7551E687F21; Fri, 19 Mar 2021 13:55:40 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A28B3680A4D for ; Fri, 19 Mar 2021 13:55:33 +0200 (EET) Received: by mail-pf1-f181.google.com with SMTP id j25so5721584pfe.2 for ; Fri, 19 Mar 2021 04:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RZhOEcjravfsui6zI6tbyhXFWuZ2OF2r23iOxefL6kA=; b=URIbPqTsc0GP2BsIfZUvG3FHtEvW+/XK/F/iuKU9o43nsf0ytsgyPFxSaUJ2pbuxWw WCfoC6GhLxcdcsKcC3xwBAdiBydlrz8hzITEha9NQ23s+axFAsLDL8uuOWNsNa6QrZzQ qOeLj3APLhFY3dU8dHniartiWHL4mYFCKm1AR9dbhOz+TvpqQmxTBspl+3l0ouzqeTmD lqcZ6g96SlUQl1UTcCGCMs9KzUtdARd+OgMG97eMjSwUwEw9WpAKtdSABxusvgStnaLo Y6oCjBpXRqp6PBwGIsunC1LUYIE0t1c45ImgCmwEbiZq5GcDL3rTwyHH8Mmqy/4c35PX DzlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RZhOEcjravfsui6zI6tbyhXFWuZ2OF2r23iOxefL6kA=; b=dX0Wlvik8fZ0eh4V051585fE1X0S/JgNxABEmbIKgZO2dz65IZotLxCvihS7Ph0OL3 zxJbfCub4I/iUYSCKnrXqyY5rLpQzIjqK5mN5jTiWai8dN6zzjIqlWZTL6AWCyANf+Uf F1YXsGroUuEI1gaJlIjKssbzR4aVycZo//ROPOmIHCkVqkyJrfSC+/zcq5h1gfHUxdio Q4m2VxEzJF59VNmAjbMg/lDnRu2J9VlXQE8fSV8p/1g45vscNaseDqrz9GlAcYcvhxlh Z2pOu77wOPDjloUn/9n0ZwLtXBbQMgWKcaG0+dammGar+6uAof3WBZFzr4gWFUcwFc/j 6jFQ== X-Gm-Message-State: AOAM533Cd023FkTciQsVa7wRKXKXKThG6njlRjbTkqlBsJyPAXR/+Q4p +i7WIts4PgU+EG01S132Y5mxEuzjJ9va3A== X-Google-Smtp-Source: ABdhPJwOnfRFcvnzeFwjIZzYkKPM4l6zbf3MEWl0KXwG7FOaDutIQtpH91Zv5ko2B9J2cXWHptNrxw== X-Received: by 2002:aa7:9a95:0:b029:1f3:4169:ccf2 with SMTP id w21-20020aa79a950000b02901f34169ccf2mr8599637pfi.14.1616154541435; Fri, 19 Mar 2021 04:49:01 -0700 (PDT) Received: from localhost.localdomain (110-175-121-4.static.tpgi.com.au. [110.175.121.4]) by smtp.gmail.com with ESMTPSA id f19sm5371467pgl.49.2021.03.19.04.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 04:49:01 -0700 (PDT) From: Daniel Playfair Cal To: ffmpeg-devel@ffmpeg.org Date: Fri, 19 Mar 2021 22:48:47 +1100 Message-Id: <20210319114847.943168-1-daniel.playfair.cal@gmail.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <277996> References: <277996> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] vf_v360: fix visibility test for fisheye projection X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Daniel Playfair Cal Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Previously the visibility test referred to a circle in the input. This changes it so that it refers accurately to the entire area in the input. Signed-off-by: Daniel Playfair Cal --- This version avoids using double literals libavfilter/vf_v360.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c index 94473cd5b3..3ac2b914eb 100644 --- a/libavfilter/vf_v360.c +++ b/libavfilter/vf_v360.c @@ -2887,7 +2887,7 @@ static int xyz_to_fisheye(const V360Context *s, float uf = vec[0] / lh * phi / s->iflat_range[0]; float vf = vec[1] / lh * phi / s->iflat_range[1]; - const int visible = hypotf(uf, vf) <= 0.5f; + const int visible = -0.5f < uf && uf < 0.5f && -0.5f < vf && vf < 0.5f; int ui, vi; uf = (uf + 0.5f) * width;