From patchwork Thu Mar 25 15:49:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 26600 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 7EC6244B722 for ; Thu, 25 Mar 2021 17:50:42 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6455E68AB29; Thu, 25 Mar 2021 17:50:42 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3686768AACC for ; Thu, 25 Mar 2021 17:50:34 +0200 (EET) Received: by mail-ed1-f53.google.com with SMTP id dm8so2977596edb.2 for ; Thu, 25 Mar 2021 08:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=e4FiIJa5VIbfo6oxcoD19qlKQJLvsEbMTaah4tVz7AY=; b=cR+DoW4z7T4/55YEUzKnzievOdEfBWVRtABaURpMAz33hBBeRMKy37PLxslJ9hYDKJ Rm+n5QPWfiI3LpWKg1TPgtf8W1eRsV82aFBzrGdRdDQf1vpk68gPUd4Cr7fLCjfuPXCy 1xlCEBHSgG0iL5nyNI/ft/pB+VY44wz30fbD4j3YGMDotBeHzpXoYlKNgX+JPnMwbG6w dfUTSEzadWBptNmAl/zafu1BHBP4jKajV+z9OkNuJ+GoAL1w/LNTaE416+Pw63Ta1riI epg3ziY28WsPUiBHIaphnG+6xPZJ/i7NHNv9eTUpG+Is/in2+8LBfgnksEI22mI6eZG9 dJxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=e4FiIJa5VIbfo6oxcoD19qlKQJLvsEbMTaah4tVz7AY=; b=qWJIn/+9hbMv0nn3Tk2RvXontZk1Jgu9NAfImzs2tldTUlbQBnhlxiu0jt9tMDq6YP Sg29/W6MdvGCmL1lhu9g0PG/MysoonA0sWCe5uWV1+o91skp65K9BJsi3WnDbHObk+Z2 T6IRmywwjN0de+ewRgJ0V7ltLlR6OymljkurhkzqfndRmJtd4dDaP1f8bwv9LTh0jpZQ bJf0qKVsmsLzQhObB5weZeUBk4cuLmxdaP1RASZ/HyJsKINrJtKdWmsWl73aVgqvgAT9 WDr4jII9sohomiXqfSym+UdRiaAw4qaSQvpmtkEmGK6S8t1F0Pj9YqEhaeD7LIxUjxyf 6VTw== X-Gm-Message-State: AOAM533J/quKO1qkOU25CMLqqRXvZMPT+l38Y0eg0l0Dzm3QVMvBv2i3 D2qAspeC67CXy/gk8oOtj04fultBbtHzPg== X-Google-Smtp-Source: ABdhPJzM4BAC/TGy2YvfSjhYIYX6eS6uY0lahqMFZtmn1h6p5nLwxoyuZvvxSMQCHD3+hsXEaVdSzQ== X-Received: by 2002:aa7:cd0e:: with SMTP id b14mr10087070edw.354.1616687433487; Thu, 25 Mar 2021 08:50:33 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc08960.dynamic.kabel-deutschland.de. [188.192.137.96]) by smtp.gmail.com with ESMTPSA id o6sm2859103edw.24.2021.03.25.08.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 08:50:33 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 25 Mar 2021 16:49:48 +0100 Message-Id: <20210325154956.2405162-4-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210325154956.2405162-1-andreas.rheinhardt@gmail.com> References: <20210325154956.2405162-1-andreas.rheinhardt@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 04/12] avcodec/dvenc: Remove dead error message X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The PutBits API checks the available space before every write, so this check for overread is dead. Signed-off-by: Andreas Rheinhardt --- libavcodec/dvenc.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c index 233e2b68c7..134315a834 100644 --- a/libavcodec/dvenc.c +++ b/libavcodec/dvenc.c @@ -980,11 +980,6 @@ static int dv_encode_video_segment(AVCodecContext *avctx, void *arg) int size = pbs[j].size_in_bits >> 3; flush_put_bits(&pbs[j]); pos = put_bits_count(&pbs[j]) >> 3; - if (pos > size) { - av_log(avctx, AV_LOG_ERROR, - "bitstream written beyond buffer size\n"); - return -1; - } memset(pbs[j].buf + pos, 0xff, size - pos); }