From patchwork Wed Apr 21 12:31:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 27206 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:5014:0:0:0:0:0 with SMTP id e20csp357160iob; Wed, 21 Apr 2021 05:37:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq4uorTkQX4hcw/d3+yUzMx+KJ+ItQKjozBdz1jW6pXDtdRRA0OpyRZ9IFA3aHO3ziKHVP X-Received: by 2002:a17:906:37d7:: with SMTP id o23mr32313420ejc.202.1619008663092; Wed, 21 Apr 2021 05:37:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619008663; cv=none; d=google.com; s=arc-20160816; b=EkIg41KWewFyK9Yq3yu2pVs4BjyvXsc9mF93xG+tC4iLZmcDcsEhbhDGm2vYFFZ9nw Gd/DtqshWqD54tep4lhnhKvGZWvygVP00TXeH8TqrsVjTgFioT4b51OYSwsg7tic645u UXMx3s/iOGfPJTjShKSF0jzfo3e1N1IHiCAEWehnRzryNZiAgsefqbdzsZdX01GyMA3H +EdwM5GKMSo5jXTNvmEE5H/f+11CeRUwW0eGZAzGiOyWQiSfJr1VV0PmeoBHKJ3xlMnh x/Ibv48xvQStzcvY58eEVJYn/M8JIwcQUY5VXz1DZ00z2ubOn8NPOb8sq0uo5v1RyoDV EJQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=KJKYJUMHR3uIeySh0m4PkFXEYwmdnynPaa1MsQPm9q8=; b=sRmUZgvVG0q8Bi+ahFlO+EXZ6Tzy8K0ASqhFLXImIYpVNUPRnT5fKmSxge4o/ceAtT KrnRkvCamgIHGmp4KD9wCjIWN3ln2pxo7oG1cw1Q0JNZ6J045f46s4vF21QB+j107cc2 UH8St6asTECqFQTLt60Q8tqfMvocj+E/+ahCRXawrYZeFcg3qIMVjIjQ6LqGdPHGyAq8 d5fniRbbBeWzuWdnt6fvC53+BGh/vhroN2PtI+4Znj14vpsWJZyvmhRAlw9RCN6C3A+d w+luZyOH8qb2IW1OCyja8S4vmk4+ybZVmiCLr5d1GVUrZFecwK/jzX7owJNGARxpbCuC d4fQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y7si1968516edv.77.2021.04.21.05.37.42; Wed, 21 Apr 2021 05:37:43 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0B240689B83; Wed, 21 Apr 2021 15:37:40 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe05-3.mx.upcmail.net (vie01a-dmta-pe05-3.mx.upcmail.net [84.116.36.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F0A4C6891DA for ; Wed, 21 Apr 2021 15:37:33 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe05.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1lZC1i-00Dfcb-08 for ffmpeg-devel@ffmpeg.org; Wed, 21 Apr 2021 14:32:18 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id ZC0klBSIaljeHZC0klEVVR; Wed, 21 Apr 2021 14:31:18 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=BoHjPrf5 c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=nZOtpAppAAAA:20 a=Wy6r4lI0QzNypaFTXDUA:9 a=1fhp2MxaeJtTNGEnv6mo:22 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=jd6J4Gguk5HxikPWLKER:22 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Wed, 21 Apr 2021 14:31:17 +0200 Message-Id: <20210421123118.17901-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfLW94KnPNDi781yO5L7iVYl9mor1yKfLhvrmuX4lkP8Qr+epEmB/yPKlFZgTvIv5LfvW1CZT0pFmD7kI4fbRkPyJSQLXm9Cv/SutPaAblPxuEVZFWWSd ogBtKMvCRd7zFY6IbT1c1pcQPHL2ppbpNqtBeb5jHgQCsyTOgLlvpGXl Subject: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Avoid undefined overflow in time_offset calculation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: jKx9G3zVVkI5 Fixes: signed integer overflow: 8511838621821575200 - -3954125146725285889 cannot be represented in type 'long' Fixes: 33414/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-6610119325515776 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9ca1ac89a8..ecca73a1b8 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3822,7 +3822,11 @@ static void mov_build_index(MOVContext *mov, AVStream *st) if ((empty_duration || start_time) && mov->time_scale > 0) { if (empty_duration) empty_duration = av_rescale(empty_duration, sc->time_scale, mov->time_scale); - sc->time_offset = start_time - empty_duration; + + if (av_sat_sub64(start_time, empty_duration) != start_time - (uint64_t)empty_duration) + av_log(mov->fc, AV_LOG_WARNING, "start_time - empty_duration is not representable\n"); + + sc->time_offset = start_time - (uint64_t)empty_duration; sc->min_corrected_pts = start_time; if (!mov->advanced_editlist) current_dts = -sc->time_offset;