From patchwork Sun Apr 25 19:40:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 27365 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:5014:0:0:0:0:0 with SMTP id e20csp3374465iob; Sun, 25 Apr 2021 12:42:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyieXHy9DOMi/APX+ALN2tFc2Sz1L8jogD352OlsiFpSLHJfTUAUuCUzrJOUyrHr7pyO9e1 X-Received: by 2002:a17:906:e5a:: with SMTP id q26mr14880589eji.263.1619379721108; Sun, 25 Apr 2021 12:42:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619379721; cv=none; d=google.com; s=arc-20160816; b=I/rlmyWlf8CBeF88Zb2c42mlsZnNpzcpN1FnPSM9ZrQGcwqr7Y0bkSw4jwZqyKdO30 qXqK5CUgnxD43cCY9t+yGScsDRmFmmI0z0bpX2Kqc+diWxAFEdKL/C/N6bv4e1gJk8IY SfQCilxaKgS57F/aQ8EhoaMLOC+aQp8rvX7XO29Py6uwUH16jUm2fK5jKoe3dnMnZRJW uRch4UzcFkVmZcS3XQ71kPwdvlmjRXdSg1zkdhEwFDKQDyWp9ySMdAioPYCTDsFeQGdw Jvph8tcczzpgg6IXnytbzNDP/5k9XbAK9fBRhuIALW9JhTlR03uVArrJY8zG0jyq7mTP 2Y4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=MZKhNlP0y1j4CKPd7oNZaJ1iN9zknKsIjW6MWd/zaLg=; b=GmXkyw2dMhUXEuGhDmacyBNa7R2x3SEc0KdWNZMQfLnegUPjdptLc6YHJb9767LlPw 9b55+3PDGDYRb4HwF3DssWvwPNxhWXWVyseb/52GedOltgOlmmXc2o+kIdB+tsn8bFek ExXqziipAgIHYgPiMzbWSVWl6HmHahjsyWQNYoF9HngODTC5bzTZQGmCLhdJ3nUx4UXA 25xODsGvIWV7SAw+98bA9Sc52wWszG6jrMTihSaYolW5YKQNOm9GB0krtHClxQ50nseO 9soLRfqQygdjwMZPxZsC7EGCViJY+/tzHAbdpoEYaKqWgqntJCwK/HJdoGO5YFYVjyQp izuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id w11si13716659ede.2.2021.04.25.12.42.00; Sun, 25 Apr 2021 12:42:01 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C97EB6880AA; Sun, 25 Apr 2021 22:41:25 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe01-3.mx.upcmail.net (vie01a-dmta-pe01-3.mx.upcmail.net [62.179.121.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 37F6E680CF3 for ; Sun, 25 Apr 2021 22:41:15 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe01.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1lakd1-002HIz-0W for ffmpeg-devel@ffmpeg.org; Sun, 25 Apr 2021 21:41:15 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id akc2lFjbsljeHakc2lu0i7; Sun, 25 Apr 2021 21:40:15 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=BoHjPrf5 c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=nZOtpAppAAAA:20 a=G7kvjcKFJ5J3mClwFLwA:9 a=1fhp2MxaeJtTNGEnv6mo:22 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=UDnyf2zBuKT2w-IlGP_r:22 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 25 Apr 2021 21:40:12 +0200 Message-Id: <20210425194014.957-4-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210425194014.957-1-michael@niedermayer.cc> References: <20210425194014.957-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4wfI1yxvtNz1tA485sq5Ym0PuKZ2ezBhjsnqFlPrV0M78Qf1UR21/vo2fIF3r7trKSgM4ngKtp7E3NGoXFtDbyr1i+vQ7CMkswNX20kPnWenN1jWiBn37Q wwkYwBCJMcOmYiV6544YluTdwryJbQBZZskP4p/oi1jhVg8TTdKAPrbs Subject: [FFmpeg-devel] [PATCH 4/6] avformat/pp_bnk: Use 64bit in bitrate computation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: RoML8SA/G0Oa Fixes: signed integer overflow: 1207959552 * 4 cannot be represented in type 'int' Fixes: 29102/clusterfuzz-testcase-minimized-ffmpeg_dem_PP_BNK_fuzzer-6747301169201152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/pp_bnk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/pp_bnk.c b/libavformat/pp_bnk.c index 07eeca3cd5..5ffe733b18 100644 --- a/libavformat/pp_bnk.c +++ b/libavformat/pp_bnk.c @@ -223,7 +223,7 @@ static int pp_bnk_read_header(AVFormatContext *s) par->bits_per_coded_sample = 4; par->bits_per_raw_sample = 16; par->block_align = 1; - par->bit_rate = par->sample_rate * par->bits_per_coded_sample * par->channels; + par->bit_rate = par->sample_rate * (int64_t)par->bits_per_coded_sample * par->channels; avpriv_set_pts_info(st, 64, 1, par->sample_rate); st->start_time = 0;