From patchwork Fri May 7 17:17:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 27686 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp749453iof; Fri, 7 May 2021 11:07:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyj6qsev8GvtF16adhFWwBtacC9ygO3XDlTR66qXEIi704gP0e9RoVpm1XXHCKfYAgKwh7c X-Received: by 2002:a17:906:4d50:: with SMTP id b16mr11449423ejv.53.1620410871082; Fri, 07 May 2021 11:07:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620410871; cv=none; d=google.com; s=arc-20160816; b=KJCXYg3zWIeb4CzPLJl/1M3/tdFfoQUo2BTMPYzy9MntWypMoR6zpjZvC3qsnbc8Im xHr7FEA6x9itPZQYZLG4PtSg6GQJUdjN/MVllgTicLhsgJU8OrsIKNcPKNd9DEEyZI4M vM8qLVjJfUqDr8f7iwCKK63i5yznP3nK6n88Z52poSZGTWrcJTS/bg/hz4wWDk3AIYZp TXTt+idCjp0/oHGG/R4SdzkE3A78FT8vEojFsFjh4jMTj5hokPzSC6etfRvr4ZXHEKHG 4PKK2kC3WqMMN56pIDBQIW7GkGDaHVszaNxuwwgUBxw+MvK91arxdzCsHVbhDsY3D3xL ffjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=FG/EPcBMxbVCGNTX6gTrR4vDCoNkWYWLf9Th/He5vk4=; b=IJ1u2sqsHSdC3rIFn4/p2h3ChEL5QCFotd8CNT5C1+S7M2S0U/2vDBD/6PHLrr0HQ6 6fQ0GycZ/4wmHMkiOLBRffg3jHxaIb9+ltKQ2R8/gjtAvYpf3AVrpvMddva4nldYWt7W lL98C3PDDVTKcUz+B4oWZ764++/hvf92HD+ZSPa7Otf/vo2rVYI8k7VXVxFyTrX5mdOR DRYOZOKXV9ygBk4fghD3Av3/zQJ3t/SmKVIGcA2S1Jmn64G5jlGOwec3qY0iRs3WlhDN qKIKccvPyS7l9z4NImnVyHlJQN6fH6w1PcXRoZ2IxYpUgRTKa5kjk2FxiunsZAKrkCL+ zylw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=tY0zsSWj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id e5si5090947ejs.477.2021.05.07.11.07.50; Fri, 07 May 2021 11:07:51 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=tY0zsSWj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 43B4D6804FE; Fri, 7 May 2021 21:07:47 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 958EE6804FE for ; Fri, 7 May 2021 21:07:40 +0300 (EEST) Received: by mail-qv1-f49.google.com with SMTP id q6so5251777qvb.2 for ; Fri, 07 May 2021 11:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=CIhNKZNb5HUdJVcQ/r0hlIIEPhOLlI4tPLy0edkq1Z4=; b=tY0zsSWj2YhsA2w36rIPX4eC9VkzTFbcwkFi1aLW6VZ7gr49KXBWu0vRkgow7hX0Ff bvvXaXjBEv4DZeyazsc0C5QMLXOKe9nirObDX1XYNIboFa7aaemSIC2m6xoWm7ATnqmj lSxbjENVJ+CXBsj7dwEWbNccVfPyHy/4xPFbngxqJsg7sLOPkp+4KFCy+79xUzcewAyD 39Cnedppcg4//8g9RXGrJGs+kY0jRPFI2oGCd5W9RtOf3RF0x+u2C1rCAXXp0wUP3Prw 0j7WzVlfJsqIN6nwO1JMcTaT1AosqhZI8knRJNprjAsF4lX9kbioNNOatRi45HAR5wli 0iIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=CIhNKZNb5HUdJVcQ/r0hlIIEPhOLlI4tPLy0edkq1Z4=; b=HaTBTiHEBf71I/TQXswLs6Mw7GqSM+EJqG0KTxIZjRyaF7auN11kjueMpBUCrA3rBG Ehr+UMg+MetCppjipK0gBkIPohSmOjQFJwVnTuHRZ+lPyutTuBqtNaRMmyVvTbnzhqnU HKTFn+t5qpOCQBkVrhkmngx72VlZUn9JOxtRWxT4KPmXx2m6zNunVb+bKG62XjREhm7Q zTqkffFGPqusOnbg+6xZRovMUZYJAT2ssTzviobcU87Hdj7N36eRUQ4o2FsyqIAAaCVg RCJJSRqV+FQudgBsczMa5QN3GM1tjvbCF+BmsMraMZnKH5LtMptEsNoVTz3h+qtpI7SL tpCg== X-Gm-Message-State: AOAM531KgKnufdis3LJiY26DauSSF6I1K5+Z2lAMENwcjU8pMu6WGObJ nc45B8HRJDmPhLH/47i+VA4zKP/Ec9boFA== X-Received: by 2002:a0c:eec7:: with SMTP id h7mr1800772qvs.45.1620407882102; Fri, 07 May 2021 10:18:02 -0700 (PDT) Received: from localhost.localdomain ([191.83.217.42]) by smtp.gmail.com with ESMTPSA id m4sm5777592qtg.21.2021.05.07.10.18.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 10:18:01 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Fri, 7 May 2021 14:17:19 -0300 Message-Id: <20210507171719.930-1-jamrial@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/avpacket: always initialize the new packet in avpriv_packet_list_put() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: YFdDx7zgQNGe If a copy callback is provided by the caller, the packet passed to it was zeroed instead of initialized with default values. Signed-off-by: James Almer --- libavcodec/avpacket.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index e32c467586..1f20cd1e6b 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -519,13 +519,14 @@ int avpriv_packet_list_put(PacketList **packet_buffer, int (*copy)(AVPacket *dst, const AVPacket *src), int flags) { - PacketList *pktl = av_mallocz(sizeof(PacketList)); + PacketList *pktl = av_malloc(sizeof(PacketList)); int ret; if (!pktl) return AVERROR(ENOMEM); if (copy) { + get_packet_defaults(&pktl->pkt); ret = copy(&pktl->pkt, pkt); if (ret < 0) { av_free(pktl); @@ -540,6 +541,8 @@ int avpriv_packet_list_put(PacketList **packet_buffer, av_packet_move_ref(&pktl->pkt, pkt); } + pktl->next = NULL; + if (*packet_buffer) (*plast_pktl)->next = pktl; else