From patchwork Sat May 15 05:43:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brad Hards X-Patchwork-Id: 27783 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp1067914iof; Fri, 14 May 2021 22:44:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzUPsuO4E38nzKPPVwq5mnEBKmE4q79D7vfOfXsMNki7HMos3xgQLGheXdnmSdd2UNANv8Z X-Received: by 2002:a17:906:1984:: with SMTP id g4mr50449323ejd.525.1621057445656; Fri, 14 May 2021 22:44:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621057445; cv=none; d=google.com; s=arc-20160816; b=orCXqYgbK4Sy82OHUZODntYU8/91vyhx/lbBMnNiQc/29nV2Y0u9ITr+auANXpCiO7 JnTewm6dr99cWLI1m6c003hfSK4wyNjTnRTB6GuLxrewzaM7syDU53OnCMl+P6cnqTCw 6N5b/1dYMWe7RLu1IcKSJ0d8MvWGdmtDL6fd5Ha7sUMllfrsaGWKPvJomH7MgHhGdOPn XShxzJTonoEhefESw8qlApQtlSF1GZJnMF3RDvKRukAQ+hd0X2WBoyvaKzJotYpxUX4o tC3WdAdnLgDF2ZNtSLb6CV3E7KGKYgmN6LjCgf/Cv4LRp22I5Y5bBXwO8L+fUidFM5JW nH2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:delivered-to; bh=iZDvfnN4vGSEnfhxEL+81Ef+77ANx9AU+NlKU7gCkEI=; b=n8aAZojqWdNmSmfaC3C7X6oj4neRsKnG0lD/YN79/MpiImN9Az5MeeS6WfRQ5U9SaM KYLHN+qYEXVcb6SyhsJR397Yj1Io7JirmX4EsJjO9ayEj0p5WR/o4XHU7U53rBPqbov4 nUf+CSlwRqTnX1vScazBY1kNSSPCKZ5lsHAuLhsHd2PLSojHz5/qeE2+KlfLjdykZzoM swiIftWykWcU2A1n1/rtT1zxtCUtK6Zth2ochmwwVM764DbxzMvrSljMA7qj/8Qncx2q JAcWlAq5fX2dgEDjOujfggkRZ9MXGpTPpGIh4nTuhUqncx6rBdW9AZvkQECiMvYx85mi bPfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b14si7670559edx.131.2021.05.14.22.44.05; Fri, 14 May 2021 22:44:05 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DC43688128; Sat, 15 May 2021 08:43:48 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from cp1.nerdvana.net.au (cp1-new.nerdvana.net.au [113.212.99.70]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 67E9F68094F for ; Sat, 15 May 2021 08:43:39 +0300 (EEST) Received: from ppp115-205.static.internode.on.net ([150.101.115.205]:60460 helo=audax.fritz.box) by cp1.nerdvana.net.au with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lhn5N-0009gp-62; Sat, 15 May 2021 15:43:37 +1000 From: Brad Hards To: ffmpeg-devel@ffmpeg.org Date: Sat, 15 May 2021 15:43:15 +1000 Message-Id: <20210515054317.30414-2-bradh@frogmouth.net> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210515054317.30414-1-bradh@frogmouth.net> References: <20210515054317.30414-1-bradh@frogmouth.net> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cp1.nerdvana.net.au X-AntiAbuse: Original Domain - ffmpeg.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - frogmouth.net X-Get-Message-Sender-Via: cp1.nerdvana.net.au: authenticated_id: bradh@frogmouth.net X-Authenticated-Sender: cp1.nerdvana.net.au: bradh@frogmouth.net X-Source: X-Source-Args: X-Source-Dir: Subject: [FFmpeg-devel] [PATCH v3 1/3] libavcodec: write out user data unregistered SEI for x264 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Brad Hards Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: iTSUSjuTZOSZ Signed-off-by: Brad Hards --- libavcodec/libx264.c | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 1c27f7b441..feee8f8ee6 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -31,6 +31,7 @@ #include "internal.h" #include "packet_internal.h" #include "atsc_a53.h" +#include "sei.h" #if defined(_MSC_VER) #define X264_API_IMPORTS 1 @@ -303,6 +304,7 @@ static int X264_frame(AVCodecContext *ctx, AVPacket *pkt, const AVFrame *frame, int64_t wallclock = 0; X264Opaque *out_opaque; AVFrameSideData *sd; + int total_unreg_sei = 0; x264_picture_init( &x4->pic ); x4->pic.img.i_csp = x4->params.i_csp; @@ -316,6 +318,7 @@ static int X264_frame(AVCodecContext *ctx, AVPacket *pkt, const AVFrame *frame, x4->pic.img.i_plane = avfmt2_num_planes(ctx->pix_fmt); if (frame) { + void *sei_data_a53_cc; for (i = 0; i < x4->pic.img.i_plane; i++) { x4->pic.img.plane[i] = frame->data[i]; x4->pic.img.i_stride[i] = frame->linesize[i]; @@ -349,28 +352,50 @@ static int X264_frame(AVCodecContext *ctx, AVPacket *pkt, const AVFrame *frame, reconfig_encoder(ctx, frame); if (x4->a53_cc) { - void *sei_data; size_t sei_size; - ret = ff_alloc_a53_sei(frame, 0, &sei_data, &sei_size); + ret = ff_alloc_a53_sei(frame, 0, &sei_data_a53_cc, &sei_size); if (ret < 0) { av_log(ctx, AV_LOG_ERROR, "Not enough memory for closed captions, skipping\n"); - } else if (sei_data) { + } else if (sei_data_a53_cc) { x4->pic.extra_sei.payloads = av_mallocz(sizeof(x4->pic.extra_sei.payloads[0])); if (x4->pic.extra_sei.payloads == NULL) { av_log(ctx, AV_LOG_ERROR, "Not enough memory for closed captions, skipping\n"); - av_free(sei_data); + av_free(sei_data_a53_cc); } else { x4->pic.extra_sei.sei_free = av_free; x4->pic.extra_sei.payloads[0].payload_size = sei_size; - x4->pic.extra_sei.payloads[0].payload = sei_data; + x4->pic.extra_sei.payloads[0].payload = sei_data_a53_cc; x4->pic.extra_sei.num_payloads = 1; x4->pic.extra_sei.payloads[0].payload_type = 4; } } } + for (int j = 0; j < frame->nb_side_data; j++) + if (frame->side_data[j]->type == AV_FRAME_DATA_SEI_UNREGISTERED) + total_unreg_sei++; + if (total_unreg_sei > 0) { + x264_sei_t *sei = &(x4->pic.extra_sei); + sei->payloads = av_realloc_array(sei->payloads, + sei->num_payloads + total_unreg_sei, + sizeof(x264_sei_payload_t)); + if (!sei->payloads) { + av_log(ctx, AV_LOG_ERROR, "Not enough memory for unregistered SEI, skipping\n"); + av_free(sei_data_a53_cc); + sei->num_payloads = 0; + } else + for (int j = 0; j < frame->nb_side_data; j++) + if (frame->side_data[j]->type == AV_FRAME_DATA_SEI_UNREGISTERED) { + x264_sei_payload_t *payload = &(sei->payloads[sei->num_payloads]); + payload->payload = frame->side_data[j]->data; + payload->payload_size = frame->side_data[j]->size; + payload->payload_type = SEI_TYPE_USER_DATA_UNREGISTERED; + sei->num_payloads++; + } + } + sd = av_frame_get_side_data(frame, AV_FRAME_DATA_REGIONS_OF_INTEREST); if (sd) { if (x4->params.rc.i_aq_mode == X264_AQ_NONE) {