From patchwork Sat May 15 05:54:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yiyuan GUO X-Patchwork-Id: 27784 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp1087479iof; Fri, 14 May 2021 23:25:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyml0JC1aXh95TCffHdXwPczBGUvTUZfb28X4WO40cAldggcgiiXdFu14uipG1jGJaOgiLt X-Received: by 2002:a17:906:4e0d:: with SMTP id z13mr6260452eju.343.1621059901341; Fri, 14 May 2021 23:25:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621059901; cv=none; d=google.com; s=arc-20160816; b=DfWoVz1ZneGawA9adbfWLqrgIbCzDgk7wTHc68TTGy9Bzbj337mmJI+e51PrnufZaz eSas2UCePnodxEK73zZmCfLr2MSfklEtmZ8rywIVavxtbQrj4cJA3AIy9sbu1k8ibh+9 /jOotmzb5mc7Jy/A4WYhJ+UZSw8sBPNSX772Bb08MuO/tIRoXniQAQTbVzHnHG17Ps+0 35Vqs+LWaXXpAtOGXeZDYyAxXIJXr0icnPvcK7Q33+f83bPehaBPFczAOawJo72WIK30 yf1tUO/Uv8AMKn59H84E1qlZi7PfATsOzGWjDh+raUYx53ekwiZh8klCX84g0LIgEYPl ZOhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=QS7QwldWE5WyV8K5JJYQJ23YVTebPItsGs6Psale9p0=; b=G9h/3snbBKenSIBjXkSgh/8ZXZA47LinPyFEMfLmJsLXCZ3I3SZlb6+C4AEaY9RwYU icsBvLUnESvVLKHMfRi0sD6onU1+Z05fkz3juPZEWOwjrO/FOd6Vngpkh0Cfy6B0DePl efCVNzVQJhnv5EwwZvKg1vdLOv9ZxFHOtUbG3d9A9LcpXYVxLlxJD3pN/54pbm6xIN72 NzA0v3l6aLzlM/wtTi9LJNqU3GA6ythiKRYAVxrNU5VTTg3EaMGnvMx5ULmEtT3C5aKH FgX8YzyoFoChF2I6CnSInC52SEfEiyUjwKOqiTmljwkbeWGdJ1KPa4nJw4nyA11TnQu1 V5Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=RAQ3MSbG; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m7si8979336edq.472.2021.05.14.23.25.00; Fri, 14 May 2021 23:25:01 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=RAQ3MSbG; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB39D68812C; Sat, 15 May 2021 09:24:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 47A9768054E for ; Sat, 15 May 2021 09:24:51 +0300 (EEST) Received: by mail-pg1-f174.google.com with SMTP id i5so912044pgm.0 for ; Fri, 14 May 2021 23:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+BRfyqXvsoLw6lZNuBwoP5NhyKa2e2ZkMgkp2+Rycn8=; b=RAQ3MSbG5Oag2a0tIgOXGHmQPDSfaqBe5GCUTqewd+kxVKJrwTyevWN2PoZqPRWbke E4oPwWzCh0fscYaFc8bfO0Ut36VcRLKkl05XDx+P7sk9X2qoD2tO5kni7egbEgzbMFXM iGJCcN8eiHdYvPvna1pbQF2Sqh2FL6KjJFc92aiTWm1xn5zl9PDY+sYmiWzemhmuQwA6 vfpmEb5EokGso8tOH6Pz+P32PFaIONEwreYaOtGVw6o5g7cjlcLHZXwDy288VSdmwMiS b8kQWBemHqDG79c0O7UUmbinsib49UMatqANHMp1cmajXCNCn/AoydoPEi20SjI41d6c 033A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+BRfyqXvsoLw6lZNuBwoP5NhyKa2e2ZkMgkp2+Rycn8=; b=W4VYW8rbG7Z3HUdhIA2b3jiPTgsHnrnqqmyjVzs6BxAb2xNEkw5+VnWtv+9dQyRoy2 cEgTLYM++wNb4wDP7mB90Xv0R3y91hsU+u2CFT9taG1434HEdXnVom9cKiF+3dc+0S75 J7lMRGlDb6jUjFtIGxL0n41oL4o9oxW7phZhc1tkYBmwRdrmiOa3VxZ+TS7Yg7kObZLJ kobqiDhpJz0ZJxPwUP/pnmqstSKZOST/QMulhT6CgxDNPdwzIXlkhjqAWKbAtbB71ITv V0qKZbkgFN8dYSiLoB+PEYaM0dBJsqRCVIRKADZLGk2Zq8S6nXZFU/v6OW6upMIOOIzX pijw== X-Gm-Message-State: AOAM530uOtwXF60Wlqk14FzBYlRAlBgr9hQcRtzI6+sjiKTWb/JE0y/I ynvu5aF6+K5hDZ1a+wnOm0irqEHrhBA7FWJJ X-Received: by 2002:a62:8c05:0:b029:290:81ab:a936 with SMTP id m5-20020a628c050000b029029081aba936mr47987273pfd.69.1621058087893; Fri, 14 May 2021 22:54:47 -0700 (PDT) Received: from yguoaz-VirtualBox.hz.ali.com ([106.11.30.46]) by smtp.googlemail.com with ESMTPSA id m6sm2348434pfc.133.2021.05.14.22.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 22:54:47 -0700 (PDT) From: Yiyuan GUO To: ffmpeg-devel@ffmpeg.org Date: Sat, 15 May 2021 13:54:35 +0800 Message-Id: <20210515055435.69717-1-yguoaz@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avfilter/vf_palettegen: add protection against potential divide by zero X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: minas.gorgy@gmail.com, thomas.mundt@hr.de, jdelvare@suse.com, yguoaz@gmail.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 81jmDXRTus2Z In libavfilter/vf_palettegen.c, the function get_avg_color requires that box->len greater than zero to avoid dividing by zero. However, the call sequence filter_frame -> get_palette_frame -> get_avg_color may not satisfy this precondition. The bug is detailed in the bug tracker:https://trac.ffmpeg.org/ticket/9222. Signed-off-by: Yiyuan GUO --- libavfilter/vf_palettegen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index ef8bc18..73ec3c7 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettegen.c @@ -489,7 +489,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) if (s->stats_mode == STATS_MODE_DIFF_FRAMES) { av_frame_free(&s->prev_frame); s->prev_frame = in; - } else if (s->stats_mode == STATS_MODE_SINGLE_FRAMES) { + } else if (s->stats_mode == STATS_MODE_SINGLE_FRAMES && s->nb_refs) { AVFrame *out; int i;