| Message ID | 20210517055411.8654-1-yejun.guo@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/2] lavfi/dnn_filter_common.h: remove filter option 'options' | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | success | Make fate finished |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | success | Make fate finished |
> 2021年5月17日 下午1:54，Guo, Yejun <yejun.guo@intel.com> 写道： > > we'd use 'backend_configs' to avoid confusion > --- > libavfilter/dnn_filter_common.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/dnn_filter_common.h b/libavfilter/dnn_filter_common.h > index 09ddd8a5ca..51caa71c24 100644 > --- a/libavfilter/dnn_filter_common.h > +++ b/libavfilter/dnn_filter_common.h > @@ -45,7 +45,6 @@ typedef struct DnnContext { > { "input", "input name of the model", OFFSET(model_inputname), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },\ > { "output", "output name of the model", OFFSET(model_outputnames_string), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },\ > { "backend_configs", "backend configs", OFFSET(backend_options), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },\ > - { "options", "backend configs", OFFSET(backend_options), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },\ Not sure if there have users are using this options, What about use deprecated for it? > { "async", "use DNN async inference", OFFSET(async), AV_OPT_TYPE_BOOL, { .i64 = 1}, 0, 1, FLAGS}, > > > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > Thanks Steven Liu
> -----Original Message----- > From: Steven Liu <lq@chinaffmpeg.org> > Sent: 2021年5月17日 15:46 > To: FFmpeg development discussions and patches > <ffmpeg-devel@ffmpeg.org> > Cc: Steven Liu <lq@chinaffmpeg.org>; Guo, Yejun <yejun.guo@intel.com> > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavfi/dnn_filter_common.h: remove > filter option 'options' > > > > > 2021年5月17日 下午1:54，Guo, Yejun <yejun.guo@intel.com> 写道： > > > > we'd use 'backend_configs' to avoid confusion > > --- > > libavfilter/dnn_filter_common.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/libavfilter/dnn_filter_common.h > b/libavfilter/dnn_filter_common.h > > index 09ddd8a5ca..51caa71c24 100644 > > --- a/libavfilter/dnn_filter_common.h > > +++ b/libavfilter/dnn_filter_common.h > > @@ -45,7 +45,6 @@ typedef struct DnnContext { > > { "input", "input name of the model", > OFFSET(model_inputname), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, > FLAGS },\ > > { "output", "output name of the model", > OFFSET(model_outputnames_string), AV_OPT_TYPE_STRING, { .str = NULL }, 0, > 0, FLAGS },\ > > { "backend_configs", "backend configs", > OFFSET(backend_options), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, > FLAGS },\ > > - { "options", "backend configs", > OFFSET(backend_options), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, > FLAGS },\ > Not sure if there have users are using this options, > What about use deprecated for it? yes, will add AV_OPT_FLAG_DEPRECATED into FLAGS, thanks.
diff --git a/libavfilter/dnn_filter_common.h b/libavfilter/dnn_filter_common.h index 09ddd8a5ca..51caa71c24 100644 --- a/libavfilter/dnn_filter_common.h +++ b/libavfilter/dnn_filter_common.h @@ -45,7 +45,6 @@ typedef struct DnnContext { { "input", "input name of the model", OFFSET(model_inputname), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },\ { "output", "output name of the model", OFFSET(model_outputnames_string), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },\ { "backend_configs", "backend configs", OFFSET(backend_options), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },\ - { "options", "backend configs", OFFSET(backend_options), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, FLAGS },\ { "async", "use DNN async inference", OFFSET(async), AV_OPT_TYPE_BOOL, { .i64 = 1}, 0, 1, FLAGS},