| Message ID | 20210519022332.7295-1-fei.w.wang@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [FFmpeg-devel,v2] avcodec/vaapi_av1: pass full buffer size for each tile | expand |
| Context | Check | Description |
|---|---|---|
| andriy/x86_make | success | Make finished |
| andriy/x86_make_fate | success | Make fate finished |
| andriy/PPC64_make | success | Make finished |
| andriy/PPC64_make_fate | success | Make fate finished |
On Wed, May 19, 2021 at 5:24 AM Fei Wang <fei.w.wang@intel.com> wrote: > > Previously, only the size of a given tile was passed, making the > offset and size marked in VASliceParameterBufferAV1 invalid with > multiple tiles. > > Signed-off-by: Fei Wang <fei.w.wang@intel.com> > --- > Change: > 1. update commit message. > > libavcodec/vaapi_av1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c > index 1809b485aa..16b7e35747 100644 > --- a/libavcodec/vaapi_av1.c > +++ b/libavcodec/vaapi_av1.c > @@ -292,7 +292,7 @@ static int vaapi_av1_decode_slice(AVCodecContext *avctx, > err = ff_vaapi_decode_make_slice_buffer(avctx, pic, &slice_param, > sizeof(VASliceParameterBufferAV1), > buffer, > - s->tile_group_info[i].tile_size); > + size); > if (err) { > ff_vaapi_decode_cancel(avctx, pic); > return err; > -- > 2.17.1 LGTM. Will apply to master and release/4.4. Jan
On Thu, May 20, 2021 at 5:08 PM Jan Ekström <jeebjp@gmail.com> wrote: > > On Wed, May 19, 2021 at 5:24 AM Fei Wang <fei.w.wang@intel.com> wrote: > > > > Previously, only the size of a given tile was passed, making the > > offset and size marked in VASliceParameterBufferAV1 invalid with > > multiple tiles. > > > > Signed-off-by: Fei Wang <fei.w.wang@intel.com> > > --- > > Change: > > 1. update commit message. > > > > libavcodec/vaapi_av1.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c > > index 1809b485aa..16b7e35747 100644 > > --- a/libavcodec/vaapi_av1.c > > +++ b/libavcodec/vaapi_av1.c > > @@ -292,7 +292,7 @@ static int vaapi_av1_decode_slice(AVCodecContext *avctx, > > err = ff_vaapi_decode_make_slice_buffer(avctx, pic, &slice_param, > > sizeof(VASliceParameterBufferAV1), > > buffer, > > - s->tile_group_info[i].tile_size); > > + size); > > if (err) { > > ff_vaapi_decode_cancel(avctx, pic); > > return err; > > -- > > 2.17.1 > > LGTM. > > Will apply to master and release/4.4. Applied as: * master: 9b131e8500709fc7e66bf9049fc0a8f2c302cf9e * release/4.4: f7468a9c4037fd406847af4348c0deb2d521d0fc Thank you for the patch and discussion. Jan
diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c index 1809b485aa..16b7e35747 100644 --- a/libavcodec/vaapi_av1.c +++ b/libavcodec/vaapi_av1.c @@ -292,7 +292,7 @@ static int vaapi_av1_decode_slice(AVCodecContext *avctx, err = ff_vaapi_decode_make_slice_buffer(avctx, pic, &slice_param, sizeof(VASliceParameterBufferAV1), buffer, - s->tile_group_info[i].tile_size); + size); if (err) { ff_vaapi_decode_cancel(avctx, pic); return err;
Previously, only the size of a given tile was passed, making the offset and size marked in VASliceParameterBufferAV1 invalid with multiple tiles. Signed-off-by: Fei Wang <fei.w.wang@intel.com> --- Change: 1. update commit message. libavcodec/vaapi_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)