From patchwork Sat May 29 09:35:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 27979 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp1254788iof; Sat, 29 May 2021 02:36:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGnE8KgDsLzRbCVKHvS7jNflmZbweose7omQ9BEm87tkqgRSF6t79q/yck4phsyN9IncUh X-Received: by 2002:a05:6402:35cc:: with SMTP id z12mr14528447edc.154.1622281012341; Sat, 29 May 2021 02:36:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622281012; cv=none; d=google.com; s=arc-20160816; b=cX63P2Z8RJbYLtEOqNw0m1lbSkqqHVGWGtI0HkzB8Okr57sEXx7Q1jHD8V2Cs42di3 xfONjJ4NkrutN3cLK0n6nl2sSDAGJGNh4abHF/XQToR6GEYAnUn6c+x+di1DcZgO+9Hx njvp4K7a426zX2/XH5EwE20/A+vMIfIPkjSriDCvdpWV0i3/ZHGOPfTYWNbC212x4eT0 MYS74Xe3Y6WhPz/1gwnxf3yFimVLy9RYX9y2GWuNj+vH3OD89mKNiIa/ym5k09D6l7jP gr5uTkZafySL3xm1EHROae9qOuIAIotq23AXfvSj8KL6gnEAGUat7r8IwgCI1yJ5rXP3 LSdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=8M/7Eqj0Oliej53PZLa1fCqLKhVVqpbVYRZbhYmcexU=; b=wZrMOHrKSqPUFK8f0+aanQs6WlJ0Jji0NYCtuwRJltrACpPHDpfvwbE1x0Q1KfR83J c5WjwdRlTqUzUO0OPkPY2W9L+hIkIjih57PXd4RsudrBrP3lwwLbopV5QcHwcATCPhRu uRTk+zH6S6LtMrJXGO4t1Y3qb38UqukFaGECNwpZVGkv/M40pXo5g3BMPLmAM18wpgb9 1kREB3/tupMBa9ukXL+6jP5gCEZ3aUxi1WKZF+rzdSrbtNTLJGjeCfUkj+49V6394V0N LJsz/EhInIzZDLw0+KJJnzvyl4vg30XHK/MX2xVJRwnq133boj00H9yJmvU8FsocRIwa DUGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o20si7383979edr.268.2021.05.29.02.36.52; Sat, 29 May 2021 02:36:52 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A3DAE68020E; Sat, 29 May 2021 12:36:39 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe01-1.mx.upcmail.net (vie01a-dmta-pe01-1.mx.upcmail.net [62.179.121.154]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3678B687F17 for ; Sat, 29 May 2021 12:36:31 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe01.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1lmvOQ-005rqY-0J for ffmpeg-devel@ffmpeg.org; Sat, 29 May 2021 11:36:30 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id mvNSlDP3qljeHmvNSlLQEJ; Sat, 29 May 2021 11:35:30 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=BoHjPrf5 c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=NFwcUnkKh_PaUWckC38A:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sat, 29 May 2021 11:35:28 +0200 Message-Id: <20210529093530.15419-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfA14aINybRCcwZg1hx77mKCXIuwxzkNEHo85xoD8OSWujjOA8ORDfadMVohLgRihAOd8L7UxAPF7j8J4DpKuksxFXSKm8U593RKB7cwrRqUWo0wfgH2U dc2bgMtK7XSq0xtGdUORo+al1RDsFCK/AJBQ1E+bAUOrd81SCYBg0e8p Subject: [FFmpeg-devel] [PATCH 1/3] avformat/movenc: Check pal_size before use X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: OCZRv/5Wpp69 Fixes: assertion failure Fixes: out of array read Fixes: Ticket8190 Fixes: CVE-2020-22015 Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2ab507df15..7d839f447b 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2160,11 +2160,13 @@ static int mov_write_video_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex avio_wb16(pb, 0x18); /* Reserved */ if (track->mode == MODE_MOV && track->par->format == AV_PIX_FMT_PAL8) { - int pal_size = 1 << track->par->bits_per_coded_sample; - int i; + int pal_size, i; avio_wb16(pb, 0); /* Color table ID */ avio_wb32(pb, 0); /* Color table seed */ avio_wb16(pb, 0x8000); /* Color table flags */ + if (track->par->bits_per_coded_sample < 0 || track->par->bits_per_coded_sample > 8) + return AVERROR(EINVAL); + pal_size = 1 << track->par->bits_per_coded_sample; avio_wb16(pb, pal_size - 1); /* Color table size (zero-relative) */ for (i = 0; i < pal_size; i++) { uint32_t rgb = track->palette[i];