From patchwork Sun May 30 18:02:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 27987 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp2253458iof; Sun, 30 May 2021 11:04:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCXX5aqGmIE63lUZwFZSeWve/2gcbtu3Pl2U5kS90RFsSpWg40b/l5NjXDAgUgKxWjVuBJ X-Received: by 2002:a17:907:7b9e:: with SMTP id ne30mr4614417ejc.389.1622397849214; Sun, 30 May 2021 11:04:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622397849; cv=none; d=google.com; s=arc-20160816; b=raQ3TlMWxXESBmQj4rPi/bdIKWyhoYI4J8Kz79Y65k/VicTB3WonedDbcK9Po5kYqc VCfbq+N+XkWF9VJZJXivLi/eRQXkqsiVuBLwNXpXEm4vx4Mjk4tzG74c8LJ6N+5TapxM KWyJgKAWli5UesoUt8AUedjNT7WDlofy7I1KZi+JmBqSaroITi+MSeDm9UsENoNJ2AWY EWUDZOWoS+frznyFfBze/NCntyQO84l/ecd6/TfmsL+ruKxReN1aWNzn6ddci/TJENjM K8KBvFsn6+L+ko8tsysjiegxGiTZ0PNCxPXdSILRHlu+JMGmSIjJvoHGht+KAqKwAzUs e6LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=GnjT36BfdZMIREEGQgqOOO7FD0DKQJ6bOT1EN1ic3LA=; b=xkhByp+1BnE1ZooE7OjVsxaBJzPi+/4rAWjjJR4P3VbMC/M9ZZKwb1HwJ9X7h5mQYK hsoHd2CrsxtGQHfFdb8iQIbNSeoHCZdX6puKObF4LyK/GM1o0DUyMFzmRXqT4lQK2WYs 8bEV3tMyDzrJWDepXC8MxPZuhEpVwQ86gs+/cfrBul+bSevo619wOQEqr0nRKVOS8gvm n07ihjw/ZVxtYDZBHRtBGqDQnJAhoI+CP1ctKmkZJf1/y/x3lmsDuGOEaglRFJ1Wa8nK kQxIO+MbpaGKnKT68URR1XVszytAp9yJa4ssUtiEaV2ZLQVgknX+wy1L2luPCRZeHEdy 1ATQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id v28si11432507ejk.540.2021.05.30.11.04.08; Sun, 30 May 2021 11:04:09 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DB58D680A9A; Sun, 30 May 2021 21:04:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe03-3.mx.upcmail.net (vie01a-dmta-pe03-3.mx.upcmail.net [62.179.121.162]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A7E646807DC for ; Sun, 30 May 2021 21:03:56 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe03.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1lnPn2-0080do-0E for ffmpeg-devel@ffmpeg.org; Sun, 30 May 2021 20:03:56 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id nPm3lulxpljeHnPm4lXGHF; Sun, 30 May 2021 20:02:56 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=BoHjPrf5 c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=FQZ629iBD-WIhpg_:21 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=fmkP-PizMvo58UVUTFkA:9 a=LQpmy1yfScQw-u9GFHM1:22 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 30 May 2021 20:02:53 +0200 Message-Id: <20210530180255.23554-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfGB3r9FcBfCWFao54JcToCzCDHPAZTjzOUHI8n6Rja8Q+CEfn47H6wVYULwUz1nN25Y3fq/C/XH9wz6l1ZKhqbDiMXkiUSde+z0czDgUoaqPT9KYtI2t /uv/Jsn/7Ln7HvLT/Neu3nHuomeclHvWA1NaJQDjmB526Gj6Cao0sZWN Subject: [FFmpeg-devel] [PATCH 1/3] avcodec/svq1enc: Do not print debug RD value before it has been computed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: J+uL1d2DwtGm Avoids floating point division by 0 Fixes: Ticket8191 Signed-off-by: Michael Niedermayer --- libavcodec/svq1enc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index 09fa15a3a2..91a208180b 100644 --- a/libavcodec/svq1enc.c +++ b/libavcodec/svq1enc.c @@ -486,9 +486,10 @@ static av_cold int svq1_encode_end(AVCodecContext *avctx) SVQ1EncContext *const s = avctx->priv_data; int i; - av_log(avctx, AV_LOG_DEBUG, "RD: %f\n", - s->rd_total / (double)(avctx->width * avctx->height * - avctx->frame_number)); + if (avctx->frame_number) + av_log(avctx, AV_LOG_DEBUG, "RD: %f\n", + s->rd_total / (double)(avctx->width * avctx->height * + avctx->frame_number)); s->m.mb_type = NULL; ff_mpv_common_end(&s->m);