diff mbox series

[FFmpeg-devel] fate: fix input arguments for fate-unknown_layout-ac3

Message ID 20210606131045.1771-1-jamrial@gmail.com
State New
Headers show
Series [FFmpeg-devel] fate: fix input arguments for fate-unknown_layout-ac3
Related show

Checks

Context Check Description
andriy/x86_make success Make finished
andriy/x86_make_fate success Make fate finished
andriy/PPC64_make success Make finished
andriy/PPC64_make_fate success Make fate finished

Commit Message

James Almer June 6, 2021, 1:10 p.m. UTC
The input stream is a raw 16 bit audio one, so trying to read it as a
32 bit one is incorrect. The test can and will autoinsert a resampler
as needed.

Use the oneline comparison for the final result as well, while at it.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 tests/fate/ffmpeg.mak             | 4 +++-
 tests/ref/fate/unknown_layout-ac3 | 1 -
 2 files changed, 3 insertions(+), 2 deletions(-)
 delete mode 100644 tests/ref/fate/unknown_layout-ac3

Comments

Valerii Zapodovnikov June 7, 2021, 9:24 a.m. UTC | #1
Do you know what command to use with
http://fate-suite.ffmpeg.org/dolby_e/16-11.pcm? I used  -ac 6, but I dunno
everything else I used was not giving perfect sound (-f s16le -ac 6 was
most important to at least get something playable). Sigh.  Also I suppose
sample rate will not be 48000 since it is PAL Dolby E. Thank you :)
James Almer June 9, 2021, 1:35 p.m. UTC | #2
On 6/7/2021 6:24 AM, Valerii Zapodovnikov wrote:
> Do you know what command to use with
> http://fate-suite.ffmpeg.org/dolby_e/16-11.pcm? I used  -ac 6, but I dunno
> everything else I used was not giving perfect sound (-f s16le -ac 6 was
> most important to at least get something playable). Sigh.  Also I suppose
> sample rate will not be 48000 since it is PAL Dolby E. Thank you :)

Judging by the source dolby-e sample it's being compared to by the FATE 
test, -f s16le -ac 6 -ar 44800.
diff mbox series

Patch

diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
index 4dfb77d250..42152aca64 100644
--- a/tests/fate/ffmpeg.mak
+++ b/tests/fate/ffmpeg.mak
@@ -82,8 +82,10 @@  fate-unknown_layout-pcm: CMD = md5 \
 
 FATE_FFMPEG-$(call ALLYES, PCM_S16LE_DEMUXER AC3_MUXER PCM_S16LE_DECODER AC3_FIXED_ENCODER) += fate-unknown_layout-ac3
 fate-unknown_layout-ac3: $(AREF)
+fate-unknown_layout-ac3: CMP = oneline
+fate-unknown_layout-ac3: REF = 9455adf10ae2a09850c57f2993fb4316
 fate-unknown_layout-ac3: CMD = md5 -auto_conversion_filters \
-  -guess_layout_max 0 -f s32le -ac 1 -ar 44100 -i $(TARGET_PATH)/$(AREF) \
+  -guess_layout_max 0 -f s16le -ac 1 -ar 44100 -i $(TARGET_PATH)/$(AREF) \
   -f ac3 -flags +bitexact -c ac3_fixed
 
 
diff --git a/tests/ref/fate/unknown_layout-ac3 b/tests/ref/fate/unknown_layout-ac3
deleted file mode 100644
index 719a44aacf..0000000000
--- a/tests/ref/fate/unknown_layout-ac3
+++ /dev/null
@@ -1 +0,0 @@ 
-febdb165cfd6cba375aa086195e61213