From patchwork Mon Jun 14 17:56:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shubhanshu Saxena X-Patchwork-Id: 28268 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5e:c91a:0:0:0:0:0 with SMTP id z26csp3070728iol; Mon, 14 Jun 2021 11:20:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyk4Qz6OheUNl0XYyO9+ErY18X3MdJb5S2e/z0hnNKt5jNudNUKKvSKJk4WUZVcq358hRg5 X-Received: by 2002:a50:fc9a:: with SMTP id f26mr18241769edq.216.1623694814304; Mon, 14 Jun 2021 11:20:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623694814; cv=none; d=google.com; s=arc-20160816; b=JdjMaL9WhujBQL5jyz46RNFUaBwCjQPQsY1ZJAicw7He7T/7fdoSqAAZkgpiOF1rpa Sea6iRTZZD+yhvCiszH5/MWfVDg0s49Gu+v4bczGmubqQZpu37jnlbKmnEhLDG4aFjeL Gjn4kB8GsrCSQOwbFiS+wZvJwO4+Lc5U1ws33pJ7WdolytwI+Ad5f8PIx0B7ZL+MVgdh XpHPnXdCj5B8TL/fFOLk+Xra0Ei8ygSVT675zS7xwL08kBX6SZIh0F7X0Nadqn7uthw8 Jx1AzUnsp1Lh74Mo7HXP80P/BqDKIewEj+9P5hr1lLLwJzqJYYGwb3XQP+ZQUCi/Y+jn B+CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=kTLBrDM1WRJpyMxTHx3l8BDa+nhSSD2YN4vQpyIC7ng=; b=bKK604OWToyywnqt8T6wycJGBou9ARNkTJ7aIp998QqDx8kFFQmETYDq7eOYq5+FrV JHLtjbuSeTVrGUhoVif5o3IkjWC4G2nVLICHZK5SYUsClKf5afxmdHvwRwVOLDbv9sYF y/UCvqXmzKwx1yFsr6IlnW5496dqjB4ldG0Y+2jOuS4SRRLsXEVTJkCVlBHjlTa71gCD Kndg1fN8YMhl92xN+XAtcwsyttXie51v9hLY2mYl1i+wcIoUft/BJLtbpnfOnW1PtS2J 3fNAMHRDjTxOyTddk7gjw2hSg0JqsjbM6lnaIB9I4G3Pn/rot2iuNmUdCZsO5KNhZz2E GVVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=c1wnbdpe; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s19si11784001ejj.534.2021.06.14.11.20.13; Mon, 14 Jun 2021 11:20:14 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=c1wnbdpe; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EA1B56897E8; Mon, 14 Jun 2021 21:20:10 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 55C6C68804C for ; Mon, 14 Jun 2021 21:20:04 +0300 (EEST) Received: by mail-oi1-f169.google.com with SMTP id q10so11085534oij.5 for ; Mon, 14 Jun 2021 11:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oj8UMinPXm1csj/0ZudRmBswKJEZiU8qPcLnPHTvmKI=; b=c1wnbdpe1qEL5Pd18Nuz11SZeAGjK5/P5WOr7KJLmzAkTbD880NHeA1lN4RaKOOuvu XfZuMLgiJglNToeC7lgTXkWtII7ZXKxbIfYLroIebLDAH8YC8G3gzQpK3eCBiLghoVV6 znSgA1o1vu1i7USPb5LGWdCGJKxyFQZCxfWivTxAJ+RXt64BQ6Kl0ZhrQ6WOXcKxa+L4 auxtLVSmdiQaImUwtsTPr1OiSm8fPvsK3qr6ddVpinJe11iF82xLKTy/3EeQ2eonRvVW ZS8JKhh0ptigwvq5lwPSgPsEfsdm3VX0AX817oecfhWFd7cNzJPzKZoYvuyqOwYpWvqt 0Anw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oj8UMinPXm1csj/0ZudRmBswKJEZiU8qPcLnPHTvmKI=; b=bS7WUfKLdKyazWFjuyCDhg4BGTbqbPrRx7FpB6+IesOqmiTQ7qyJ3vYAvuFNTZw118 a0L0duJoLsc6et06PoHvv9mj44N+kXzhFW7JKLH3p2rbA3+iYl48lF8wtcD5yEq3Zf8I rzRRgyZTaCb7FmkU0gKnEzrzx9hzdCpQq85rUVu0GNeL4hb8mej8jM6KRIYvdNfTRYmU rikApE4yNqeZPwo7lSPRXWyln69C76OWjNSPJ+F9x1UZ5IdLE/ruWgw1fc7i7CHeK9LF 1b8LY3ZzNd1Y5wQp0KD3rnATlUIsg8NqndrlKzbLH8V/7Xav5gBehZxZPj1rrgkgNDL7 Taqg== X-Gm-Message-State: AOAM5312sQAztsh9cIXekx66TwrXMjk12wQWFbFl+Qbi0TDkg6QTZEyv 4QyPz+4mwUTnVabIObs9ydQYBulFXp7gpg== X-Received: by 2002:a17:90b:8c4:: with SMTP id ds4mr20369340pjb.65.1623693413555; Mon, 14 Jun 2021 10:56:53 -0700 (PDT) Received: from Pavilion-x360.bbrouter ([103.157.220.233]) by smtp.googlemail.com with ESMTPSA id d8sm13491370pfq.198.2021.06.14.10.56.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 10:56:53 -0700 (PDT) From: Shubhanshu Saxena To: ffmpeg-devel@ffmpeg.org Date: Mon, 14 Jun 2021 23:26:16 +0530 Message-Id: <20210614175615.15222-1-shubhanshu.e01@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavfi/dnn_backend_openvino.c: Fix Memory Leak for RequestItem X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Shubhanshu Saxena Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: nFyO1AiYzcrb Fix memory leak for RequestItem upon error while pushing to the request_queue in the completion callback. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_openvino.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 709a772a4d..702c4fb9ee 100644 --- a/libavfilter/dnn/dnn_backend_openvino.c +++ b/libavfilter/dnn/dnn_backend_openvino.c @@ -293,6 +293,8 @@ static void infer_completion_callback(void *args) request->inference_count = 0; if (ff_safe_queue_push_back(requestq, request) < 0) { + ie_infer_request_free(&request->infer_request); + av_freep(&request); av_log(ctx, AV_LOG_ERROR, "Failed to push back request_queue.\n"); return; }