From patchwork Thu Jun 24 06:22:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohammad Izadi X-Patchwork-Id: 28608 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2042:0:0:0:0 with SMTP id z2csp167416iod; Wed, 23 Jun 2021 23:22:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeCsFOfM0vYhCFPkq12mDeiDa6MoQnR3BE8k9UKOdfEsli1nzh+B2Xj/OYhORfs5fn96Mp X-Received: by 2002:a17:907:20f7:: with SMTP id rh23mr3672941ejb.64.1624515770386; Wed, 23 Jun 2021 23:22:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624515770; cv=none; d=google.com; s=arc-20160816; b=dt1zzm9XbwndQ/oef4LHJp/mhW7MZMnZ5lpxpDZ2rdxtM0c1ZrRzmSMY9bHmLRlSES 1ezp0FUa6zW2kmjUSwjbamoLK9xSsZZ6fSkp8gNUJBWOa+VKa5QQpOvAESCxQxSJyllN z5LQsDiRXK0e5MhbJJhonre0tvOxvUxRvgI4ERZGQxIBX/IpwdRoGtv44oXcA6BWTm4Z sQDEqQ3mAffoJAdEZhQfBEdbt5QPE7DGf/zC/XMcDLewpXrsZyqaLnx15IW3FEoy7XPK 5SUa7AGS1BLIsvzOau0IJEba/9RpyzpN0oVHGvavLHyCVFAbOB8DN5E/46zDclSTf6iu aFdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:to:from:references:mime-version :message-id:in-reply-to:date:dkim-signature:delivered-to; bh=astJbLJ46A/5p8TJleLl3NSqXLxhY5er6aDwibvLBaA=; b=ABAbVlnN04uTU/0JySsjbxumEbi9vrVcbDVMUbp5W4gx6tmjNLvraDqB74p6k8BRXw hSdaUNHrQP3ONqwJ5HBeQZ+KBsGDqsdZHrU6WwEL5+lrfG3nlNwAmFq8z/jQYt5dbi/7 ePLV4CwXV/F4ymfLsFZrNF+ubGX9GDksLtJgHEwcuYBELP2Xm8uKsZghVxE3M+gklYOk DP0FKn2lSgKs2hz5ZG3eiFCSX0H1wbepjdXarhKyaGi8xny64FtyOjb0XHeDdqCe5DV8 BYLobkJl6h/Zezuux/NSp+heZs+ZoMWLhAlHXqE/4Lt5b9xwl3eTIgYU2nkVeN/Y58h9 wQLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20161025 header.b=PEFP4Pdu; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j20si2107159edw.80.2021.06.23.23.22.49; Wed, 23 Jun 2021 23:22:50 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20161025 header.b=PEFP4Pdu; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4ADB068A0F1; Thu, 24 Jun 2021 09:22:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f202.google.com (mail-qt1-f202.google.com [209.85.160.202]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E133F689F8F for ; Thu, 24 Jun 2021 09:22:38 +0300 (EEST) Received: by mail-qt1-f202.google.com with SMTP id g4-20020ac80ac40000b029024ead0ebb62so5216281qti.13 for ; Wed, 23 Jun 2021 23:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=sJIDlQ3+S4Z+FWshzinGsgu3QsN9NIu158e6gJvFM2A=; b=PEFP4Pduafw99/J0WCPLhx/lV1oOkspb0ISHhWiVBYRDgokiRN7k1verFSRCwaj8ov rwg8YMa6/uDcExw20hd7JUx+WRup8stMQAp4sKDYkYHpdTg879POOk8i0Uz/YbKXafav ucMieSbvOikcXyfD21tebhp3WxLVjV5gR73u3fleJHlk8RG6UQlJtI1BRZArHUgP0+0f Zrg7HD9JV8cmVPTUafj6B18yQDgkvyGnefRuq2Rzm3GRyJOgXOSRTlDgjck8SoQ+u81A yaKWH2+Bq3Kvz82QzLV/XAILYNqlJYG6D0/YoBigVYqhfXX/+eOPajfIgqJ+oWwrrdXS gw3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=sJIDlQ3+S4Z+FWshzinGsgu3QsN9NIu158e6gJvFM2A=; b=IjoK2oMMHlNlLmCYVBKbROrxjUuJaTUbz0KQt0pKGPmFB4Uk9itJniIswj2kadIJj2 LJisR3TnPHj9YoKx3s3v0c7Z/f3DckPQVsKNskPTeYxIuresQLbmfnkXr2qwnA6QoIAE AmhjGVyD4Wm5DtaQCkL41SCvuNvBZbs7lZfDRAK4nwiQ9v/1O774ctS1EVUKKMbwj5FL unS/ROflhv2azw+0Bqh+1TpMP5EMb7mHUf1npgc0chKwFF0IchtAhCNo9ZXOB5Nc4hi+ OMfShGvX8qT2DFOokTHsBKyTW3J6ucYegAcVhWcYkPx+eaL7WNqn1f8zenGJuPDH+Dhk 9aqA== X-Gm-Message-State: AOAM531P9J/9cIRF+NKBsVC42VNLRQR/GHQnjaGjtw5KvwUROizJfVX3 nYC4qclbKHAgVwjk8hJi8K5XRYm6LPXcSshpC6pBtZhPWSqb5NDE0c3nxKJMw4pkz84ZPSdwYSY e7zPs2it2RHQA+usVQIJyQhfYlf5tNET8myx+9tHU4gBXl0Ku0wtZymYaf7aR X-Received: from izadi.mtv.corp.google.com ([2620:0:1000:4001:1ccf:14cb:da24:ee09]) (user=izadi job=sendgmr) by 2002:a25:bb08:: with SMTP id z8mr3033083ybg.188.1624515756764; Wed, 23 Jun 2021 23:22:36 -0700 (PDT) Date: Wed, 23 Jun 2021 23:22:31 -0700 In-Reply-To: Message-Id: <20210624062231.3957081-1-izadi@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.32.0.288.g62a8d224e6-goog From: Mohammad Izadi To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Mohammad Izadi Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 6wxsSUHhWRlq HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing it to the AVPacket side data. --- doc/APIchanges | 2 + libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/libvpxenc.c | 91 ++++++++++++++++++++++++++++++++++++++++++ libavcodec/packet.h | 8 ++++ libavcodec/version.h | 4 +- 6 files changed, 105 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 06493763b3..162b4db050 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,6 +13,8 @@ libavutil: 2021-04-27 API changes, most recent first: +2021-05-25 - xxxxxxxxxx - lavc 59.2.100 - packet.h + Add AV_PKT_DATA_DYNAMIC_HDR10_PLUS 2021-06-09 - xxxxxxxxxx - lavf 59.3.100 - avformat.h Add pts_wrap_bits to AVStream diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 7383d12d3e..800bee3489 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -289,6 +289,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type) case AV_PKT_DATA_ICC_PROFILE: return "ICC Profile"; case AV_PKT_DATA_DOVI_CONF: return "DOVI configuration record"; case AV_PKT_DATA_S12M_TIMECODE: return "SMPTE ST 12-1:2014 timecode"; + case AV_PKT_DATA_DYNAMIC_HDR10_PLUS: return "HDR10+ Dynamic Metadata (SMPTE 2094-40)"; } return NULL; } diff --git a/libavcodec/decode.c b/libavcodec/decode.c index e5e4256871..568710cf4a 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -1497,6 +1497,7 @@ int ff_decode_frame_props(AVCodecContext *avctx, AVFrame *frame) { AV_PKT_DATA_A53_CC, AV_FRAME_DATA_A53_CC }, { AV_PKT_DATA_ICC_PROFILE, AV_FRAME_DATA_ICC_PROFILE }, { AV_PKT_DATA_S12M_TIMECODE, AV_FRAME_DATA_S12M_TIMECODE }, + { AV_PKT_DATA_DYNAMIC_HDR10_PLUS, AV_FRAME_DATA_DYNAMIC_HDR_PLUS }, }; if (!(avctx->codec->caps_internal & FF_CODEC_CAP_SETS_FRAME_PROPS)) { diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 94932a48da..a7de6b5321 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -64,6 +64,11 @@ struct FrameListData { struct FrameListData *next; }; +typedef struct FrameHDR10Plus { + int64_t pts; + AVBufferRef *hdr10_plus; +} FrameHDR10Plus; + typedef struct VPxEncoderContext { AVClass *class; struct vpx_codec_ctx encoder; @@ -121,6 +126,8 @@ typedef struct VPxEncoderContext { int tune_content; int corpus_complexity; int tpl_model; + int discard_hdr10_plus; + AVFifoBuffer *hdr10_plus_fifo; /** * If the driver does not support ROI then warn the first time we * encounter a frame with ROI side data. @@ -316,6 +323,51 @@ static av_cold void free_frame_list(struct FrameListData *list) } } +static av_cold int add_hdr10_plus(AVFifoBuffer *fifo, struct FrameHDR10Plus *data) +{ + int err = av_fifo_grow(fifo, sizeof(*data)); + if (err < 0) + return err; + av_fifo_generic_write(fifo, data, sizeof(*data), NULL); + return 0; +} + +static av_cold void free_hdr10_plus_fifo(AVFifoBuffer **fifo) +{ + FrameHDR10Plus frame_hdr10_plus; + while (av_fifo_size(*fifo) >= sizeof(frame_hdr10_plus)) { + av_fifo_generic_read(*fifo, &frame_hdr10_plus, sizeof(frame_hdr10_plus), NULL); + av_buffer_unref(&frame_hdr10_plus.hdr10_plus); + } + av_fifo_freep(fifo); +} + +static int copy_hdr10_plus_to_pkt(AVFifoBuffer *fifo, AVPacket *pkt) +{ + FrameHDR10Plus frame_hdr10_plus; + uint8_t *data; + if (!pkt) + return 0; + if (av_fifo_size(fifo) < sizeof(frame_hdr10_plus)) + return 0; + av_fifo_generic_peek(fifo, &frame_hdr10_plus, sizeof(frame_hdr10_plus), NULL); + if (!frame_hdr10_plus.hdr10_plus || frame_hdr10_plus.pts != pkt->pts) + return 0; + av_fifo_generic_read(fifo, &frame_hdr10_plus, sizeof(frame_hdr10_plus), NULL); + if (!frame_hdr10_plus.hdr10_plus) + return 0; + + data = av_packet_new_side_data(pkt, AV_PKT_DATA_DYNAMIC_HDR10_PLUS, frame_hdr10_plus.hdr10_plus->size); + if (!data) { + av_buffer_unref(&frame_hdr10_plus.hdr10_plus); + return AVERROR(ENOMEM); + } + + memcpy(data, frame_hdr10_plus.hdr10_plus->data, frame_hdr10_plus.hdr10_plus->size); + av_buffer_unref(&frame_hdr10_plus.hdr10_plus); + return 0; +} + static av_cold int codecctl_int(AVCodecContext *avctx, enum vp8e_enc_control_id id, int val) { @@ -384,6 +436,8 @@ static av_cold int vpx_free(AVCodecContext *avctx) av_freep(&ctx->twopass_stats.buf); av_freep(&avctx->stats_out); free_frame_list(ctx->coded_frame_list); + if (ctx->hdr10_plus_fifo) + free_hdr10_plus_fifo(&ctx->hdr10_plus_fifo); return 0; } @@ -835,6 +889,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, #endif AVDictionaryEntry* en = NULL; + ctx->discard_hdr10_plus = 1; av_log(avctx, AV_LOG_INFO, "%s\n", vpx_codec_version_str()); av_log(avctx, AV_LOG_VERBOSE, "%s\n", vpx_codec_build_config()); @@ -851,6 +906,14 @@ static av_cold int vpx_init(AVCodecContext *avctx, if (avctx->codec_id == AV_CODEC_ID_VP9) { if (set_pix_fmt(avctx, codec_caps, &enccfg, &flags, &img_fmt)) return AVERROR(EINVAL); + // Keep HDR10+ if it has bit depth higher than 8 and + // it has PQ trc (SMPTE2084). + if (enccfg.g_bit_depth > 8 && avctx->color_trc == AVCOL_TRC_SMPTE2084) { + ctx->discard_hdr10_plus = 0; + ctx->hdr10_plus_fifo = av_fifo_alloc(sizeof(FrameHDR10Plus)); + if (!ctx->hdr10_plus_fifo) + return AVERROR(ENOMEM); + } } #endif @@ -1213,6 +1276,15 @@ static int storeframe(AVCodecContext *avctx, struct FrameListData *cx_frame, AV_WB64(side_data, 1); memcpy(side_data + 8, cx_frame->buf_alpha, cx_frame->sz_alpha); } + if (cx_frame->frame_number != -1) { + VPxContext *ctx = avctx->priv_data; + if (!ctx->discard_hdr10_plus) { + int err = copy_hdr10_plus_to_pkt(ctx->hdr10_plus_fifo, pkt); + if (err < 0) + return err; + } + } + return pkt->size; } @@ -1620,6 +1692,25 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket *pkt, vp9_encode_set_roi(avctx, frame->width, frame->height, sd); } } + + if (!ctx->discard_hdr10_plus) { + AVFrameSideData *hdr10_plus_metadata; + // Add HDR10+ metadata to queue. + hdr10_plus_metadata = av_frame_get_side_data(frame, AV_FRAME_DATA_DYNAMIC_HDR_PLUS); + if (hdr10_plus_metadata) { + int err; + struct FrameHDR10Plus data; + data.pts = frame->pts; + data.hdr10_plus = av_buffer_ref(hdr10_plus_metadata->buf); + if (!data.hdr10_plus) + return AVERROR(ENOMEM); + err = add_hdr10_plus(ctx->hdr10_plus_fifo, &data); + if (err < 0) { + av_buffer_unref(&data.hdr10_plus); + return err; + } + } + } } // this is for encoding with preset temporal layering patterns defined in diff --git a/libavcodec/packet.h b/libavcodec/packet.h index fad8341c12..a9d3a9b596 100644 --- a/libavcodec/packet.h +++ b/libavcodec/packet.h @@ -290,6 +290,14 @@ enum AVPacketSideDataType { */ AV_PKT_DATA_S12M_TIMECODE, + /** + * HDR10+ dynamic metadata associated with a video frame. The metadata is in + * the form of the AVDynamicHDRPlus struct and contains + * information for color volume transform - application 4 of + * SMPTE 2094-40:2016 standard. + */ + AV_PKT_DATA_DYNAMIC_HDR10_PLUS, + /** * The number of side data types. * This is not part of the public API/ABI in the sense that it may diff --git a/libavcodec/version.h b/libavcodec/version.h index 4518f697e2..1288cecebe 100644 --- a/libavcodec/version.h +++ b/libavcodec/version.h @@ -28,8 +28,8 @@ #include "libavutil/version.h" #define LIBAVCODEC_VERSION_MAJOR 59 -#define LIBAVCODEC_VERSION_MINOR 1 -#define LIBAVCODEC_VERSION_MICRO 102 +#define LIBAVCODEC_VERSION_MINOR 2 +#define LIBAVCODEC_VERSION_MICRO 100 #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \ LIBAVCODEC_VERSION_MINOR, \