From patchwork Thu Jul 1 18:20:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Izen X-Patchwork-Id: 28733 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5d:965a:0:0:0:0:0 with SMTP id d26csp935938ios; Thu, 1 Jul 2021 12:21:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMYpmmPFPFyv9Gq9As2s+rW/I6keOJ3BEqxLFL/K0QhJeahjzLnuESmPoTBkHdFnqMD2Ke X-Received: by 2002:a05:6402:5204:: with SMTP id s4mr1948452edd.52.1625167293751; Thu, 01 Jul 2021 12:21:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625167293; cv=none; d=google.com; s=arc-20160816; b=udhIL/3qisOs/FmTj87jTZmtCbLDr+ud1HbNhbi2y1hJdQze3A3BM1oQiDLZ3x78gu OBGhJsIj/ec6LwThPX5goRzpMGaGowO5YYwvvnWyFw6aAp3TwI98+43ikxcgayhd22aW lY5xwLjNSEqfiFLF7uLRs4oLTNkxGpO0ouq3TYLYLlOWVUcwcwyYgnkbfyVGcrBZGX71 6dKaI3UPHj/uzxGSiW+Wh6JDCN1X3euN+anpSjhCD664E9Nws8YfAmECf1U0JsGQ/R2z vbkq7Aym4PP9MeQLljJRvdbjho5UscDECQ7Axi8BJ70PLwSJdCzt5klgv4RYa2uzKfnd ghfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=dwahjiTNw7bEeld/24AGim2K/ZMYQrnsGKMXSB7t3tM=; b=Ewa43Xct3M6nEFIAMv40WX12je9O5bG8MimIbsAVm0TxqEW7HcHSaUxv7ijb3IKZgI KCq6lE4iBTvSz+OfXP6wBp2fcF387xVUplacbn6AFwwIK08wURxfbIr5/BZ7XWbW8tr0 V/0FVTp8X3hGXQtvR0osTxQcWBCS/3AoJQLTDVdc72N2L+buQjSeWJLbsxlGoNyXIvXK oPC4nOcyDFdm/C064ex6zAUWCoST0JvPnBXV9oIpkD2839jB2GcjyNkhCa7n9YmQQCsP eplutT88bt/y2fFUarJMG+j0YTb3VDd691JdlDD5l59M0cpxvCvHnfUMQF+a1c2ORRsc W/BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=VeCjq0RP; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c16si665933edw.370.2021.07.01.12.21.32; Thu, 01 Jul 2021 12:21:33 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=VeCjq0RP; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CD8196897DE; Thu, 1 Jul 2021 22:21:29 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 073746897DE for ; Thu, 1 Jul 2021 22:21:22 +0300 (EEST) Received: by mail-qk1-f181.google.com with SMTP id 19so7077322qky.13 for ; Thu, 01 Jul 2021 12:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uIPEIfHEK9DUQutksTgwFkQhd4fodvD7JvaJg++wFv4=; b=VeCjq0RP++thWMgo0HfRAn5aWgFtWnhA3zpB0jQuIwgAYBySa3w0V3tpZ4McwI7WNz 4qI66dUfNsvgbv2OteKZ1ck/n1pRpkVlIaZG25Juk8XPbNPzVRvPg2z0Lh3LLV7N3Gpz MIW2Q/jN25K4EB0iOZxZWQCAZLEBXBhDEReZ4mGzhwPWq/7vhPbtWpKRFMawkm4r4Oa5 fKDrqddOXosra6tsHMw37Yq5P125Vld0WOnrdVabJIDgxUdvJ8zD4zjtlohyW5uYjkhd PcQQruHqdyJm2/YRU++vfCJvzOMyziIS0HxB5dVLBmaoxfRjIK38W+DHpNeH7W6nwF8R PGkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uIPEIfHEK9DUQutksTgwFkQhd4fodvD7JvaJg++wFv4=; b=OTRF/5Zgc7Y6dy2GjzMXKZFtsxhyIxVINw7jixUgJk2MjrX25L+jZjBBuqLVye7Hbk XlkJYu4687f9GxfUIZG4z2HlOvYYGeOOc/+pbb2+FMpfjqiJuzEsKATecLbFBuEzfhNC CyhrRrJutSW7QUnjd4e0fXiuSYXlV4cvblSv/bUMlUv5iTcq80FnUJmBs6C4Np6QQCai DcYiLpSSQ1YAusq9RohPwMnE0wuUz2xca/1BpnA1VNb3xOWb/RpOUNt9bp2IBrrMrac6 eoqSXWFhwXNcVOvGHFZKVFjlydX+8Gm9P2HZIFVEMkoRXqCidOCPNYIdJCkpWyLZiTw7 FNag== X-Gm-Message-State: AOAM531Nyf47hm28+1Q5/981x3iEkoq9f/uDPfGNIESB6ua90t9HawRM mQfJ4wnEvg/mQUoOe2XBXxn2wUCmObXEPH3S X-Received: by 2002:a37:7704:: with SMTP id s4mr1313976qkc.447.1625163671001; Thu, 01 Jul 2021 11:21:11 -0700 (PDT) Received: from gauss.local ([71.73.92.220]) by smtp.gmail.com with ESMTPSA id j8sm290814qti.20.2021.07.01.11.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 11:21:10 -0700 (PDT) From: Leo Izen To: ffmpeg-devel@ffmpeg.org Date: Thu, 1 Jul 2021 14:20:51 -0400 Message-Id: <20210701182051.222783-1-leo.izen@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] configure: Fix some unsafe shell practices X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 5FLtyB4EsQLb This commit fixes some unsafe shell pratcies in ./configure, particularly those that involve variable expansions on possibly unsanitized data in unsafe ways. This commit corrects this behavior in a small number of locations. --- configure | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/configure b/configure index b124411609..dd910f538f 100755 --- a/configure +++ b/configure @@ -530,7 +530,7 @@ warn(){ die(){ log "$@" - echo "$error_color$bold_color$@$reset_color" + echo "$error_color$bold_color$*$reset_color" cat < $TMPH + echo "static const $struct_name * const ${name}[] = {" > $TMPH for c in $*; do if enabled $c; then case $name in