From patchwork Mon Jul 5 02:29:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Wang X-Patchwork-Id: 28769 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5d:965a:0:0:0:0:0 with SMTP id d26csp3736255ios; Sun, 4 Jul 2021 19:32:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZy5JotEDeZycorHXvHKRsDvGC9evysRij2T320GFWjmV2uUW/cwd+1qYuMBsuu/fbdj2j X-Received: by 2002:a17:906:9745:: with SMTP id o5mr11326700ejy.344.1625452322404; Sun, 04 Jul 2021 19:32:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625452322; cv=none; d=google.com; s=arc-20160816; b=lhr+1KRLQAPL5riQ1SEsIhq5QUMsh7QsG6Ya50E6JHQBKLKR33U2Ky6qBI4xluemiL KHkuqdjHfHoD9IyXmORbKQvwPe14I9tZptluex5Z1yGUrHitUlZdZCsNlGSQkHd13m3e Pnj22yZxL1H5UyyZAiVIxUveUZImNNwYp28Xf2eeQxMpQhHptTfyYJM2n6kpthV6gRYO Sm3iN90XmuO4GZ+ofQdagv9aTrf1iOYk+th7I87rFUSHSLM9q1CPAkUPvv1J10BPMe+D 5drKCO9TgTii/H60EiqO2JN0wSYeqxYSs6cGPO73ZVi5DQuYsvMTVid2wAERmk9Opd8p Ea+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=QqQ8VsybTg6BIk/duuRA+Edl7tDJ1o/zKD6QOi4sgAs=; b=kgfBTPgJbMkALcgSBNzyu3KMPTVC7idwtmlBo78ybm7OTqxoqyyGY8zxrFRcSxMAg2 +vUkHS/nOLF1/Af34Tt8ry3t+BsEwyKnk5v6abQxSpMfne3b61pB2a1Q6r5zYJBujFP1 xsI/YfpRq6W8Ctpnfert/w6ZTNKUrNZTJvxP6jdZtOLfnuK9UgW1iXHulIlQ8RnBva9x XG+7GsxKlhseFlSevRtqjNp+8TrRdWQbYjzxP0pkGvYvM4rQiHvecp46MWsJSi8aABc9 L63nAPIT1+iAf/eE8dm68hKL/bBh/T+NEYWuIosyOEs9XzImESCHmwVn85JV+5cIrgeE m7XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f22si10287301edf.183.2021.07.04.19.32.02; Sun, 04 Jul 2021 19:32:02 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BE7E368A62B; Mon, 5 Jul 2021 05:31:48 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5BAFF68A5DE for ; Mon, 5 Jul 2021 05:31:40 +0300 (EEST) X-IronPort-AV: E=McAfee;i="6200,9189,10035"; a="208869447" X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="208869447" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2021 19:31:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="456571421" Received: from f.sh.intel.com ([10.239.159.147]) by orsmga008.jf.intel.com with ESMTP; 04 Jul 2021 19:31:34 -0700 From: Fei Wang To: ffmpeg-devel@ffmpeg.org Date: Mon, 5 Jul 2021 10:29:25 +0800 Message-Id: <20210705022933.29068-1-fei.w.wang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH v2 1/9] cbs_av1: fix incorrect data type X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Fei Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: mzWnWB0MiHOU Since order_hint_bits_minus_1 range is 0~7, cur_frame_hint can be most 128. And similar return value for cbs_av1_get_relative_dist. So if plus them and use int8_t for the result may lose its precision. Signed-off-by: Fei Wang --- v2 update: 1. use int16_t instead of int. 2. updated commit message. libavcodec/cbs_av1_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_av1_syntax_template.c b/libavcodec/cbs_av1_syntax_template.c index 6fe6e9a4f3..d98d3d42de 100644 --- a/libavcodec/cbs_av1_syntax_template.c +++ b/libavcodec/cbs_av1_syntax_template.c @@ -355,7 +355,7 @@ static int FUNC(set_frame_refs)(CodedBitstreamContext *ctx, RWContext *rw, AV1_REF_FRAME_ALTREF2, AV1_REF_FRAME_ALTREF }; int8_t ref_frame_idx[AV1_REFS_PER_FRAME], used_frame[AV1_NUM_REF_FRAMES]; - int8_t shifted_order_hints[AV1_NUM_REF_FRAMES]; + int16_t shifted_order_hints[AV1_NUM_REF_FRAMES]; int cur_frame_hint, latest_order_hint, earliest_order_hint, ref; int i, j;