From patchwork Tue Jul 6 09:19:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Diederick C. Niehorster" X-Patchwork-Id: 28797 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5d:965a:0:0:0:0:0 with SMTP id d26csp4919766ios; Tue, 6 Jul 2021 02:22:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHUF5+rbkPnHxSBUsfKIbSGUoRMkQQEXZ4Y1Rvy8ToSR5Rv0lzJzKImk7EyZv0uc0cpXAc X-Received: by 2002:a17:906:69cc:: with SMTP id g12mr17374252ejs.550.1625563323239; Tue, 06 Jul 2021 02:22:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625563323; cv=none; d=google.com; s=arc-20160816; b=pJMQMsPUB1Kkj5eIWmEPRPO6ql2uG3IPJSvcaJ3xsVqNFACt1WDtWrfWWhJFD5pIVY MeuDqu/DcoDm/Tg1B/5MIgrNmTB2lYbN/yX/TTiN8uLcpNbfJm6P5o8fSI1tFXlph2f7 HVL4/IN2u72/gd5bTND4k+aUthBZMM9ImdcYrAPnK3KXw8OPQGeDzMff/hgSAsVFlOf5 tlS5VM3h+n98yAVZWqYHZH+gZJUawcn+Q1mvBT2X9dyIxkPcd1DVAp2JAo4Fwf5JxDGr eXhpcxHT9pU34OOfO8dpfRkU547fzbLB1awlEo3Wj3sDEeV4aDoBINpABG+fBbIoVK0p ZmPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=sokqD8fQSNwKlswcn3buB/0JwLtVDks8mYMf2PcTuYE=; b=xgdKSzNuWmygSbLh3EjUiOEA4v4QYj/Tz+srJL3Djv7DeWjOTAz4nl8OsO6338P9NU 2r+G+39mBVd2/guLOnaAOs9mjvrCDm2WCSbrjQXzcZOzYD9jmXoYTSEQv9uuO4jOlGXE TKi/7kwdJRs7F+57BMq8NisDTZrp0YK9SeltX48MiyT3OlHWy99LSvArUTkvdBz1qLBv uCxT0jEsf3BLbHtOAzgxmlqAXTdM1U3VHpk1XKVYWPPKPpqz0Sc/zdiwhLQKxEHxRtAm 4+uIG21qPkG70DxDYq+eIcHaYbLExeG6tChBhsYiPFukGfBIOwGYXbN2JER4yEybQoxk 4Axg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=fSGqe5fW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n3si14498077ejl.4.2021.07.06.02.22.01; Tue, 06 Jul 2021 02:22:03 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=fSGqe5fW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 782CB68A6F0; Tue, 6 Jul 2021 12:21:55 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5DE6568A69A for ; Tue, 6 Jul 2021 12:21:53 +0300 (EEST) Received: by mail-lf1-f49.google.com with SMTP id n14so37168234lfu.8 for ; Tue, 06 Jul 2021 02:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yJeuo0ydICb0kyFsuJvu0RLWdFppQ9yrf/CpLl4W04Y=; b=fSGqe5fWc8cECNLLI+a1OzjqCl8dMw0QcL2Gig9/l/vBUoE38Hye2LYbJp8k2axlkx rzw2CbPOWL8Iv+Mu7YgTnmByZRTF3CbAAZW866u3VUMXQqmeUAljkzWgl0C3cFqfxrtp rjn7MvREQRGDC09eyRmSmgIsIQM+H4hpeh3t5TRGz4LnY/2p0qoYwpIpgby82MF35z4m o7TMXkdgHnLJtO9M9G+BEDsAG1uYnCfe8kFZFcW6M+S5wpFrG8TOS//3xvTWjzXl1pBC hcgaOFrsn/SEHjdh+TmcoVcUiw4voe0ZMU1FpvMaywH7XHoTU9xcoewCWENlbKgfyHJH QzNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yJeuo0ydICb0kyFsuJvu0RLWdFppQ9yrf/CpLl4W04Y=; b=PdhFMd6EzZKHhzR5P0zaTgkww3KZQeiCxGJ5fjxEQttfnFa3ali+2geJw8J90TdonU FlKFhvn3GAi+YdKPMllUeR2H/zqxXJ0D2eYi707sFh3Nl1XsDc5EsSAQ2ex/raRdB//f 23K+CIZO4FjZlMJD3R771vzxj4QNHNWPo/EvvUQnYaNtcPzg6gKzj3+JMPpBP67vnGAB faQJ3foN/5yIa9vurM922vMOKcmNGejViVNyUKefRMjK/UkgCwfldZ6nmjj3SQZj9opH lffIHBW6UNk1PjIcqyqEpburenTJFoHHvJd5hVJy7AxRJG4txRnAZnDb8l8H04dQOCJ2 oI4A== X-Gm-Message-State: AOAM533/VYb/fjg/sLaJPWwg9mgaCiMXe5QGvtiS4sW7kML6t2WlEFfr v9UC/HabR9UW04BmOi7+L6M2s3EYjdk= X-Received: by 2002:a05:6512:3049:: with SMTP id b9mr13849723lfb.395.1625563312171; Tue, 06 Jul 2021 02:21:52 -0700 (PDT) Received: from localhost.localdomain (deedock.humlab.lu.se. [130.235.135.183]) by smtp.gmail.com with ESMTPSA id m16sm1427693lfl.300.2021.07.06.02.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 02:21:51 -0700 (PDT) From: Diederick Niehorster To: ffmpeg-devel@ffmpeg.org Date: Tue, 6 Jul 2021 11:19:51 +0200 Message-Id: <20210706092020.1057-6-dcnieho@gmail.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20210706092020.1057-1-dcnieho@gmail.com> References: <20210706092020.1057-1-dcnieho@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3 05/34] avdevice/dshow: set no-seek flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Diederick Niehorster Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: atINLb2ZlGCQ avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with, e.g., avformat_seek_file()) correctly yields -1 (operation not permitted) instead of -22 (invalid argument). This actually seems to apply to many other devices, at least the gdigrab, v4l2, vfwcap, x11grab, fbdev, kmsgrab and android_camera devices, from reading the source. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 2e9f9ddf3f..389daa6380 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -1336,6 +1336,6 @@ const AVInputFormat ff_dshow_demuxer = { .read_header = dshow_read_header, .read_packet = dshow_read_packet, .read_close = dshow_read_close, - .flags = AVFMT_NOFILE, + .flags = AVFMT_NOFILE | AVFMT_NOBINSEARCH | AVFMT_NOGENSEARCH | AVFMT_NO_BYTE_SEEK, .priv_class = &dshow_class, };